[01:11:06] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [02:13:53] (03CR) 10Addshore: [C: 04-1] Special page for wbmergeitems api module (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [02:18:23] [= [02:20:31] (03CR) 10Addshore: [C: 04-1] (bug 46217) Implement a special page to show items with the most sitelinks (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [02:24:49] (03CR) 10Addshore: (bug 46353) Forbid to label properties as valid property IDs (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [03:01:19] hi. So is there a way to get a current (i.e. Wikidata-provided) list of langlinks via the Mediawiki (not the Wikidata) API? [03:01:20] prop=langlinks seems to query only the locally (in-page, old-style) langlinks, which makes sense. [03:01:30] and #mediawiki sent me here :) [03:05:34] ha, forget it. langlinks does bring me the wikidata langlinks :) I was looking at a redirect. :) [03:09:05] :-) [03:09:22] abartov: I'm not sure if it's a union of local langlinks and Wikidata. [03:09:26] Or if it's one or the other. [03:09:41] I think in the user interface, there's defined precedence. [03:10:40] local langlinks override Wikidata. [03:11:46] legoktm: via index.php and api.php? [03:11:53] yes [03:21:38] works for me :) [03:21:53] I'm adding this functionality to the Ruby MW gateway [03:22:16] thanks, Elsie and legoktm [03:23:51] Ah, nice. [03:25:42] Anyone here have a subscription to The Times (UK) [03:25:43] also, hi [07:16:29] good morning [07:52:12] (03PS2) 10Henning Snater: Table of contents style adjustments [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98520 [07:57:45] is there a way of knowing when Wikidata is approached from the it.wikipedia ? [08:10:05] how do you say that someone won a competition ? [09:33:41] Lydia, having a link to Reasonator and Commons in search results in Wikidata ... would you accept that as a paper cut ? [09:49:47] (03PS1) 10Mayankmadan: Adding readme file to /selenium_cuc/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98784 [09:59:16] (03CR) 10Tobias Gritschacher: [C: 032] Added title attribute to rank icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98531 (owner: 10Henning Snater) [10:02:55] (03Merged) 10jenkins-bot: Added title attribute to rank icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98531 (owner: 10Henning Snater) [10:03:54] GerardM-: we're currently discussing all our search pages and what to do with them. i'll add that to the list [10:10:23] thanks Lydia_WMDE [10:19:50] (03PS1) 10Siebrand: Fix incorrect capitalisations of Item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98790 [10:35:21] (03CR) 10Tobias Gritschacher: [C: 032] Table of contents style adjustments [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98520 (owner: 10Henning Snater) [10:37:13] (03CR) 10Aude: [C: 032] Fix incorrect capitalisations of Item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98790 (owner: 10Siebrand) [10:38:54] (03Merged) 10jenkins-bot: Table of contents style adjustments [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98520 (owner: 10Henning Snater) [10:41:38] [= [10:41:46] wooo [10:41:51] (03Merged) 10jenkins-bot: Fix incorrect capitalisations of Item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98790 (owner: 10Siebrand) [10:42:50] * aude waves [10:43:12] * addshore waves back [10:43:28] its so nice being able to try and review EvErYTHIng :D [10:43:37] :D [10:50:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1311 (master - 5155258 : jenkins-bot): The build was broken. [10:50:32] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2243df04359b...51552581ffbf [10:50:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14856559 [10:57:40] (03PS1) 10Addshore: Refactor Api LangAttributes to Terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98794 [10:59:06] (03CR) 10jenkins-bot: [V: 04-1] Refactor Api LangAttributes to Terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98794 (owner: 10Addshore) [10:59:23] :( [11:00:17] (03PS2) 10Addshore: Refactor Api LangAttributes to Terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98794 [11:00:35] whenever I refactor something the classes file always seems to get messed up... [11:00:38] missing a .php .... [11:03:53] aude: feel free to review ^^ ;p [11:04:42] (03CR) 10Addshore: "For a change for the API stuff see https://gerrit.wikimedia.org/r/#/c/98794/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [11:04:42] addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=57754 - is this a valid bug? [11:04:59] or should I try to resolve it myself? [11:05:14] liangent: ahh yes, I saw the email and it does indeed look like a valid bug [11:05:24] I will try and take a look at it today! [11:06:59] addshore: they're just complaining on my talk page: https://www.wikidata.org/w/index.php?title=User_talk:Liangent&oldid=prev&diff=91334146 [11:10:43] hah [11:12:39] I guess I can see what and where its happening, just trying to work out what should happen... [11:12:48] I guess the edit should just fail with an edit conflict...? [11:13:06] rather than doing some odd merge :P [11:14:06] addshore: I expect an edit conflict [11:18:37] addshore: actually I imagine action=wbeditentity with &clear is rarely used on wikidata, except by me [11:27:41] (03PS1) 10Addshore: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 [11:27:48] liangent: ^^ would be great if you could take a look and test [11:29:11] (03PS10) 10Daniel Kinzler: (bug 57744) Allow ItemContent to represent a redirect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 [11:29:39] (03CR) 10Daniel Kinzler: [C: 04-1] "incomplete. how do i turn this back into a draft?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 (owner: 10Daniel Kinzler) [11:31:31] DanielK_WMDE__: you cant ;p [11:31:44] (03PS1) 10Henning Snater: Check user rights when restricting entity page actions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98796 [11:31:54] you can carry on addign draft patchsets but itll always report them here now :P [11:32:50] (03CR) 10jenkins-bot: [V: 04-1] (bug 57744) Allow ItemContent to represent a redirect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 (owner: 10Daniel Kinzler) [11:33:39] you can remove the change id [11:33:46] then submit it as a new draft [11:33:47] addshore: well if the current data is identical to the given oldid I guess it's fine to clear that [11:33:50] and abandon the old thing [11:34:06] eg. vandalized then reverted [11:34:31] liangent: indeed [11:34:54] (03PS2) 10Henning Snater: Check user rights when restricting entity page actions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98796 [11:36:35] (03PS2) 10Addshore: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 [11:36:36] liangent: ^^ probably works a bit better [11:39:37] addshore: btw I didn't test another case and do you think there's a bug there? rev1: P41="123". Query 1: base=rev1, remove P41="123", add P41="456". Query 2: base=rev1, remove P41="123", add P41="789". (unwanted) Result: P41=["456", "789"]. (maybe) expected: edit conflict [11:40:07] actually when things come to claims, it's difficult to do a merge correctly in code [11:41:05] (clear is not involved in above case. user just remove existing claims by listing them explicitly) [11:41:48] (03CR) 10Daniel Kinzler: "re" (032 comments) [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98087 (owner: 10Daniel Kinzler) [11:41:58] addshore: replied ---^ [11:42:34] btw, please give me a -1 if you want me to respond - otherwise the overview doesn't tell me there is something to respond to :) [11:42:56] it should make it bold shouldnt it DanielK_WMDE__ ? :O [11:43:14] nope [11:43:18] liangent: im stuggling to visualise it, give me a second :P [11:43:39] i think only new change sets are bold. not new comments. [11:44:09] liangent: as far as I can tell that would be the expected outcome [11:45:38] (03PS3) 10Daniel Kinzler: (bug 57588) Scientific notation for quantities. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 [11:46:30] Lydia_WMDE: meep? [11:46:41] DanielK_WMDE__: selber :P [11:46:50] addshore: programmatically yes. in practice many properties expect a single value [11:47:57] DanielK_WMDE__: food? [11:52:38] liangent: the only slightly special case I could see would be rev1: P41="123". Query 1: base=rev1, remove P41="123", add P41="456". Query 2: base=rev1, remove P41="123", add P41="456". (unwanted) Result: P41=["456", "456"]. (maybe) [11:53:46] (03CR) 10Liangent: Die if wbeditentity tries to clear from old revid (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [11:54:14] addshore: yeah [11:58:05] (03PS3) 10Addshore: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 [11:59:45] (03CR) 10Jeroen De Dauw: [C: 04-1] "No test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [11:59:48] right im off for a bit, showering and heading to another part of the city :D [12:00:42] guess I will add write a test for that on my todo list :P [12:00:44] tat for now [12:01:23] (03CR) 10jenkins-bot: [V: 04-1] Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [12:35:40] (03CR) 10Zfilipin: [C: 031] Adding readme file to /selenium_cuc/ [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98784 (owner: 10Mayankmadan) [12:42:59] Lydia_WMDE would you mind to give a t-shirt for a logo for the "Concept Cloud" as well ? [12:59:45] GerardM-: ok [13:01:31] (03PS1) 10Daniel Kinzler: (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 [13:04:13] (03CR) 10jenkins-bot: [V: 04-1] (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 (owner: 10Daniel Kinzler) [13:05:48] (03CR) 10Tobias Gritschacher: [C: 032] (bug 57746) Allow entity pages to use parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 (owner: 10Daniel Kinzler) [13:09:23] (03Merged) 10jenkins-bot: (bug 57746) Allow entity pages to use parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 (owner: 10Daniel Kinzler) [13:18:30] (03PS4) 10Tobias Gritschacher: (bug 57588) Scientific notation for quantities. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 (owner: 10Daniel Kinzler) [13:19:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1313 (master - 3f773e4 : jenkins-bot): The build was broken. [13:19:09] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/232c64833a67...3f773e4cefd4 [13:19:09] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14862662 [13:27:04] back [13:28:41] (03CR) 10Tobias Gritschacher: [C: 04-1] "This is not working correctly sometimes:" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 (owner: 10Daniel Kinzler) [13:32:39] (03PS1) 10Henning Snater: Using text() for site links table header messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98806 [13:33:15] (03CR) 10Tobias Gritschacher: "Also this could have some more tests, especially for the cases which do not work correctly yet." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 (owner: 10Daniel Kinzler) [13:42:15] Lydia_WMDE: what's with https://bugzilla.wikimedia.org/show_bug.cgi?id=44678 ? [13:42:43] it is not assigend but it is about making it possible to change the order of statements [13:47:02] (03CR) 10Aude: [C: 032] Using text() for site links table header messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98806 (owner: 10Henning Snater) [13:51:15] (03Merged) 10jenkins-bot: Using text() for site links table header messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98806 (owner: 10Henning Snater) [13:59:59] Tobi_WMDE: dont forget me ;p [14:00:26] * aude forgot [14:00:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1314 (master - 438ec59 : jenkins-bot): The build was fixed. [14:00:58] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3f773e4cefd4...438ec59570dc [14:00:58] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14864709 [14:02:45] Lydia_WMDE: don't forget addshore [14:16:52] [= [14:17:01] :) [14:17:06] Well, I am sure noone has ever dressed up for the daily before :P [14:17:06] * aude happy [14:24:17] (03CR) 10Tobias Gritschacher: [C: 04-1] Adding readme file to /selenium_cuc/ (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98784 (owner: 10Mayankmadan) [14:35:15] (03CR) 10Tobias Gritschacher: [C: 032] Allow callbacks in factories for formatters/parsers. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98087 (owner: 10Daniel Kinzler) [14:35:49] (03Merged) 10jenkins-bot: Allow callbacks in factories for formatters/parsers. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98087 (owner: 10Daniel Kinzler) [14:38:26] (03CR) 10Zfilipin: [C: 04-1] Adding readme file to /selenium_cuc/ (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98784 (owner: 10Mayankmadan) [14:40:21] (03PS1) 10Daniel Kinzler: Fix extra from DiffOpVisualizer. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98816 [14:41:01] Tobi_WMDE: real quick --^ [14:44:34] looks like my android got compromised, yay -.- :( [14:44:58] :/ [14:45:23] (03CR) 10Aude: [C: 032] Fix extra from DiffOpVisualizer. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98816 (owner: 10Daniel Kinzler) [14:45:48] (03CR) 10Addshore: [C: 032] Fix extra from DiffOpVisualizer. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98816 (owner: 10Daniel Kinzler) [14:45:54] first! [14:45:59] .. :P [14:47:27] (03PS1) 10Henning Snater: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 [14:49:09] (03Merged) 10jenkins-bot: Fix extra from DiffOpVisualizer. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98816 (owner: 10Daniel Kinzler) [14:52:31] (03CR) 10Tobias Gritschacher: [C: 032] Check user rights when restricting entity page actions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98796 (owner: 10Henning Snater) [14:56:02] (03Merged) 10jenkins-bot: Check user rights when restricting entity page actions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98796 (owner: 10Henning Snater) [14:59:00] (03PS2) 10Daniel Kinzler: (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 [15:02:46] (03CR) 10jenkins-bot: [V: 04-1] (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 (owner: 10Daniel Kinzler) [15:05:07] (03PS1) 10Zfilipin: Moved Selenium tests to /tests/browser folder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98823 [15:11:56] Tobi_WMDE: please take a look at 98823 [15:12:26] (03CR) 10Zfilipin: "Please also merge https://gerrit.wikimedia.org/r/#/c/98823/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98823 (owner: 10Zfilipin) [15:21:48] (03PS2) 10Tobias Gritschacher: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 (owner: 10Henning Snater) [15:35:09] (03PS1) 10Henning Snater: Fixed accessing inputAutoExpand data attribute [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98834 [15:37:27] (03PS2) 10Henning Snater: Fixed accessing inputAutoExpand data attribute [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98834 [15:40:57] (03CR) 10Tobias Gritschacher: [C: 032] Fixed accessing inputAutoExpand data attribute [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98834 (owner: 10Henning Snater) [15:41:31] (03Merged) 10jenkins-bot: Fixed accessing inputAutoExpand data attribute [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98834 (owner: 10Henning Snater) [15:42:58] (03PS3) 10Daniel Kinzler: (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 [15:43:03] Tobi_WMDE: --1 [15:46:33] Hacking on my Android was totally what I planned to do today :( [15:48:04] (03PS1) 10Daniel Kinzler: Include snak value in bread crumbs in diff view. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98839 [15:48:26] hoo: i didn't touch anything i planned on for today either >_< [15:49:09] :/ Yeah... [15:49:43] Damn androids... not getting security updates in (literally) over a year finally got me, it seems :( [15:50:03] (03PS16) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [15:55:47] actually more than two years [16:00:32] (03PS3) 10Henning Snater: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 [16:01:20] right im off for a bit again >.< [16:04:03] (03CR) 10Tobias Gritschacher: [C: 032] (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 (owner: 10Daniel Kinzler) [16:05:12] (03CR) 10Jeroen De Dauw: [C: 031] "Usage of global state like this in new code is just painful..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 (owner: 10Daniel Kinzler) [16:07:47] (03PS5) 10Daniel Kinzler: (bug 57588) Scientific notation for quantities. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 [16:08:01] (03Merged) 10jenkins-bot: (bug 57661) Localized display of rank changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98803 (owner: 10Daniel Kinzler) [16:08:13] (03CR) 10Daniel Kinzler: "good catch tobi, thanks!" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/97907 (owner: 10Daniel Kinzler) [16:11:35] (03PS2) 10Tobias Gritschacher: Include snak value in bread crumbs in diff view. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98839 (owner: 10Daniel Kinzler) [16:23:24] (03CR) 10Tobias Gritschacher: [C: 032] Include snak value in bread crumbs in diff view. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98839 (owner: 10Daniel Kinzler) [16:27:30] (03Merged) 10jenkins-bot: Include snak value in bread crumbs in diff view. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98839 (owner: 10Daniel Kinzler) [16:38:47] (03CR) 10Daniel Kinzler: [C: 031] "Seems like my comments were addressed. Looks fine, but needs more poking at." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [16:38:58] (03CR) 10Daniel Kinzler: Introduce ChangeLineFormatter in the client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [16:43:55] (03CR) 10Daniel Kinzler: [C: 04-1] "missed some things to rename" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [16:51:31] (03PS4) 10Henning Snater: Reset claimgroup when cancelling edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98819 [16:55:52] when will the software on wikidata.org be updated ? [16:56:34] when will the software on wikidata.org be updated ? [16:57:17] in the next hours [16:57:32] ok [17:01:43] (03CR) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [17:02:43] (03CR) 10Bene: "@Daniel ModifyEntity != ModifyTerm" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [17:06:26] hi! are items with (say) both an en label and an en-gb label that are that same expected or desirable? [17:13:06] can we expect many of the tools in labs to break (in a few hours) ? [17:19:40] GerardM-: hmmm not that i am aware of. why? [17:20:02] with the new data type, it could be that replication breaks [17:20:26] the new data types need presentation .... those kind of things [17:21:04] oh [17:21:39] quantities will not go live tonight :/ they're pushed back some more because we've worked on the feedback we got through testing [17:21:53] also this should not break tools on labs (but you never know of course) [17:22:18] pity ... [17:22:46] jep - but better to work on that feedback than push out the version we had up for testing and that got bad grades :P [17:23:46] we are thinking of preparing Wikidata for doing Winter Olympics.. [17:24:02] oh [17:24:03] interesting [17:24:19] builiding a scaffold where we enter results [17:24:32] and publish it on all the interested Wikipedias [17:24:42] i love that idea [17:24:55] when do they start again? [17:25:06] Februari [17:25:20] ok by then you will have it ;-) [17:25:38] and a bit more I hope [17:25:49] jep [17:25:52] ranks and sorting [17:26:05] exactly what this asks for [17:26:07] s/sorting/ordering [17:27:33] We can start by building the 2010 Olympics first ... 2014 is more of the same [17:27:45] *nod* [18:18:41] (03PS7) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [18:37:50] addshore: hi, having some time? [18:42:09] maybe also another dev [18:46:26] (03PS4) 10Bene: Rename SpecialSetEntity to SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 [18:52:34] (03PS6) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 [18:56:51] (03CR) 10Bene: [C: 031] Refactor Api LangAttributes to Terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98794 (owner: 10Addshore) [19:07:09] really no one here? [19:07:21] I think I always come the worst time here [19:08:55] benestar: hey :) [19:09:01] unfortunately yes [19:09:04] wasup? [19:09:04] hi Lydia_WMDE :) [19:09:14] well, I tried to run phpunit tests locally [19:09:22] but it doesn't work :( [19:09:31] mpfh [19:09:35] for this stuff you want tobi [19:09:45] not sure if I used the right command [19:09:54] there is a bootstrap.php file in the tests folder [19:10:22] but it dies immediately, saying 'This test bootstrap does not work yet due to assumed global scope in Wikibase' [19:10:40] hmmm i have no idea about this stuff unfortunately [19:10:52] maybe DanielK_WMDE_ is still around? [19:10:56] and knows [19:11:01] Lydia_WMDE: and all the other guys are at home now? [19:11:11] jep [19:11:21] it is past 8pm :D [19:11:24] they should be [19:11:40] well, but this is the only time I can work for the project :/ [19:11:55] i understand [19:12:15] in this case asynchronous communication like email is best [19:12:24] that's slower but... [19:12:34] Lydia_WMDE: where should I write to? [19:12:39] wikidata-tech? [19:12:49] yes that's the best i think [19:12:58] and is seen by most people [19:13:13] the people who can actually help :) [19:16:14] Lydia_WMDE: I hope I won't spam the list though... [19:16:21] (03PS1) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/98870 [19:16:37] (03CR) 10Aude: [C: 032] Improve exception handling in SpecialModifyEntity [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/98870 (owner: 10Aude) [19:16:38] benestar: that's what the list is for really [19:17:46] benestar: run tests from mediawiki's phpunit test folder [19:18:03] aude: I assume this will run all the tests of mediawiki, too? [19:18:04] php phpunit.php --group Wikibase [19:18:10] use the group flag [19:18:14] ah, I understand :) [19:18:15] or specify directory [19:18:20] aude: is this anywhere documented? [19:18:22] * aude specifies directory [19:18:36] probably on mediawiki.org [19:18:51] https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Running_the_unit_tests [19:19:42] Fatal error: Class 'MediaWikiPHPUnitCommand' not found in C:\xampp\htdocs\mediaw [19:19:44] iki\w\tests\phpunit\phpunit.php on line 119 [19:20:18] hmmmm [19:20:38] using versino 3.7 [19:20:45] *version [19:20:46] since you use windows, tobi might be more helpful [19:20:57] i don't know if there are specific things to do there [19:21:52] (03Merged) 10jenkins-bot: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/98870 (owner: 10Aude) [19:23:12] maybe hoo knows something about that [19:23:44] uh, what's up? [19:27:16] hoo: phpunit tests do not run on my system [19:27:43] it says Fatal error: Class 'MediaWikiPHPUnitCommand' not found in C:\xampp\htdocs\mediawiki\w\tests\phpunit\phpunit.php on line 119 [19:29:11] benestar: What command do you use to run them? [19:29:19] phpunit phpunit.php [19:29:26] that wont work [19:29:40] so why? [19:29:43] you have to use just 'php phpunit' [19:29:53] because phpunit is a modified test runner, not a test [19:30:39] ah, I see, has to be php phpunit.php [19:30:48] hoo: but now I don't see anything :( [19:31:51] mh? [19:32:26] well, it does not print points or anything like that [19:33:54] benestar: Does it exit/die? [19:34:08] no, just failing after some time [19:34:22] Fatal error: Call to undefined method LanguageZh::getParentLanguage() in C:\xamp [19:34:23] p\htdocs\mediawiki\w\extensions\Wikibase\lib\includes\LanguageFallbackChainFacto [19:34:25] ry.php on line 159 [19:35:20] benestar: Maybe your core version is to old? [19:35:35] yes, seems to be [19:35:48] however, it still does not show the dots [19:36:02] hoo: there is just no output besides the error message [19:36:07] is this normal behaviour? [19:36:25] benestar: There's no "normal behavior" for fatal errors [19:36:34] those aren't supposed to be occuring during tests :P [19:37:02] no, I mean the missing points [19:37:05] or dots [19:37:39] benestar: Fix the fatals first... [19:38:01] if the tests are running normally, but you don't see any output somethings awry [19:43:45] https://www.wikidata.org/w/index.php?title=Q7259&diff=0&oldid=49556407 :) [19:43:48] Lydia_WMDE: ^ [19:48:51] aude: :D [19:48:54] wohoooooo [19:49:39] lbenedix: pong [19:51:31] (03PS1) 10Daniel Kinzler: Sort statements in EntityView by rank. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98888 [19:51:35] Lydia_WMDE: ---^ [19:52:01] it's a denny :) [19:52:12] DanielK_WMDE_: \o/ [19:52:17] you're all making me happy today [19:52:20] i like this :D [19:52:47] dennyvrandecic: i can haz email reply? :) [19:53:54] would I thus make you happy too? :) [19:54:06] very much so [19:54:09] ;-) [20:00:53] (03CR) 10jenkins-bot: [V: 04-1] Sort statements in EntityView by rank. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98888 (owner: 10Daniel Kinzler) [20:01:01] gah [20:01:40] oh duh, i didn't mean to commit that! [20:03:37] (03PS2) 10Daniel Kinzler: Sort statements in EntityView by rank. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98888 [20:03:42] there [20:28:54] hoo|away: running now :) [20:32:56] hoo|away: sorry, didn't realyl get around to your mail today :\ [20:33:06] going home now. maybe i'll reply from home. or tomorrow [20:36:40] dennyvrandecic: ping [20:41:25] (03PS33) 10Bene: Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [20:43:00] benestar: yeah, I think I will not manage to do that [20:43:04] so go on [20:43:47] lazowik: ought so ;) [20:44:00] great :) [20:44:05] I am just trying to run the phpunit tests locally [20:44:17] however, it's really slow :( [20:44:25] and it fails :( [20:49:26] lazowik: jenkins verifies it while it fails on my local pc :/ [20:49:46] benestar: well, I have some "pernament" fails locally too [20:49:50] I just ignore them [20:50:05] something related to claim guids if I remember correctly [20:53:38] lazowik: however, there is a huge amount of failing tests... :/ [20:53:46] hmm [20:53:54] with --group Wikibase ? [20:53:59] yes [20:54:10] on windows? [20:54:21] indeed [20:54:32] ah, I see [20:54:48] I had some outdated versions of extensions [20:54:58] now there are lees failing tests :) [20:55:03] :) [20:55:19] but only few [20:55:33] at about 16% it starts to fail almost everything [20:56:58] not ok 1646 - Failure: Wikibase\Test\Dumpers\JsonDumpGeneratorTest::testSharding [20:57:00] with data set "two shards" (array(P10, Q10, P11, Q11, P12, Q12, P13, Q13, P14, [20:57:01] Q14, P15, Q15, P16, Q16, P17, Q17, P18, Q18, P19, Q19, P50, Q50, P60, Q60, P70, [20:57:03] Q70, P80, Q80, P90, Q90, P100, Q100), 2) [20:58:09] lazowik: -- [20:58:16] *--^ [20:58:30] em... [20:58:44] maybe also hoo can help? [20:59:26] maybe I can... can you give me a tl;dr? :P [21:00:09] (w)hoo to the rescue(?/!) [21:01:40] that's why I use an isolated VM for unit tests [21:05:26] lazowik: just one question [21:05:31] benestar: sure [21:05:37] should the exception be caught in the changeop or in the api module? [21:06:03] I mean the exception caused by duplicate badges [21:06:21] benestar: it should not happen in the first place ;) [21:06:35] so if it does, I think changeop will be suitable [21:06:50] and then just ignore it? [21:06:51] it will mean a code breakage, not wrong use of api [21:06:56] benestar: nope, fail [21:07:03] but you have to remove duplicates [21:07:10] before constructing simplesitelink [21:07:36] lazowik: so no try + catch [21:07:44] nah [21:07:49] but just filter the array in the changeop before constructing the simplesitelink? [21:07:59] yep [21:08:14] (filter per ItemId objects) [21:08:14] any php built in method? [21:08:23] array_values probably [21:08:33] dunno if it can cast automagically to string [21:09:06] maybe just array_unique? [21:09:11] ah, right [21:09:16] but it would be probably better to do that by hand [21:09:22] why? [21:09:23] using ItemId::equals [21:09:41] ah, ok [21:09:43] benestar: you'd be using casting of ItemId to string [21:09:57] JeroenDeDauw: said it's no good [21:09:58] yes, I've just read that [21:11:15] lazowik: so I would need two nested for loops, right? [21:11:20] seems to be quite slow [21:11:21] yep [21:11:38] nah, I don't expect millions of badges :) [22:10:33] (03PS34) 10Bene: Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [22:22:09] (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [22:31:22] (03PS35) 10Bene: Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [22:32:29] (03CR) 10Bene: [C: 04-1] "Api test is still failing. (#7) No idea what the problem could be. Maybe someone can help me?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [22:34:33] lbenedix: pong [22:36:57] (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [22:44:16] Lydia_WMDE: Please see https://www.mediawiki.org/wiki/Talk:Typography_Update#Looks_really.2C_really.2C_really_bad_in_Wikidata [22:44:24] also, hi [22:44:28] (03CR) 10Michał Łazowik: [C: 04-1] Extend API to support editing badges (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [22:44:47]