[00:01:26] interesting :D [00:06:30] (03PS5) 10Addshore: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [00:12:49] (03CR) 10Addshore: "Spotted your message on IRC, the issue of the failing tests was most likely caused by the following method being private rather than prote" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [00:25:35] (03CR) 10Addshore: [C: 04-1] Special page for wbmergeitems api module (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [00:26:57] (03CR) 10Addshore: [C: 032] Cleanup in Change classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98171 (owner: 10Aude) [00:30:18] (03Merged) 10jenkins-bot: Cleanup in Change classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98171 (owner: 10Aude) [00:45:55] (03CR) 10Addshore: [C: 04-1] "Needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 (owner: 10Daniel Werner) [08:00:35] Henning_WMDE: you at the office? [08:01:02] Sure [09:46:09] Hoi, I proposed on the nl.wp to add the one line that enables search in Wikidata in the Mediawiki:common.js [09:48:24] Tobi_WMDE, Lydia_WMDE: after my third attempt at implementing redirects, I want to send this back to the drawing board, see my mail to wikidata-tech. Please replace #57744 (implement redirects) on the board with #38962 (design redirects), and put it on "doing". [09:48:50] GerardM-: the standard full text search on wikidata.org is currently not very useful. [09:49:04] it's better with elasticsearch now, but still not great. [09:49:59] Daniel, have you tried adding this line "importScriptURI("//en.wikipedia.org/w/index.php?title=MediaWiki:Wdsearch.js&action=raw&ctype=text/javascript");" to your common.js ? It is totally worth it [09:50:16] and it complements the elastic search [09:50:34] it probably gives better disambiguation [09:51:01] ps I do not use this on Wikidata itself [09:53:01] GerardM-: since I never use Special:Search, I doubt i'd even notice if I had this on :) [09:53:24] Daniel do you never search in a Wikipedia ? [09:56:50] JeroenDeDauw: I am deploying the Jenkinsjobs updated you submitted at https://gerrit.wikimedia.org/r/#/c/97065/ (aka remove extension dependencies) [10:00:07] GerardM-: "search" as in "search for text contained on the page"? nope, i don't. [10:00:39] I search for page titles, yes. that uses a different mechanism though [10:01:01] ...and means i never see the search page (since i generally enter something that exists as a page title) [10:01:05] (03PS1) 10Tobias Gritschacher: Don't change single quotes in browser test data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98491 [10:02:10] GerardM-: if i actually don't know what title to search for, i use google - which will give me the appropriate wikipedia page, if there is one. I personally feel Special:Search isn't very useful at present. It would need to become much smarter/specialized. [10:02:41] what google does not do is give you one click access to the Commons category [10:02:42] (03PS2) 10Tobias Gritschacher: Don't change single quotes in browser test data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98491 [10:03:05] what google does not give you is access to a Reasonator when there is no article in "your" language [10:03:22] that is what you get when you add this [10:03:47] remember, Wikidata has more items than Wikipedia has articles [10:03:49] nice. that's a good step to becoming "smarter and more specialized". [10:03:53] (true for any language_ [10:03:56] now this stuff also needs to become more discoverable. [10:04:12] I totally agree [10:04:29] this is however a hack, a great hack and a step in the right direction [10:04:47] especially, it should become discoverable in the form of suggestions when using the search box on the top right. [10:04:52] it does not have the "concept cloud" yet [10:05:03] anything that requires people to go to Special:Search is already lost to 99% of users, imho [10:05:06] (03CR) 10Tobias Gritschacher: [C: 032] Don't change single quotes in browser test data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98491 (owner: 10Tobias Gritschacher) [10:05:31] in a language like Xhosa there is nothing to find [10:05:46] getting info in quickly is by adding Wikidata labels [10:07:04] GerardM-: sure, but showing that on the "this page no text" page would be more useful than showing it on special:Search [10:07:21] it is on the 404 page [10:07:27] try it [10:07:27] good [10:07:38] (is that actually a 404 now? it didn't used to be) [10:07:39] it is on any search result page [10:07:53] at the bottom [10:07:58] but the 404 page is not a search result page... [10:08:17] it is on the "do you want to create a page" page [10:08:24] for me that is a 404 [10:08:52] (03Merged) 10jenkins-bot: Don't change single quotes in browser test data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98491 (owner: 10Tobias Gritschacher) [10:20:01] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1301 (master - 129f224 : Tobias Gritschacher): The build was broken. [10:20:01] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/9c46e3efdf24...129f22419945 [10:20:01] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14798428 [10:25:47] DanielK_WMDE__: ok [10:25:48] thx [10:29:53] DanielK_WMDE__: done [10:35:59] (03PS10) 10Henning Snater: Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [10:37:53] (03CR) 10Siebrand: "Please only change en and possibly qqq. See https://www.mediawiki.org/wiki/I18n#Changing_existing_messages section 3 for details." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [10:39:12] (03CR) 10jenkins-bot: [V: 04-1] Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [10:39:52] (03CR) 10Siebrand: [C: 031] "Trivial L10n/i18n changes." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [10:41:03] (03PS11) 10Henning Snater: Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [10:49:06] (03CR) 10Henning Snater: [C: 031] "Improved destroy mechanism and removed the corresponding FIXMEs. Anyone reviewing the actual code: Feel free to merge. Else, if the actual" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [10:51:57] hashar: thnx [10:55:19] (03CR) 10Henning Snater: [C: 032] (bug 44876) add a table of content to item pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90755 (owner: 10Bene) [10:56:24] Can someone pleae take a picture of the scrum board and mail it to me? I have no clue what the statu of the thing is now [10:56:39] Henning_WMDE: Lydia_WMDE Tobi_WMDE addshore DanielK_WMDE__ ^ [10:57:04] JeroenDeDauw: ok [10:57:06] will do [10:59:17] (03Merged) 10jenkins-bot: (bug 44876) add a table of content to item pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90755 (owner: 10Bene) [11:00:34] (03PS3) 10Daniel Kinzler: (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 [11:05:39] (03CR) 10Daniel Kinzler: (bug 56684) Use HTML formatters in diffs. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 (owner: 10Daniel Kinzler) [11:06:07] (03PS2) 10Daniel Kinzler: (bug 56684) Use HTML formatters in diffs. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 [11:06:28] (03PS3) 10Daniel Kinzler: (bug 51113) Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 [11:06:31] (03PS4) 10Daniel Kinzler: (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 [11:08:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1302 (master - 85bf907 : jenkins-bot): The build is still failing. [11:08:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/129f22419945...85bf9074f7d0 [11:08:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14800223 [11:11:51] (03PS4) 10Daniel Kinzler: (bug 51113) Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 [11:12:03] (03CR) 10Daniel Kinzler: (bug 51113) Introducing HtmlUrlFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 (owner: 10Daniel Kinzler) [11:14:05] Lydia_WMDE: thnx! [11:14:20] np [11:14:20] (03CR) 10Siebrand: [C: 031] "Trivial L10n/i18n changes." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [11:14:34] JeroenDeDauw: thanks for reviewing. fixed what you commented on. [11:15:12] Lydia_WMDE: may not make it to the daily today (2 sick kids here). most important thing for me: merge my stuff. [11:15:23] i have 9 changes waiting for review, none of them very big or complex. [11:15:34] DanielK_WMDE__: ok - hope the kids are going to be fine again soon [11:16:26] they are already discovering, well enough to be bored... [11:16:33] err, recovering. [11:16:37] anyway [11:16:55] Lydia_WMDE: if i can find a bit of time, i'll look into the parser cache stuff today [11:17:01] will probably need a small core patch [11:17:08] merge my stuff! [11:17:23] DanielK_WMDE__: ;-) if they're bored things will be fine indeed :P [11:17:26] aude: merge my stuff! [11:17:27] ok [11:17:28] :D [11:17:31] :D [11:17:37] merge all the stuff! [11:17:50] review all the stuffs [11:17:58] then merge all the stuffs [11:18:10] (03CR) 10Aude: [C: 04-1] "nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 (owner: 10Daniel Kinzler) [11:19:34] is the next release scheduled for tomorrow ? [11:20:03] GerardM-: yes [11:20:17] (03PS3) 10Daniel Kinzler: (bug 56684) Use HTML formatters in diffs. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 [11:20:24] aude: --^ [11:21:01] Lydia_WMDE, GerardM-: but only deployed next week, right? [11:21:23] deploy tomorrow! [11:21:25] DanielK_WMDE__: no according to clanedar tomorrow is deployment on wikidata and non-wikipedias [11:21:39] calendar even [11:22:15] didn't I ask about that on thursday, and got "no, in 10 days" as a reply? [11:22:23] the deployment schedule really keeps confusing me [11:22:42] +1 [11:22:45] we are deploying next week too [11:23:26] so, we don't have a new branch to deploy today, right? just a few backports? [11:23:38] or am i gettign this wrong again? [11:23:42] grr :/ [11:23:48] * aude forces the germans to adopt american holidays, and then you will remember :) [11:23:48] Lydia_WMDE: which calendar, anyway? [11:23:59] it's as if last week did not exist [11:24:04] aude: i find it confusing without holidays too [11:24:09] heh [11:24:26] DanielK_WMDE__: it is called wikidata deployment schedule [11:24:45] we should make this one public... [11:24:48] * Lydia_WMDE puts on todo [11:24:52] DanielK_WMDE__: we are deploying what is on test wikidata (w/o quanitities) [11:24:54] (03CR) 10Addshore: [C: 032] (bug 56684) Use HTML formatters in diffs. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 (owner: 10Daniel Kinzler) [11:25:25] (03PS5) 10Addshore: (bug 51113) Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 (owner: 10Daniel Kinzler) [11:25:37] (03PS5) 10Addshore: (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 (owner: 10Daniel Kinzler) [11:26:00] Lydia_WMDE: i can't find it anyywhere. also, why do we need a separate calendar? why not use the wikidata project calendar? [11:26:13] seems like nobody is using that - it has been around forever :/ [11:26:24] what wikidata project calendar? [11:26:35] * aude only learned about it last week [11:26:52] DanielK_WMDE__: Hi... could you have a look at the mail I sent on Thursday or so? I mostly need an answer for the question whether we want to keep the support for using header1/data1 for giving data in a simple way? [11:27:14] aude: Lydia_WMDE isnt the deployment calander wrong? O_o [11:27:24] it says branch wmf5 on wednesday [11:27:32] but that was our last branch ?? [11:28:21] https://meta.wikimedia.org/wiki/Wikidata/Deployment [11:28:27] why it's on meta, no clue [11:28:27] hoo: i would suggest a compatibility wrapper for supporting that, not having it in the core. [11:28:54] aude: what about the google calander one? :P [11:28:55] hoo: however, for a baseline release, it may be best to just keep the code as it is, just wrap it in an extension. then start refactoring piece by piece [11:29:00] DanielK_WMDE__: They could be easily piped in using some wrapper, yes... but supporting them directly will almost certainly mess with the order [11:29:11] I can also do that... if you want [11:29:13] * aude no use google calendar [11:29:20] aude: it'S called "Wikidata" - I *still* don't understand how to get the "proper" URL of a google calendar. [11:29:26] I can push things to gerrit this afternoon, if you want the state from enwiki [11:29:33] (03CR) 10Siebrand: [C: 04-2] "Per Lydia." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [11:29:34] (mostly) [11:30:03] hoo: it would definitly be good to have the mostly unmodified baseline in gerrit, yes [11:30:13] Ok, will do that then :) [11:30:25] (03Merged) 10jenkins-bot: (bug 56684) Use HTML formatters in diffs. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 (owner: 10Daniel Kinzler) [11:30:30] Lydia_WMDE, aude: i'm talking about http://www.google.com/calendar/embed?src=wikimedia.de_nmi9vfter56kmnfdpare2g9hrg%40group.calendar.google.com&ctz=Europe/Berlin [11:30:34] Only need to adjust the license information a bit before that goes public [11:31:14] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [11:31:49] DanielK_WMDE__: don't see anything [11:32:30] o_O [11:32:34] aude: I think thats DanielK_WMDE__'s point :P We dont use it [11:32:44] aude: well, it`s empty!nobody is using it! [11:32:53] hmmm [11:32:58] i'm just saying - it exists, everybody has access, it's the obvious place for this stuff :) [11:33:08] if wikidata-tech has a calendar, i can add it [11:33:14] aude: just gave you write access to it. [11:34:05] i don't think there is a wikidata-tech calendar [11:34:06] DanielK_WMDE__: not in our other calendar because we want to make this one publlic [11:34:21] i added something [11:34:23] can you see it? [11:34:49] aude: yes [11:34:52] :D [11:34:56] Lydia_WMDE: i can't even find the deployment calendar [11:35:02] * aude neither [11:35:21] DanielK_WMDE__: aude: i will share it again with you [11:35:26] ok [11:36:23] * hoo|away would like access to the deployment schedule stuff also... just notin' [11:36:36] DanielK_WMDE__: aude: hoo|away: http://www.google.com/calendar/embed?src=wikimedia.de_547r0to8vfuod4hap098ldil7o%40group.calendar.google.com&ctz=Europe/Berlin [11:36:44] this is where deployments should go [11:36:50] and this is the one i will link to on-wiki [11:37:16] \o/ [11:37:19] :) [11:37:56] but Lydia_WMDE that calander needs updating as it is wrong :P [11:38:09] addshore: what is wrong? [11:38:19] it says we branch wmf5 this wednesday! [11:38:29] yes [11:38:38] don't we? [11:38:43] but wmf5 is where I cherrypicked my last 2 backports 2 .... [11:38:43] Lydia_WMDE: so..... how do i get that into my normal calendar view? Google doesn't seem to know it's own URLs, it'S refusing the "add via URL" thing. and the calendar isn't associated with any email address i can see. [11:39:00] so I would have guessed we have already branched unless I have backported to the wrong branch [11:39:05] DanielK_WMDE__: click the little button at the bottom of the page [11:39:08] right side [11:39:27] * aude screams [11:39:37] addshore: hmmm something for aude and Tobi_WMDE to sort out i guess then [11:39:38] added it to my personal calendar [11:40:19] addshore: wiki page says branch for wmf6 [11:40:34] wiki page is right :) [11:40:39] * Lydia_WMDE pokes Tobi_WMDE about not updating the other calendar... [11:40:48] we really should not be keeping this information twice [11:41:18] * aude votes for wiki page [11:41:19] hehe, one sec [11:41:22] Lydia_WMDE: wenn ich da drauf klicke, passiert garnichts :)# [11:41:27] yay, technology. [11:41:35] never mind, i'd go back to hacking. [11:41:52] Lydia_WMDE: you mean http://localhost:8000/craftmanship/static/img/only-one.jpeg ? [11:41:53] ugh [11:41:55] oh fuck [11:42:00] wikipages are *terrible* for calendars [11:42:04] ack [11:42:15] jeroendedauw.github.io/slides/craftmanship/static/img/only-one.jpeg [11:42:15] DanielK_WMDE__: let's sort this out when you're here? :) [11:42:19] and the only way for me to see "oh, wait, we are deploying tomorrow" is on my calendar overview [11:42:21] http://jeroendedauw.github.io/slides/craftmanship/static/img/only-one.jpeg [11:42:29] Lydia_WMDE: right [11:42:37] * aude moves wiki page to my user space then [11:42:41] (03CR) 10Zfilipin: [C: 031] Include statement browsertests again on beta.wmflabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98172 (owner: 10Tobias Gritschacher) [11:43:08] JeroenDeDauw: jep :P [11:43:09] aude: if you have 6 calendar pages on 3 wikis, how do you get an overview? i wish mediawiki has some way to manage calendar entries as structured data, with an ical interface :) [11:43:26] where do you get 6 calendar pages? [11:43:34] * aude cares about one [11:43:38] (03CR) 10Addshore: [C: 032] (bug 51113) Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 (owner: 10Daniel Kinzler) [11:43:54] back to hacking :P [11:43:59] we'll sort this out in person tomorrow [11:47:15] (03Merged) 10jenkins-bot: (bug 51113) Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 (owner: 10Daniel Kinzler) [11:50:49] (03CR) 10Siebrand: Special:ItemDisambiguation to show link to Special:Search if no results are found (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [11:53:39] (03CR) 10Zfilipin: [C: 031] Module for interacting with Wikibase-API in browser tests (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 (owner: 10Tobias Gritschacher) [11:54:01] DanielK_WMDE__: Lydia_WMDE is this what we decided number didffs should be like? :) http://grab.by/sutm [11:54:03] (03CR) 10Siebrand: [C: 04-1] Rename SpecialSetEntity to SpecialModifyLangAttribute [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [11:56:53] addshore: i think so [11:57:02] but let DanielK_WMDE__ also have a look again [12:02:39] addshore: yes. it's ugly but semantically correct (using

). looking for feedback on html structure and css [12:02:44] Henning_WMDE: --^ [12:04:03] Henning_WMDE: http://grab.by/sutm showing https://gerrit.wikimedia.org/r/#/c/98124/ [12:05:06] Hm,

that's nice. :) [12:07:00] (03CR) 10Addshore: [C: 032] (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 (owner: 10Daniel Kinzler) [12:08:13] (03CR) 10Daniel Kinzler: "Please re-consider the name "LangAttribute". I would prefer "Term" as a generalization for label/description/alias." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [12:10:51] (03Merged) 10jenkins-bot: (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 (owner: 10Daniel Kinzler) [12:11:33] andre__: can you add Tobi_WMDE to mentors of google code-in? [12:12:15] andre__: he registered with wikimedia.de account [12:12:43] zeljkof, I need the username [12:12:50] I don't care about email addresses :) [12:12:56] Tobi_WMDE: ^ [12:13:08] andre__: tobi_wmde [12:15:59] Morn Tobi_WMDE. Have you followed the steps on https://www.mediawiki.org/wiki/Google_Code-in#Mentors.27_corner ? [12:16:07] Tobi_WMDE, because I don't see any email from you in the system [12:19:06] andre__: on my dashboard, I clicked "submit" under "role for organization" but did not use the "send message" yet [12:19:20] I did it now, so probably you got an email now? [12:19:20] (03CR) 10Siebrand: "L10n issues were merged." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 (owner: 10Daniel Kinzler) [12:23:20] (03PS1) 10Addshore: use lowercase b in Bound i18n [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98500 [12:24:36] aude: ^^ easy choc :D [12:24:56] Tobi_WMDE, received it now, yes [12:25:36] Tobi_WMDE, you're a mentor for the org Wikimedia for Google Code-In in the Google Melange system now. Welcome & thanks! [12:25:48] The link I pasted above explains how to create good task descriptions etc. [12:26:07] Tobi_WMDE, If you need help with anything, please ping either qgil or me on IRC or drop us an email. [12:26:43] andre__: thx! [12:26:49] yay [12:27:00] andre__, Tobi_WMDE: wohoooo, another mentor :) [12:27:23] How many do we have ATM? [12:28:05] * addshore waves goodbye, should be back just before the daily [12:28:26] addshore: hopefully we do not forget you [12:31:46] GCI mentors? Wikimedia has 26 [12:38:48] Tobi_WMDE: y u no merge? https://github.com/DataValues/Serialization/pull/1 [12:39:16] (03CR) 10Siebrand: [C: 032] "ty" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98500 (owner: 10Addshore) [12:42:40] (03Merged) 10jenkins-bot: use lowercase b in Bound i18n [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98500 (owner: 10Addshore) [12:48:53] (03CR) 10Jeroen De Dauw: [C: 032] Move Summary class to lib, allow use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98173 (owner: 10Aude) [12:57:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1307 (master - ea26b9a : Jeroen De Dauw): The build was broken. [12:57:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/9695df20b637...ea26b9a793b3 [12:57:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14803573 [13:02:14] chocolate for siebrand :) [13:11:29] I guess I have to make travis-ci come to the office and steal all the chocolate when someone breaks the build? [13:19:47] (03PS1) 10Daniel Kinzler: (bug 57746) Allow entity pages to use parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 [13:23:35] Lydia_WMDE, aude: nice and easy --^ [13:23:53] please set #57746 to "feedback". [13:24:02] will set to feedback [13:24:07] tnx [13:24:08] and let someone else review ;-) [13:24:23] Lydia_WMDE: but look at how simple the fix was :) [13:24:37] it was just hard to understand what core was actually doing [13:24:48] ;-) [13:24:50] yeah [13:24:55] (submitted a documentation patch for that) [13:25:11] but you know how small changes can bring down whole systems, right? :P [13:25:21] but EntityContent::getParserOutput is not setting the option [13:25:29] it's being done via entityview (which is fine) [13:26:13] (03CR) 10Aude: [C: 04-1] (bug 57746) Allow entity pages to use parser cache (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 (owner: 10Daniel Kinzler) [13:26:24] * aude nitpick [13:27:06] (03CR) 10Aude: (bug 57746) Allow entity pages to use parser cache (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 (owner: 10Daniel Kinzler) [13:54:43] Tobi_WMDE: dont forget me in 5 mins ;p [13:55:44] :) [13:59:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [14:00:00] Lydia_WMDE: successfull thread derail is successfull [14:00:15] * Lydia_WMDE ^5s JeroenDeDauw [14:00:22] ohnoez [14:00:25] :P [14:00:25] errr [14:00:29] its le daily? [14:00:32] jep [14:00:36] getting ready [14:00:38] I can haz joiin>\ [14:00:43] jep [14:00:47] in the calendar [14:01:03] rage [14:09:40] had lots of background noise in that :O like laptop sounds :/ Also what do I hear about a fancy new tool thing? :P [14:09:55] bugzilla [14:10:00] new for christopher [14:10:06] very fancy :) [14:10:16] =] [14:12:36] Lydia_WMDE: think the hangout thing did not work properly because you are no in the circles thing of my wmde account or smth [14:12:59] JeroenDeDauw: hmmm that shouldn't be an issue -.- [14:13:11] Lydia_WMDE: can you join the call again? [14:13:14] ok [14:13:46] I still do not see a vid image [14:13:57] me neither [14:14:00] if you [14:14:03] just black [14:14:07] *of [14:14:18] Yeah, thats because I has a tape on my cam [14:14:23] Oo [14:14:34] maybe google is clever enough to then also not show me to you :P [14:14:44] >_> [14:15:28] Lydia_WMDE: or they could give you a live NSA sattelite feed instead? [14:15:38] haha [14:15:44] worksforme [14:16:39] Lydia_WMDE: can you assign this task? :) http://www.google-melange.com/gci/task/view/google/gci2013/5879824321085440 [14:16:50] k [14:21:54] (03PS2) 10Jeroen De Dauw: (bug 57746) Allow entity pages to use parser cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 (owner: 10Daniel Kinzler) [14:23:08] (03CR) 10Jeroen De Dauw: [C: 04-1] "-1 as per aude" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98511 (owner: 10Daniel Kinzler) [14:23:34] ty Lydia_WMDE [14:23:42] addshore: np [14:42:02] https://gerrit.wikimedia.org/r/#/c/95996/ no longer has a -1 [14:42:05] Lydia_WMDE: ^ [14:42:20] wohooooooooo [14:42:26] still needs review [14:54:30] (03PS1) 10Henning Snater: Table of contents style adjustments [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98520 [15:32:34] (03CR) 10Aude: [C: 04-1] "appears that the "wikibase-linkitem-success-create" message is still needed." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [15:33:19] doh [15:33:41] * aude might be confused [15:33:49] don't think so though [15:34:06] Must be Henning's fault then :P [15:34:07] * hoo hides [15:34:10] :) [15:34:59] aude: Where do you see it used? [15:35:27] the new _onSuccess looks good to me [15:35:27] mw.message( 'wikibase-linkitem-success-link', itemUri ).parse() [15:35:38] not quite sure where in the code but in dialog when adding a link [15:36:08] aude: mh... can you give steps to reproduce? [15:36:25] click add links [15:37:37] (03CR) 10Bene: "Should this be also changed in the API module then? I think it should be named the same way." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [15:37:52] * hoo checks out the latest version from gerrit [15:39:26] (03Abandoned) 10Bene: Add an option in the user preferences to choose additional languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [15:39:33] could be caching [15:39:46] Possible [15:40:34] aude: try it with debugging... it seems to work for me (latest version from Henning) [15:41:31] (03CR) 10Addshore: "If we change it here we should also change it there :) Feel free to make a new path for it!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [15:42:04] hoo: huh, it works now [15:42:14] i did debug=true before [15:42:34] that's weird [15:42:45] now i can't reproduce [15:42:48] I never saw that in development/ testing [15:43:05] (03CR) 10Aude: "it must be caching. now the messages work" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [15:43:16] ok, we will have it on test2 first [15:43:33] caching issues should be sorted out well ahead of time if they occur [15:44:03] they really shouldn't occur over here, if RL does it's job right [15:44:11] (03CR) 10Aude: [C: 032] "it works fine now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [15:44:12] * its [15:44:14] alright :) [15:44:20] Yay :) [15:44:23] overall, looks much improved [15:44:24] One more thing done :) [15:45:44] aude: Yes :) In theory it's (almost) able to do pages with unlimited interwiki links now (only one function needs to altered for that, but that's a minor). :) [15:46:34] (03PS1) 10Henning Snater: Added title attribute to rank icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98531 [15:46:47] (03CR) 10Bene: "Answered some comments." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [15:48:47] aude: Have you run the Selenium's on it? I can't :/ [15:48:58] no [15:49:19] I usually can fix them blind, but I need the error reports [15:49:29] blind -> w/o testing [15:51:51] (03Merged) 10jenkins-bot: Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [15:54:08] * hoo wonders why we use British "licence" all over the place [15:54:52] @license vs. @licence -> 75:681 [15:55:08] in wikibase? [15:55:14] aude: Yep [15:55:20] * aude blame addshore :) [15:55:25] or jeroen [15:55:26] ??? :O [15:55:40] * aude just copies the header text [15:56:16] I just noticed I had those in my new extension and I was very confused, cause I'd never write it that way... ever [15:56:38] I also copied from Wikibase :P [15:56:59] hah [15:58:09] aude: same :D [15:58:31] then it must be jeroen spelling [15:58:53] Jeroen was using a canadian dictionary the other day so lets just blame him ;P [15:59:00] :) [16:02:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1308 (master - a835b0a : jenkins-bot): The build was fixed. [16:02:19] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ea26b9a793b3...a835b0ab5ad3 [16:02:19] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14812043 [16:09:36] yun rebases :D [16:10:52] peoples! [16:11:01] more people should be thanked [16:11:06] https://www.wikidata.org/w/index.php?title=Special%3ALog&type=thanks&user=&page=&year=&month=-1&tagfilter=&hide_patrol_log=1&hide_thanks_log=1 is not long enough :) [16:12:21] (03CR) 10Addshore: Special page for wbmergeitems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [16:12:22] Lydia_WMDE: Happy? :p [16:12:48] JL|cloud: jep :D [16:17:11] (03CR) 10Addshore: Allow callbacks in factories for formatters/parsers. (032 comments) [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98087 (owner: 10Daniel Kinzler) [16:45:48] aude: did you verify https://bugzilla.wikimedia.org/show_bug.cgi?id=54497 is fixed? [16:47:50] not verified [16:48:16] It should be, but I don't have the commons set up around [16:48:46] Closed the bug for now... I hope that one doesn't reoccur [16:48:54] hmmm [16:49:01] we can live test it on commons before we enable [16:49:07] ok [16:49:08] :) [16:49:19] Just a mw.loader.load call :) [16:49:23] yeah [16:50:07] Just realized I messed a little with the label fallback bugs... mh [16:52:01] (03CR) 10Siebrand: Special page for wbmergeitems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [16:53:01] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=57815 Can you prioritize? I don't think it's this important, is it? [16:53:08] * repriotize [16:53:16] looking [16:54:03] hoo: i don't know the consequences of this so can't really say. if you think they are not severe please reclassify [16:55:21]