[01:37:51] (03Restored) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [01:38:03] (03PS3) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 [05:56:58] How do we deal with interwiki links that go to subsections of larger topics? Ie. I want to link [[List of classical music composers by era]] to [[de:Komponist#Komponisten (Klassik) - Grafische �bersicht]] (The main German article is already linked to the English's [[Composer]] article). [05:57:06] Should I create a redirect on the German Wikipedia, or something? [05:57:46] (I'm running out the door, but will be back in a few hours. Hopefully, despite the holiday, someone might have answered in that time ;) o/ [09:53:09] hii [09:55:35] hello [09:56:14] dennyvrandecic: ping [10:49:41] (03PS2) 10Daniel Kinzler: (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 [10:58:33] (03Abandoned) 10Addshore: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98062 (owner: 10Jcf2000) [11:05:36] (03PS4) 10Addshore: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [11:05:59] (03CR) 10Addshore: "PS4 fixes style issues where spaces were used instead of tabs" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [11:06:07] (03CR) 10Addshore: [C: 032] Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [11:10:57] (03Merged) 10jenkins-bot: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [11:17:21] (03CR) 10Addshore: "If you have trouble installing then come and join us in #wikidata on freenode" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [11:21:31] (03CR) 10Addshore: [C: 04-1] "Also incase you haven't managed to install your change currently looks like this http://grab.by/srjo" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [11:38:55] (03CR) 10Daniel Kinzler: [C: 04-1] "As per discussion on https://gerrit.wikimedia.org/r/#/c/97491/" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97492 (owner: 10Addshore) [11:59:23] is there a java script hero around that can help me update a script [11:59:29] ?? [12:00:06] addshore: https://gerrit.wikimedia.org/r/#/c/98161/ [12:00:53] will jenkins pass it :P [12:01:10] oh wait, of course it will as it doesnt test xml to any real degree ... [12:01:25] will check it out and play with it shortly :) [12:01:53] addshore: i didn't test this at all, may even contain syntax errors. [12:01:59] haha :D [12:02:03] i just wanted you to see what I though would be the correct approach [12:02:14] (03CR) 10Daniel Kinzler: [C: 031] "CR+1 since this just restores old behavior. Needs manual testing with XML output mode though." [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97492 (owner: 10Addshore) [12:07:41] addshore: actually, all that logic should go into the ResultBuilder, and use an EntityRevision object [12:08:07] yus :) [12:08:23] infact I think the change to use entityrevision is already on gerrit somewhere :P [12:08:33] and probably to move the logic too [12:08:52] DanielK_WMDE_: so you were wondering how the descriptions appear on special:search.... [12:09:10] we use a hook "onShowSearchHit" to add them [12:09:48] aude: and load them individually?... [12:09:53] apparently so [12:09:57] would be nice if we could get them directly from elastic [12:10:07] i am sure it can be done [12:10:15] i'm sure elastic supports it [12:10:25] * aude cleaning up the hooks file and see interesting stuff :) [12:10:33] the difficulty is the crufty search engine interface mediawiki uses [12:18:14] (03PS7) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97842 [12:23:22] (03PS1) 10Aude: Cleanup Wikibase hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98162 [12:32:21] (03CR) 10Zfilipin: [C: 04-1] "I hope this is the last change that needs to happen. :)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97842 (owner: 10Mayankmadan) [12:38:04] (03PS8) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97842 [12:39:51] (03PS1) 10Tobias Gritschacher: Add a module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [12:42:03] DanielK_WMDE_: your patch works just perfectly :P [12:42:31] addshore: \o/ [12:42:35] any objection to merging both mine and thus your on top of it? [12:42:42] then I can work on rebasing my other patches :) [12:42:50] fine with me :) [12:43:13] (03PS2) 10Addshore: Use correct result path in getentities module. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98161 (owner: 10Daniel Kinzler) [12:43:20] (03PS2) 10Addshore: Restore old result path in wbgetentites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97491 [12:43:26] (03PS3) 10Addshore: Use correct result path in getentities module. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98161 (owner: 10Daniel Kinzler) [12:44:28] (03CR) 10Addshore: [C: 032 V: 031] "Manually checked XML output of getentities" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98161 (owner: 10Daniel Kinzler) [12:44:39] (03CR) 10Addshore: [V: 031] Restore old result path in wbgetentites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97491 (owner: 10Addshore) [12:45:30] (03CR) 10Addshore: [V: 031] "I have manually tested and verified" [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97492 (owner: 10Addshore) [12:46:30] where's the review chocolate? [12:46:33] :/ [12:46:54] * addshore gets chocolate out of his draw [12:47:00] :) [12:47:49] (03CR) 10Zfilipin: [C: 031] Prefer double-quoted strings in Ruby code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97842 (owner: 10Mayankmadan) [12:48:49] lovely param documentation we have [12:48:50] "@param weirdStuffButProbablyWikiPage $article" [13:17:43] (03PS12) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:17:49] (03CR) 10jenkins-bot: [V: 04-1] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [13:19:20] Tobi_WMDE: JeroenDeDauw http://nakedsecurity.sophos.com/2013/11/29/bitcoin-millionaire-throws-7-5m-virtual-currency-in-the-bin/?utm_source=Naked+Security+-+Sophos+List&utm_medium=email&utm_campaign=31a967c9d4-naked%252Bsecurity&utm_term=0_31623bb782-31a967c9d4-418408753 [13:20:50] (03PS13) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:23:28] (03CR) 10jenkins-bot: [V: 04-1] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [13:27:16] (03PS14) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:30:29] (03PS15) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:41:03] (03CR) 10Daniel Kinzler: [C: 032] "issue fixed in follow-up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97491 (owner: 10Addshore) [13:44:29] (03Merged) 10jenkins-bot: Use correct result path in getentities module. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98161 (owner: 10Daniel Kinzler) [13:44:30] (03Merged) 10jenkins-bot: Restore old result path in wbgetentites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97491 (owner: 10Addshore) [14:38:25] @configure default-link-wiki=wikidata [14:38:25] Value wikidata was stored into default-link-wiki to config [14:38:32] @link [14:38:32] http://enwp.org/List_of_classical_music_composers_by_era https://de.wikipedia.org/wiki/Komponist#Komponisten_(Klassik)_-_Grafische_%ef%bf%bdbersicht http://enwp.org/Composer [14:38:40] @link [[Q485]] [14:38:40] http://enwp.org/Q485 [14:38:46] NO!!! [14:38:57] @configure default-link-wiki=en:d [14:38:57] Value en:d was stored into default-link-wiki to config [14:39:07] @link [[Q485]] [14:39:07] http://enwp.org/Q485 [14:39:14] o_O [14:44:15] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "works as well as the original version - i.e. cases a fatal error when listing two entities with different types but identical numeric id. " [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97492 (owner: 10Addshore) [14:44:50] addshore: maybe we should backport https://gerrit.wikimedia.org/r/#/c/98161/ [14:47:35] (03Merged) 10jenkins-bot: Restore old result path in wbgetentites [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97492 (owner: 10Addshore) [14:48:40] (03CR) 10Daniel Kinzler: [C: 032] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [14:49:23] (03PS11) 10Daniel Kinzler: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [14:49:34] (03PS7) 10Daniel Kinzler: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [14:50:25] (03CR) 10Daniel Kinzler: "CR-1 see comment on PS10" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [14:52:51] (03Merged) 10jenkins-bot: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [14:53:09] (03CR) 10Daniel Kinzler: [C: 04-1] "see comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [14:55:25] (03CR) 10jenkins-bot: [V: 04-1] Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [14:56:03] (03PS2) 10Daniel Kinzler: Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 [14:58:32] (03PS2) 10Tobias Gritschacher: Add a module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [15:02:13] @since 1.20 in wikibase :o [15:02:38] when did we release Wikibase 1.20 ? :) [15:03:53] (03PS1) 10Aude: Cleanup in Change classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98171 [15:06:37] (03CR) 10Tholam: "Is the missing description the only problem right now?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [15:07:01] (03CR) 10jenkins-bot: [V: 04-1] Cleanup in Change classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98171 (owner: 10Aude) [15:07:33] wtf [15:11:23] (03PS8) 10Daniel Kinzler: Allow ItemContent to represent a redirect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 [15:12:54] @add ##DangSunM [15:15:39] (03PS3) 10Tobias Gritschacher: Add a module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [15:16:01] (03PS2) 10Aude: Cleanup in Change classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98171 [15:16:40] (03PS4) 10Tobias Gritschacher: Add a module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [15:18:56] (03PS5) 10Tobias Gritschacher: Module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [15:20:15] (03PS1) 10Tobias Gritschacher: Include statement browsertests again on bbeta.wmflabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98172 [15:25:09] (03CR) 10Addshore: [C: 04-1] "per daniels -1, I have no idea where it vanished to ..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [15:28:03] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Prefer double-quoted strings in Ruby code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97842 (owner: 10Mayankmadan) [15:33:13] (03PS1) 10Aude: Move Summary class to lib, allow use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98173 [15:44:15] (03PS6) 10Tobias Gritschacher: Module for interacting with Wikibase-API in browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98163 [15:44:30] (03PS2) 10Tobias Gritschacher: Include statement browsertests again on bbeta.wmflabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98172 [15:44:36] (03PS3) 10Tobias Gritschacher: Include statement browsertests again on bbeta.wmflabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98172 [16:03:42] (03CR) 10Tobias Gritschacher: [C: 032] Refactored inputAutoExpand jQuery plugin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94769 (owner: 10Henning Snater) [16:04:18] (03Merged) 10jenkins-bot: Refactored inputAutoExpand jQuery plugin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94769 (owner: 10Henning Snater) [16:14:45] (03PS2) 10Addshore: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 [17:29:29] (03CR) 10Bene: [C: 031] "I think this looks good now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90755 (owner: 10Bene) [17:36:01] (03PS3) 10Bene: (bug 56693) special page for setting sitelinks needs to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [17:47:38] Hello, I have a question about the geo marks on the osm map, which is shown in some articles. How can I download the entire kml data for a defined area? [17:52:45] I tried it with an enlarged bbox value on this url "https://toolserver.org/~kolossos/geoworld/marks.php?LANG=de&thumbs=0&bbox=" but i only got an kml file with less data [18:00:44] addshoretravel: left just a few minutes ago? [18:01:35] liangent: 30ish [18:33:54] (03PS9) 10Daniel Kinzler: (bug 57744) Allow ItemContent to represent a redirect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 [18:35:47] (03CR) 10jenkins-bot: [V: 04-1] (bug 57744) Allow ItemContent to represent a redirect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 (owner: 10Daniel Kinzler) [18:43:57] (03PS7) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [18:53:20] (03PS4) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 [18:53:25] (03CR) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [18:55:03] (03CR) 10Bene: (bug 46353) Forbid to label properties as valid property IDs (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [19:02:49] Lydia_WMDE: hi [19:28:27] (03PS1) 10Bene: Rename SpecialSetEntity to SpecialModifyLangAttribute [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 [19:31:36] (03CR) 10jenkins-bot: [V: 04-1] Rename SpecialSetEntity to SpecialModifyLangAttribute [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [19:39:31] (03PS2) 10Bene: Rename SpecialSetEntity to SpecialModifyLangAttribute [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 [20:19:37] (03CR) 10Jeroen De Dauw: "Chad: because it is such a pile of fail design that I'm not sure one ought to call it an API" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [20:20:22] (03PS2) 10Tholam: Special:ItemDisambiguation to show link to Special:Search if no results are found [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 [20:26:20] addshoretravel: aww. That is a lot of BTC [20:26:39] addshoretravel: you are now travelling to the landfill to recover the disk? [20:52:42] benestar: hey! [20:52:48] hi Lydia_WMDE :D [20:52:55] wasup benestar? :) [20:53:00] good to see you again [20:53:18] https://gerrit.wikimedia.org/r/#/c/89859/ [20:53:20] ;) [20:53:32] hah [20:53:33] yeah [20:54:15] did you see what i wrote in the bug report in the last comment after i had a chat with the universal language selector team? [20:54:53] yes... [20:55:02] ok good [20:55:06] So the languages should be stored in SUL? [20:55:15] *ULS [20:55:19] in the future yes [20:55:31] it currently can't do this though [20:55:39] but how does ULS know the three languages? [20:55:46] until then i think we should continue doing what we do now [20:55:57] it makes a guess based on location (via IP) [20:56:00] and some other things [20:56:07] i think browser settings for example too [20:56:21] but I speak a language that isn't near my location but still want to see it in the box? [20:56:23] so if i am in germany it might guess that i also know english and french [20:56:29] what should I do then? [20:56:43] then you set up your babel box like you do right now [20:56:56] the guesses are only for when this box isn't set [20:57:07] hmm, I wanted to make the adding of languages more easy for the user [20:57:21] yes and it will be in the future [20:57:26] so that he does not have to add a babel box but can simply add a language in his preferences [20:57:26] but that should be in ULS [20:57:32] yes [20:57:42] that is the goal for the future [20:57:57] I think there should also be an option in Wikibase itself without other extensions... [20:58:19] we rely on ULS heavily anyway and it really is the right place [20:58:32] because not only wikidata will need to know which language a user speaks [20:58:38] also commons for example in the future [20:58:46] but it could be an additional feature to add the preferences [20:58:47] and there should be only one place to set this up [20:59:02] i'd like us to not add redundant settings [20:59:13] because a lot of settings are really really bad for the user experience [20:59:18] and also maintainability [20:59:21] that's true [21:00:04] however, I think we have to notice that there might be a difference between the languages a user speaks and the ones he/she wants to see in the "in other languages" box [21:01:01] there might be but to be honest i don't want to cater to this small usecase if it makes the experience worse for the rest [21:01:41] ok, if you are sure that this usecase is so small we can really forget about it [21:02:10] (sorry for being so no-no on this topic but we really need to be careful with adding more options and features to a project that is already super complicated for users) [21:02:16] :) [21:02:24] i think it is very small yes [21:04:32] benestar: is this ok for you? [21:05:07] yes, of course [21:05:11] cool :) [21:05:26] I fully understand you concerns ;) [22:54:41] Lydia_WMDE: any chance you're still on [22:54:50] Sven_Manguard: hey [22:54:50] jep [22:55:06] JohnLewis and I are chatting about the no value/unknown value thing [22:56:07] PM'ed [22:57:47] Lydia_WMDE: hey! quick question: I sent a coupld of mails to the HPI team'S mailing list today. Did they get through? I didn't get echos. [23:00:07] DanielK_WMDE_: i got them yes - assuming you didn't put me in bcc it got through [23:00:08] :) [23:02:26] Lydia_WMDE: good, thanks [23:02:30] writing another one now.- [23:02:34] :D [23:03:02] Lydia_WMDE: oh, did nilesh's response also get through? We should get them on that list (or move all discussions to wikidata-tech) [23:03:16] *get him on that list [23:03:41] DanielK_WMDE_: also got that one, yeah - and i'd really prefer if they'd all be done on wikidata-tech indeed [23:09:11] ok [23:09:41] hm, would need to re-post the original mails there... [23:10:26] meh :D [23:10:29] then not i guess [23:16:02] is meaning, that a revisoin got reverted? [23:16:10] is delte and revert the same? [23:17:31] lbenedix: Nope. [23:17:51] deleted to me is, revdel, oversight or deleted item. [23:17:52] the text before and after this node are identical [23:21:53] Lydia_WMDE: next time :) [23:22:11] yeah :) [23:24:10] (03PS1) 10Jcf2000: Retain POSTed aliases input on Special:SetAliases in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98251 [23:24:36] hello [23:28:04] hey [23:31:28] hi [23:49:00] (03PS3) 10Addshore: Special:ItemDisambiguation to show link to Special:Search if no results are found [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [23:52:36] (03CR) 10Addshore: [C: 032] Special:ItemDisambiguation to show link to Special:Search if no results are found [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [23:53:14] (03CR) 10Addshore: [C: 032] Retain POSTed aliases input on Special:SetAliases in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98251 (owner: 10Jcf2000) [23:56:11] (03Merged) 10jenkins-bot: Special:ItemDisambiguation to show link to Special:Search if no results are found [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [23:59:11] (03Merged) 10jenkins-bot: Retain POSTed aliases input on Special:SetAliases in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98251 (owner: 10Jcf2000)