[00:58:56] addshore: REVIEW!!!! [02:11:35] aude: you, for some reason, still awake? [04:33:17] (03PS1) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98062 [06:09:58] (03CR) 10Aude: [C: 04-1] "can you please amend the previous commit to include the changes here, instead of submitting a second patch? that's normally how we like t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98062 (owner: 10Jcf2000) [06:29:02] (03PS1) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [06:32:11] (03PS2) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [06:35:07] (03PS3) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [08:47:55] are the terms "delete" and "revert" name the same concept in mediawiki? [10:59:47] (03PS1) 10Henning Snater: claimlistview: Fixed updating claim indices [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98083 [11:05:12] (03PS1) 10Henning Snater: Use pointer cursor when hovering rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98084 [11:05:18] (03CR) 10jenkins-bot: [V: 04-1] Use pointer cursor when hovering rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98084 (owner: 10Henning Snater) [11:13:03] DanielK_WMDE: Tobi_WMDE Henning_WMDE http://dpaste.com/1485984/ [11:13:08] * aude getting test failures [11:13:39] i pulled master of everything [11:15:03] and travis has EditEntity api failure [11:15:04] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/14618944 [11:16:29] the travis failure is random and doesn't always occur [11:16:53] and travis doesn't report the thing i see [11:21:44] Tobi_WMDE: I saw your e-mail to QA mailing list [11:22:08] let me know if you need the user this week, americans are on holiday for the rest of the week [11:28:28] (03PS2) 10Tobias Gritschacher: Use pointer cursor when hovering rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98084 (owner: 10Henning Snater) [11:35:45] aude: I guess that is related to the claim-index - Henning_WMDE probably knows more. I wonder why that passed on jenkins.. [11:36:28] zeljkof: how difficult is it to get that user [11:36:29] ? [11:36:47] (03CR) 10Aude: [C: 031] "this looks good now, though I am getting unrelated tests failures. (http://dpaste.com/1485984/)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [11:36:51] if it is easy to do, then I would appreciate to get it this week [11:36:58] if not, next week is also ok [11:37:16] Tobi_WMDE: I have no idea :) [11:37:32] I should have some privileges at beta cluster, I can try creating a user, if you know what needs to be done [11:37:35] (03CR) 10Aude: "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [11:37:48] or I can give you credentials, if you know which credentials you need [11:37:59] Tobi_WMDE: no idea why jenkins and travis don't complain [11:38:00] zeljkof: I have no idea.. :) [11:38:19] Tobi_WMDE: let's leave it to Chris next week then :) [11:38:20] aude: Tobi_WMDE I am looking into it. Seems to be a problem with ByPropertyIdArray. Might be due to the cross dependency on WikibaseDatamodel that the failures slipped through. [11:38:23] zeljkof: so probably wait for someone who knows [11:38:27] zeljkof: what do you need? [11:38:51] aude: acutally Tobi_WMDE needs a user at beta cluster [11:39:02] aude: zeljkof: I need a test-user on beta-wikidata that has privileges to create properties [11:39:03] Tobi_WMDE, could you provide more info to aude [11:39:04] with sysop rights? [11:39:11] property creator rights? [11:39:18] (03PS1) 10Daniel Kinzler: Allow callbacks in factories for formatters/parsers. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98087 [11:39:20] aude: exactly [11:40:04] aude: could be that more privileges are needed later, but for the moment creating properties would be enough [11:40:10] k [11:43:07] there is "User:Selenium user" [11:43:12] doesn't appear to be used [11:43:27] do we use that or make a new user? [11:43:39] if we use that, no idea the password [11:44:44] * aude makes new user [11:44:46] (03PS1) 10Henning Snater: ByPropertyIdArray: Properly remove object [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/98088 [11:45:25] aude: ^^ That should fix it. [11:45:30] thanks [11:45:42] (03CR) 10Tobias Gritschacher: [C: 032] Use pointer cursor when hovering rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98084 (owner: 10Henning Snater) [11:49:09] (03Merged) 10jenkins-bot: Use pointer cursor when hovering rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98084 (owner: 10Henning Snater) [11:54:00] The user name "WikidataTester" has been banned from creation. It matches the following blacklist entry: .*(wiki(?:[mp]edia(?!n)|books|data|quote|versity|source|news|species|voyage)|wiktionary).* [11:54:04] lovely [11:54:20] * aude overrules the filters! [11:55:42] (03CR) 10Tobias Gritschacher: [C: 032] claimlistview: Fixed updating claim indices [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98083 (owner: 10Henning Snater) [11:57:43] Tobi_WMDE: you have mail [11:59:12] (03Merged) 10jenkins-bot: claimlistview: Fixed updating claim indices [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98083 (owner: 10Henning Snater) [11:59:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1282 (master - 371973d : Henning Snater): The build is still failing. [11:59:44] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/97f9a0ca3c27...371973dfc989 [11:59:44] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14652098 [12:02:54] (03CR) 10Aude: [C: 032] ByPropertyIdArray: Properly remove object [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/98088 (owner: 10Henning Snater) [12:03:05] (03Merged) 10jenkins-bot: ByPropertyIdArray: Properly remove object [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/98088 (owner: 10Henning Snater) [12:04:49] aude: thx! [12:05:01] (03PS1) 10Henning Snater: Updated JavaScript DataType definition [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98091 [12:05:03] (03CR) 10jenkins-bot: [V: 04-1] Updated JavaScript DataType definition [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98091 (owner: 10Henning Snater) [12:05:24] (03PS2) 10Henning Snater: Updated JavaScript DataType definition [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98091 [12:05:25] Tobi_WMDE: if you create yourself an account on beta, i can make it a bureaucrat [12:05:38] so you can do these things in the future [12:05:49] aude: ok. that sounds good. [12:07:15] (03CR) 10Aude: [C: 032] (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [12:07:45] (03PS1) 10Henning Snater: Added .jshintrc [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98093 [12:07:54] (03PS2) 10Henning Snater: Added .jshintrc [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98093 [12:10:14] (03CR) 10jenkins-bot: [V: 04-1] (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [12:10:27] wtf [12:10:40] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1283 (master - ef2163b : jenkins-bot): The build was fixed. [12:10:40] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/371973dfc989...ef2163ba7e78 [12:10:40] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14652601 [12:11:28] tests passed for me! [12:13:04] on rebasing, they fail [13:15:29] (03CR) 10Tobias Gritschacher: [C: 04-1] Prefer double-quoted strings in Ruby code (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97842 (owner: 10Mayankmadan) [13:22:47] (03CR) 10Addshore: [C: 032] Added .jshintrc [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98093 (owner: 10Henning Snater) [13:29:14] (03PS5) 10Tobias Gritschacher: Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater) [13:42:07] (03CR) 10Aude: [C: 032] Updated JavaScript DataType definition [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98091 (owner: 10Henning Snater) [13:42:31] * aude merge all the javascript :) [13:43:10] (03Merged) 10jenkins-bot: Added .jshintrc [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98093 (owner: 10Henning Snater) [13:43:11] (03Merged) 10jenkins-bot: Updated JavaScript DataType definition [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/98091 (owner: 10Henning Snater) [14:13:00] is there anyone here who can do a small query for me on items on d: ? [14:43:44] Tobi_WMDE: did you get the user created? [14:46:19] zeljkof: yes! aude created one for me. [14:46:31] Tobi_WMDE: great [14:46:40] I'm currently implementing a mechanism to login whenever a test requires that [14:46:44] could you send e-mail to qa list so chris knows not to create one? [14:46:53] will do! [14:46:58] thanks [14:51:05] (03PS4) 10Henning Snater: Refactored inputAutoExpand jQuery plugin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94769 [14:59:06] (03PS1) 10Addshore: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 [15:00:01] (03CR) 10Addshore: Further refactor GetEntitiesOutput (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [15:00:05] DanielK_WMDE_: ^^ [15:01:36] (03PS1) 10Daniel Kinzler: (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 [15:02:10] (03CR) 10jenkins-bot: [V: 04-1] (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 (owner: 10Daniel Kinzler) [15:05:04] (03PS1) 10Daniel Kinzler: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 [15:05:31] (03PS2) 10Daniel Kinzler: (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 [15:08:46] (03CR) 10jenkins-bot: [V: 04-1] (bug #56685) Parsing of localized quantities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98101 (owner: 10Daniel Kinzler) [15:17:48] (03PS10) 10Daniel Kinzler: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [15:19:23] (03PS11) 10Daniel Kinzler: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [15:19:30] aude: fixed --^ [15:19:51] hmmm [15:22:02] what evilness.... [15:27:40] (03PS12) 10Daniel Kinzler: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [15:27:41] (03PS10) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [15:29:37] (03CR) 10Aude: [C: 032] "finally looks okay" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [15:30:27] (03CR) 10jenkins-bot: [V: 04-1] (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [15:30:53] * aude screams [15:31:23] DanielK_WMDE_: ! ^ [15:31:58] this dispatching serializer thing is broken also [15:32:43] (03CR) 10jenkins-bot: [V: 04-1] (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [15:32:56] (03CR) 10Aude: [C: 04-1] "tests fail massively for me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [15:34:27] (03CR) 10Aude: "injecting the serializer options everywhere like this is probably going to be brittle." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [15:36:35] (03PS13) 10Daniel Kinzler: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [15:37:22] aude: this should work ---^ no idea why gerrit undid my fixes in PS12. [15:37:36] it manages to surprise me time and time again... [15:37:53] * aude waits for jenkins [15:38:42] this stuff looks evil [15:40:40] (03PS11) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [15:41:48] aude: jenkins passed on the first patch, i now managed to rebase the second patch on top of it without breaking the first one again :) [15:42:02] \o/ [15:42:48] i don't want to see this stuff in master very long without follow up on improving how options / factory are injected [15:44:45] aude: not sure how this can be improved except for actually forcing them to be injected instead of falling back to "defaults" [15:45:11] serializer factory takes $options (which are actully some "defaults') [15:45:16] actually* [15:45:25] anyway, there's a bug upen for redesignign the entire serialization shebang [15:45:28] then need to be passed when calling the method [15:45:32] * aude nods [15:45:45] and then how entity view accesses serializers [15:45:48] messy [15:46:04] the options? perhaps. but the serializers may still need services. which are needed at construction time. [15:47:03] * aude sees code like "new SerializerFactory( $serializationOptions ); " [15:47:07] then "$serializerFactory->newSerializerForObject( $entity, $serializationOptions );" [15:47:24] the first serialization options are actually some kind of "default" [15:48:24] then newSerializationForObject has options as optional param [15:48:37] if it is null, then does $options = new SerializationOptions() [15:48:41] not using the defaults? [15:49:02] * aude doesn't quite understand the logic [15:49:46] wouldn't the defaultOptions be better than new SerializationOptions [15:49:50] (03PS2) 10Daniel Kinzler: (bug #56685) Parsing of localized decimal values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98100 [15:50:18] or i wait for some grand refactoring :) [15:50:40] aude: uh, when and where does it use new serialization options? [15:50:53] serializer factory [15:51:02] JeroenDeDauw: typo on line 5 [15:51:04] if you don't see a good reason for that, i can fix [15:51:13] JeroenDeDauw: autoloder :> [15:51:15] JeroenDeDauw: typo in first word :) [15:51:29] aude: it should be using makeOptions?... [15:52:12] oh gah [15:52:20] seeing $this->makeOptions() everywhere! [15:54:13] JeroenDeDauw: also search for autoloding which is also wrong :P [15:54:23] you dont seemt o like putting the a in load :P [15:54:35] and apparently I dont want to put the t at the begining of to .... [15:56:54] (03CR) 10Aude: [C: 032] "i want to see some follow up soon on how we handle serialization options, etc., but this can go in now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [16:00:19] (03Merged) 10jenkins-bot: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [16:00:34] (03CR) 10Aude: [C: 032] "i want to see some follow up soon on how we handle serialization options, etc., but this can go in now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [16:03:59] (03Merged) 10jenkins-bot: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [16:12:18] (03PS2) 10Daniel Kinzler: (bug #56685) localize quantities when formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 [16:14:09] (03CR) 10jenkins-bot: [V: 04-1] (bug #56685) localize quantities when formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97789 (owner: 10Daniel Kinzler) [16:15:18] jenkins is not happy today :/ [16:17:07] (03CR) 10Daniel Kinzler: [C: 04-1] "that FIXME worries me. Let's find a better solution for numeric keys." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97491 (owner: 10Addshore) [16:17:10] addshore: --^ [16:18:00] addshore: shouldn't all that logic be in ResultBuilder? [16:18:09] if so, that would be a good place to put an index counter... [16:18:38] yes, this is the one thing I havnt moved yet :) [16:19:51] addshore: or use the mathematicians approach: assign a prime number to each entity type, and multiply the numeric ID with this prime, and use the result as the index [16:19:54] that will be unique :) [16:20:39] (03CR) 10Daniel Kinzler: [C: 032] Make sure ApiResult is ready before using it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97736 (owner: 10Addshore) [16:20:53] (03CR) 10Daniel Kinzler: [C: 032] Make sure ApiResult is ready before using it [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97738 (owner: 10Addshore) [16:21:12] assign a random number :) [16:21:46] use the first 31 bits of an sha1! [16:21:52] :D [16:24:09] (03Merged) 10jenkins-bot: Make sure ApiResult is ready before using it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97736 (owner: 10Addshore) [16:24:14] (03CR) 10Daniel Kinzler: [C: 032] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [16:24:30] (03CR) 10jenkins-bot: [V: 04-1] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [16:25:01] jenkins is really grumpy [16:25:36] (03CR) 10Daniel Kinzler: [C: 032] Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore) [16:25:42] (03CR) 10jenkins-bot: [V: 04-1] Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore) [16:27:12] (03Merged) 10jenkins-bot: Make sure ApiResult is ready before using it [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97738 (owner: 10Addshore) [16:48:15] aude: no tests for DiffOpValueFormatter?? [16:49:41] it's ancient so probably not [16:49:47] or not suprised [16:49:52] surprised* [16:51:12] http://ultimategerardm.blogspot.nl/2013/11/a-brilliant-idea-barnstar.html I learned that we DO know what articles were not found :) [17:01:28] (03PS13) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [17:01:29] (03PS7) 10Aude: Split ChangeHandler::getPagesToUpdate into new class with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 [17:01:43] (03CR) 10Aude: Introduce ChangeLineFormatter in the client (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [17:09:10] DanielK_WMDE_: merge all the stuff :) [17:09:45] * aude has more stuff to follow, based on this stuff to handle rc_source [17:41:34] (03PS1) 10Daniel Kinzler: (bug 56684) Use HTML formatters in diffs. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98110 [18:22:39] (03CR) 10Daniel Kinzler: [C: 04-1] Improve exception handling in SpecialModifyEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [18:31:38] (03PS4) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [18:34:33] (03CR) 10Daniel Kinzler: [C: 04-1] "getting there..." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [18:35:56] (03CR) 10Daniel Kinzler: [C: 04-1] Improve exception handling in SpecialModifyEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [18:36:04] * aude rage [18:37:35] (03CR) 10Daniel Kinzler: Split ChangeHandler::getPagesToUpdate into new class with tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 (owner: 10Aude) [18:38:25] (03PS5) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [18:38:46] (03CR) 10Daniel Kinzler: [C: 031] "restoring +1 after rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 (owner: 10Aude) [18:41:14] (03CR) 10Aude: [C: 04-1] "should refactor comments code first" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [18:43:56] aude: i have another nitpick for the SpecialModifyEntity patch, but it's not that important... if you are tired of that one, i can just merge it. [18:43:58] what do you think? [18:44:08] what do you want? [18:44:17] (03CR) 10Daniel Kinzler: Improve exception handling in SpecialModifyEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [18:44:20] that [18:44:22] gerrit is eating my stuff! [18:44:26] * aude annoyed [18:44:31] yea, had that happen to me today... [18:45:04] anyway, i can make that a -1 or a +2. the code works and it's an improvement. moving the check would make it better. [18:56:30] (03PS14) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [18:56:57] (03CR) 10Aude: "seems necessary to refactor the comments handling code first" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [18:57:23] (03CR) 10Aude: Introduce ChangeLineFormatter in the client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [18:58:05] (03PS15) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [18:58:06] (03PS8) 10Aude: Split ChangeHandler::getPagesToUpdate into new class with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 [18:58:15] (03CR) 10Aude: [C: 04-1] "seems necessary to refactor the comments handling code first" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [18:59:53] addshore: thnx [19:00:05] $this->makeOptions() ? huh? [19:04:33] (03PS6) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [19:04:49] JeroenDeDauw: combining two option objects, unless one of them is null (in that case, just use the other) [19:04:57] could be called combineOptions, i guess [19:05:21] * aude cringes :) [19:06:23] the idea is to be able to apply defaults without too much overhead [19:07:22] $this->applyDefaultOptions() [19:07:34] would at least be more clear [19:07:55] aude: that doesn't make clear that a new object is created [19:08:05] "apply" actually implies that an object is modified [19:09:26] makeOptions is confusing, imho [19:10:23] well, how does it confuse, and what would be better? [19:10:26] among other isues [19:10:32] issues* [19:11:30] well, how would you have solved the issues of having a default and a specific options object, each of which may be null, and needing to combine them in a way that modifies nither? [19:14:05] * aude would refactor all the serializers :) [19:14:23] which is on our todo [19:14:56] well, yea - i was looking for a solution that doesn't involve 3000 lines of change :) [19:17:05] (03PS2) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98062 [19:20:28] (03CR) 10Daniel Kinzler: [C: 04-1] "so close!" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [19:21:22] (03PS3) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98062 [19:22:03] (03PS1) 10Daniel Kinzler: Introducing HtmlUrlFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98121 [19:36:28] (03PS2) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 [19:37:42] (03PS7) 10Aude: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 [19:37:45] (03CR) 10Aude: Improve exception handling in SpecialModifyEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [19:39:50] (03CR) 10Hoo man: [C: 04-1] ""Author: daniel " ... is this really the change you wanted to upload?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [19:41:43] looks like a squash gone wrong [19:42:05] mh [19:42:14] arg [19:42:14] maybe he just amended whatever was HEAD [19:42:22] * aude tried to explain [19:42:59] ewk... git can be hard to understand for beginners [19:43:09] (03CR) 10Jcf2000: "No, it wasn't the change I was trying to make. When I was downloading from gerrit his code got mixed in" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [19:45:21] aude: Is that a google code in student? (Is google code in even running atm... I don't know) [19:45:31] he is [19:45:44] ah, I see... probably rather new to git [19:45:47] be nice :) [19:45:55] * hoo tries to remember how he learned git first [19:46:00] yeah [19:47:27] I think I just used online documentation and figured it out from time to time [19:48:11] I messed local repos several times (up to the point I 'rm -rf'ed them) :D But luckily I never eally messed on gerrit [19:49:47] yikes [19:50:37] * aude goes home before gerrit eats my commits [19:50:47] (03CR) 10Jcf2000: "Whenever I try do perform a git-review -d on my change ID, it downloads that as well" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [19:51:01] yeah, damn [19:52:27] (03CR) 10Hoo man: "git checkout master; git reset HEAD; git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikibase refs/changes/11/98011/1 && git" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [19:52:44] I hope that works :P [19:54:37] (03Abandoned) 10Jcf2000: Retain form input on Special:SetSiteLink in case of an error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [19:54:46] oh no :( [19:56:12] (03CR) 10Hoo man: "Doesn't matter... just do what I wrote above (I hope it works, haven't tested), then do your changes, then 'git commit -a --amend' and the" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98011 (owner: 10Jcf2000) [20:04:48] (03PS1) 10Daniel Kinzler: (bug 56684) Show Quantity details in diff. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 [20:11:48] (03CR) 10Daniel Kinzler: [C: 032] Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [20:13:06] (03CR) 10Daniel Kinzler: [C: 032] Split ChangeHandler::getPagesToUpdate into new class with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96384 (owner: 10Aude) [20:15:21] (03Merged) 10jenkins-bot: Improve exception handling in SpecialModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98070 (owner: 10Aude) [20:25:08] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1288 (master - b35f32b : jenkins-bot): The build passed. [20:25:08] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/46206b19f77b...b35f32bbb5b5 [20:25:08] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14673430 [22:21:11] (03PS1) 10Tholam: Special:ItemDisambiguation to show link to Special:Search if no results are found [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 [22:26:46] (03CR) 10Tholam: "I haven't been able to test it yet but will post an update once I've installed all the necessary extensions to see if this works." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98133 (owner: 10Tholam) [23:38:12] (03CR) 10Aude: (bug 56684) Show Quantity details in diff. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98124 (owner: 10Daniel Kinzler)