[02:03:22] (03PS1) 10Shirayuki: i18n: add comments for grep [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97462 [04:47:07] aude: any chance you're awake? [06:00:25] It is utterly stupid to add Commons categories to other categories. It serves no purpose. My arguments can be found here; http://ultimategerardm.blogspot.nl/2013/11/wikidata-howto-commons-categories.html [06:35:00] I also think it was stupid. The overwhelming majority of the subjects will never have galleries [07:15:27] (03CR) 10Aude: [C: 032] i18n: add comments for grep [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97462 (owner: 10Shirayuki) [07:19:49] (03Merged) 10jenkins-bot: i18n: add comments for grep [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97462 (owner: 10Shirayuki) [09:19:10] (03CR) 10Jens Ohlig: "This patch is potentially problematic. Although it does the right thing, it may break templates that rely on the wrong thing. Don't merge " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 (owner: 10Jens Ohlig) [09:19:31] (03PS8) 10Jens Ohlig: (Bug 54324) Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 [09:19:39] (03CR) 10jenkins-bot: [V: 04-1] (Bug 54324) [DON'T MERGE] Sequences in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 (owner: 10Jens Ohlig) [09:27:25] (03PS4) 10Daniel Kinzler: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [09:28:02] addshore: hey. fixed the conflict in ResultBuilder ---^ [09:28:21] no addshore here yet [09:29:00] hey katie [09:29:05] too bad, that :) [09:29:20] (03PS4) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [09:30:10] (03CR) 10jenkins-bot: [V: 04-1] (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 (owner: 10Daniel Kinzler) [09:30:42] (03PS5) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [09:31:48] meh. [09:33:14] Hoi Amir, happy to be back home ... but also happy to have been to Pune ? [09:33:22] (03CR) 10jenkins-bot: [V: 04-1] (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 (owner: 10Daniel Kinzler) [09:34:10] hm, looks like this test isn't even run with --group Wikibase? Waht gives?? [09:34:23] (03PS5) 10Daniel Kinzler: (bug 54320) Include datatype in snak serialization. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96258 [09:42:01] (03CR) 10Daniel Kinzler: [C: 04-1] "Avoid ad-hoc composition" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95357 (owner: 10Addshore) [09:42:32] (03PS6) 10Daniel Kinzler: (bug 57214) use DispatchingEntitySerializer for JSON [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96259 [09:53:40] (03CR) 10Daniel Kinzler: [C: 04-1] "Can't see when and where language codes get validated." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent) [10:01:20] GerardM-: Pune is great, home is the best. [10:01:37] :) [10:02:28] today on the WMF blog we introduce "concept clouds" ... I am interested in what you think about it ... [10:03:43] (03CR) 10Liangent: [C: 04-1] "Huh it's old and there even wasn't a ResultBuilder IIRC." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent) [10:08:04] (03CR) 10Daniel Kinzler: "should go to core?" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 (owner: 10Aude) [10:08:30] (03CR) 10Daniel Kinzler: [C: 04-1] "please rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 (owner: 10Jens Ohlig) [10:52:39] Lydia_WMDE: What about we restore the exact label behavior from the old version in my linkItem patch? [10:53:00] hoo: yeah let's [10:53:13] That way we don't add more label == sitelink assumptions, but we also don't disappoint users to much [10:53:14] :) [10:53:25] yeah [10:53:50] We also need a tracking bug for (optional) label fallbacks... will you open it or shall I? [10:54:28] if you have a sec to do it please do - otherwise i will after i fought the massive email backlog looking at me right now [10:54:55] heh, will do :) [10:55:33] thx! [10:57:13] :< [10:57:42] "# Changes not staged for commit:" meh... [10:59:04] (03PS1) 10Hoo man: Make sure Scribunto is using Lua before adding our Lua scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97489 [11:29:47] (03PS1) 10Addshore: Restore old result path in wbgetentites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97491 [11:30:37] (03PS1) 10Addshore: Restore old result path in wbgetentites [extensions/Wikibase] (mw1.23-wmf5) - 10https://gerrit.wikimedia.org/r/97492 [11:33:30] this late already... meh [11:49:59] aude: Hallo again. I'm still trying to configure my client and I should be really-really close now. Are you available to help a bit? [11:56:00] DanielK_WMDE, Lydia_WMDE - is there anybody here who could help me with a test client installation? [12:03:22] On my local laptop I created a repo and two clients. I am trying to create sitelinks between them, but I get page titles from the live Wikipedias and not from my sites. What should I fix? [12:04:01] kart_: ^ is it the same issue that you are having? [12:24:05] aharoni: look at the "sites" table in the database. make sure it contains "your" site ids with "your" urls. [12:24:35] sadly, there's really no good way currently to manipulate that table manually. it contains a serialized blob... [12:24:49] hm, perhaps file a bug about that :) [12:29:25] DanielK_WMDE: thanks, looking at it. [12:34:24] DanielK_WMDE: at that table in the repo wiki? or in the repo and the clients? [12:36:31] (03CR) 10Daniel Kinzler: [C: 04-1] "documentation issues" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [12:37:04] aharoni: all wikis. they should to be the same under most circumstances. [12:37:24] Ok [12:37:47] please add to the install instructions, and/or file issues... [12:46:31] (03CR) 10Daniel Kinzler: [C: 04-1] "PLease use EntityRevision / EntityRevisionLookup. Don't spread the EntityContent madness!" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [13:01:11] (03CR) 10Daniel Kinzler: "Should probably be done on top of I0550f0b3cc65c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent) [13:03:19] DanielK_WMDE: I did it manually with SQL, and now the result changed: [13:03:24] Now I get "Server responded: SyntaxError: syntax error". [13:03:49] does this make sense? - [13:04:03] site_data='a:1:{s:5:"paths";a:2:{s:9:"file_path";s:28:"http://localhost/wikibase-client-ca/$1";s:9:"page_path";s:31:"http://localhost/wikibase-client-ca/$1";}}' [13:04:13] ? [13:20:07] aharoni: [13:20:08] php > var_export( unserialize( $site_data ) ); [13:20:10] PHP Notice: unserialize(): Error at offset 72 of 148 bytes in php shell code on line 1 [13:20:32] aharoni: use unserialize() to decode the data into an array structure, manipulate that, then use serialize() to create a new blob [13:20:43] as i said, there is currently no nice way to do this... [13:41:01] DanielK_WMDE: it's crazy-ish :) [13:41:12] the "s:28" part must have the length of the following string. [13:41:19] I didn't know about unserialize. [13:41:30] it helped: now the repo sees the clients and I can add sitelinks. [13:42:11] However, if I refresh the pages at the clients, I still don't see the links at the sidebar. [13:42:29] DanielK_WMDE: do I have to push the updates to the clients somehow? [13:43:46] aude ^ I've got a feeling that you'll know the answer. [13:48:08] aharoni: you can use the change dispatcher script in repo (or just purge pages) [13:48:53] aude: where is that script exactly? [13:48:59] action=purge [13:49:03] action=purge doesn't help [13:49:12] in wikibase lib [13:49:35] but if action=purge doesn't work then something might be wrong [13:51:12] aude: hmm. any idea what could it be? [13:51:49] do you have the load balancer stuff configured? [13:52:18] not that I know. [13:52:36] see the example settings in client [13:56:10] aude: does this look like enough configuration? - https://gist.github.com/amire80/7339b2fecbdb74319895 [13:56:30] no [13:56:53] errr, you are using the example settings specifically? [13:57:09] they may need to be adjusted [13:57:32] aude: well, yes. I'm willing to change whatever is needed. [13:57:52] should I just copy everything from ExampleSettings and... change whatever is needed? [13:58:18] (btw, these are all clean new wikis, not what I tried to configure ten days ago) [13:59:06] see the $wgLBFactoryConf section of example settings [14:00:52] aude: the comment says: "In order to access a remote repo using a different database server, LBFactory_Multi must be used. In that case, enabled the block below. If the repo is on the same server, this is not necessary." [14:00:59] I am on the same server, so do I need it? [14:03:23] aharoni: no. [14:03:57] aharoni: on the same server, it should work, but you have to configure the repo's database name explicitly. [14:04:17] per default, it will assue the database name is the same as the site id. [14:04:59] DanielK_WMDE: and how do I configure it? [14:05:25] aharoni: docs/options.wiki :) [14:05:28] let me see... [14:06:15] aharoni: the setting is called repoDatabase [14:06:31] you will probably also have to configure repoNamespaces [14:06:42] look at the Client Settings / Basic Settings. [14:07:35] there's a few more: repoArticlePath and repoScriptPath, for building URLs [14:07:51] DanielK_WMDE: do I have to configure it on the client? I think that I already have it: https://gist.github.com/amire80/7339b2fecbdb74319895 [14:07:58] yes, on the client [14:08:32] yes, that should work [14:08:45] aharoni: do you have error reporting kranked up? is it just failing silently? [14:09:06] error reporting where? on apache? [14:09:31] for php [14:09:39] ...and mediawiki. [14:10:06] https://www.mediawiki.org/wiki/Manual:How_to_debug [14:11:17] aharoni: also, check the wb_items_per_site table on the repo, and check that the site IDs used there correspond to the entries in the sites table on both the repo and the cli9ent [14:12:13] it must correspond to $wgWBClientSettings['siteGlobalID'] = "enwiki"; [14:12:37] DanielK_WMDE: wb_items_per_site looks ok. [14:12:39] but: [14:12:45] hm, you might need the 'namespaces' setting, not sure what that defaulöts to these days [14:13:07] if I try to run dispatchChanges.php, I get the following curious error: [14:13:32] https://gist.github.com/amire80/bed29f421f32a3038804 [14:13:37] aharoni: dispatchChanges only purges the pages on the target wiki. if you do edit/previedw, you should always see the sitelinks. [14:13:45] they get puleld from wb_items_per_site. [14:13:48] "14:03:02 ERROR: exception 'DBConnectionError' with message 'DB connection error: Unknown database 'wikibase' (localhost)' in /home/amire80/dev/wikibase-repo/includes/db/Database.php:918"\ [14:13:58] Unknown database 'wikibase' (localhost)' [14:14:07] why does it search for a database names "wikibase"? [14:14:22] I have no idea - maybe because that's in the default settings? [14:14:22] that must be the error. there's no such database. [14:14:51] DanielK_WMDE: I tried to look for it in ExampleSettings and couldn't find it. [14:14:56] aharoni: check $wgWBRepoSettings['localClientDatabases'] [14:15:20] that would prevent pushing change notifications. [14:15:32] this should not prevent the links from showing after a manual purge [14:15:53] DanielK_WMDE: $wgWBRepoSettings['localClientDatabases'] = array( 'cawiki' => 'wikibase-client-ca', 'enwiki' => 'wikibase-client-en' ); [14:19:53] aharoni: then it should not look for a database called 'wikibase' - unless more client databases are defined elsewhere. [14:19:54] DanielK_WMDE: this part from my client log should be interesting: https://gist.github.com/amire80/95f87cebce34d1d1f492 [14:19:55] anyway... [14:20:17] you could enable the Wikibase\LangLinkHandler debug group: [14:20:42] $wgDebugLogGroups['Wikibase\LangLinkHandler'] = '/some/log/file'; [14:20:49] then do edit/preview [14:20:52] then check the log file [14:22:17] DanielK_WMDE: does https://gist.github.com/amire80/95f87cebce34d1d1f492 point at a possible problem? [14:22:28] I wonder where could that "wikibase" database name be defined. [14:24:11] aharoni: wait... ugh. I think hyphens in wiki ids / DB-names are "magic": they are used to defined table prefixes. [14:24:26] wtf [14:24:32] if you use them in actual database names, strange things may happen [14:25:27] aharoni: wfSplitWikiID is the culprit :) [14:25:45] * aude got kicked off the internet [14:25:56] looks like daniel is helping [14:25:58] though I *thought* this was used only by LBFactory_multi, not the "simple" or "single" LB factory [14:26:07] aude: i'm trying, but it's rather odd. [14:26:13] also, need to wrap some stuff up [14:26:40] i've never setup my client and repo to connect quite this way, but it *should* work [14:26:47] DanielK_WMDE: meh meh meh. [14:27:14] OK, I'll try to reinstall with different database names. [14:27:16] thanks a lot. [14:27:53] for db names, stick with something like 'enwiki' :) [14:28:18] no spaces or hyphens, and if you must, then use underscore [14:32:10] aharoni: try the debug group thingy [14:45:35] (03PS1) 10Daniel Kinzler: (bug #57014) Introducing FormatSnakValue API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97510 [14:45:57] (03Abandoned) 10Daniel Kinzler: (bug #57014) Introducing ApiFormatValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/95278 (owner: 10Daniel Kinzler) [14:57:06] \o/ \o/ \o/ \o/ \o/ kart_ aude DanielK_WMDE - I MADE IT! [14:57:15] took me a few days :) [14:57:24] thanks A LOT for all the help. [14:58:17] now there's one last curiosity: the link appears as "en:Artile name" [14:58:24] I would expect just "Article name" [15:00:22] aharoni: what ;) [15:21:24] * guillom waves at Lydia_WMDE [15:21:34] hey guillom [15:21:41] Tonight, I'm going to the launch of "Libres conseils", the French translation of "Open Advice" :) [15:22:37] Lydia_WMDE: I wasn't sure you knew the whole book had been translated [15:22:57] guillom: ah cool - i did but they didn't do a good job of telling me about that or the party -.- [15:23:26] Lydia_WMDE: I'm planning to grab a copy for you, if they haven't planned to send you one already [15:23:34] guillom: \o/ [15:24:30] Lydia_WMDE: do you know when the new dump with history is available? [15:24:58] lbenedix: nope, sorry [15:25:29] okay [15:25:56] aharoni: populate interwiki table? [15:26:23] Abraham_WMDE: odd I'm still first in this list, since a lot of the stuff is now on GH [15:57:25] aude: sounds reasonable [15:57:50] aude hasharAW - do you happen to know whether there is any beta instance that is a wikidata client? [15:58:00] aharoni: no idea [15:58:32] I know we have http://wikidata.beta.wmflabs.org/ no clue whether there is any data there nor if it is being used [15:59:10] aharoni: should be any beta wikipedia or wikivoyage [15:59:20] probably beta commons too [15:59:54] aharoni: https://test2.wikipedia.org/ ? [16:41:11] aharoni: sorry, i was off for a bit. [16:41:16] np [16:41:22] I got it resolved. [16:41:31] make sure your interwiki table has "en" set as a prefix for your enwiki thingy [16:41:39] ah, good :) [23:08:33] (03PS9) 10Hoo man: Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 [23:15:25] (03CR) 10Hoo man: "Re-add label logic for new item creations only (per Lydia)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [23:53:09] aude: you still awake? [23:58:45] (03PS1) 10Hoo man: Fix RepoLinker for Repos with Items outside of NS 0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/97653 [23:59:11] this one annoyed me during testing long enough :P [23:59:45] aude: ^ [23:59:59] The tests we're testing for the broken behavior :/