[00:47:24] Hey [00:50:44] hi [01:13:30] ohdear [01:14:10] !lastseen Hahc21 [01:14:18] !seen Hahc21 [01:53:03] !list [01:53:28] !seen notconfusing [01:53:47] yes, billy__? [02:43:44] hi [02:48:02] !seen Canada? [02:48:05] No! [02:48:20] It seems to have gone missing. Now America's bald spot is showing... [02:54:08] On an unrelated note, we need vandalism detection systems [03:35:28] !night [03:35:28] Good night, sweet dreams and dream of Wikidata (admins)! [03:35:31] hmm [03:35:34] @trusted [03:35:34] I trust: .*@wikimedia/IWorld (2admin), .*@wikimedia/DangSunM (2admin), .*@quassel\.jefferai\.org (2admin), .*@unaffiliated/jeroendedauw (2admin), .*@wikipedia/Liangent (2trusted), .*@wikimedia/Vogone (2admin), .*@wikipedia/rschen7754 (2admin), .*@wikimedia/Hym411 (2admin), [05:32:48] can we redirect the old channel? [05:37:20] liangent: it already is [05:37:33] once you leave, you can't get back in [05:38:42] rschen7754: hmm right, but why is an "invitation only" message still appearing? [05:39:06] it was also set invite-only... i think that's how the forwarding works [05:40:02] rschen7754: I expect an #english -> ##English style forwarding [05:40:13] rschen7754: or #toolserver -> #wikimedia-toolserver [05:40:23] hmm? [05:40:33] try /join #toolserver [05:41:37] there's no "invite-only" message from #toolserver channel [05:42:56] oh [06:51:15] the old channel has been decommissioned / [06:51:21] ? [07:34:56] http://ultimategerardm.blogspot.sk/2013/11/ask-and-it-will-be-given-to-you.html [07:35:11] this Ask thing .... when will we get this ??? [07:35:13] PLEASE [07:39:19] GerardM-: hi. [07:40:21] GerardM-: it looks like a question for a Wikidata forum, such as a village pump or whatever they use instead. [07:40:37] THEY want it implemented [07:41:01] is what I got from Jeroen de Dauw [07:43:13] OK. Please idle then, as I am out of the loop. [07:47:40] gry [07:48:02] when you read it, you do agree do you ... you want it too right ? [07:48:26] I don't know. [D what it is [07:49:05] Read the URL I posted [07:50:28] I don't think it has a link which describes what 'Ask 1.0' is. [07:50:43] there is a link to Ask in there [07:50:47] click it [07:51:04] Ah. It is black, until I move mouse over, so I didn't see it. [07:51:33] https://meta.wikimedia.org/wiki/Grants:IEG/Wikidata_Toolkit is also related. [07:52:17] If Ask 1.0 is better, there's a question why it's separate from another 'version' rather than being added in upstream. [07:52:34] The description looks useful, while I'd need a demo to shape an opinion. [07:52:38] ask is useful as a tool to include data on a Wiki [07:52:59] I have used it using Semantic MediaWiki [07:53:33] it does query but its results are published as text in an article [07:54:13] I wouldn't expect my feedback to be useful: I don't know what SMW is, what it does. I've bookmarked and I will read more at a point. [07:57:29] gry https://semantic-mediawiki.org/wiki/Ask [07:57:41] it explains how it is used [08:04:25] if you really want to get this added to production instance of wikidata then you should be asking their community on-wiki as that's about the only place where a formal consencus can be reached [08:05:21] please don't try to make me focus on this, I only use wikidata for interwiki, weakly know its architecture, and merely started talking here to suggest asking on-wiki and waiting; I didn't expect to learn all this stuff right now [08:13:13] Abraham_WMDE: ping [09:07:20] (03PS6) 10Henning Snater: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 [09:07:25] (03CR) 10jenkins-bot: [V: 04-1] Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [09:09:53] (03PS7) 10Henning Snater: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 [09:29:11] http://ultimategerardm.blogspot.sk/2013/11/ask-and-it-will-be-given-to-you-ii.html [09:57:54] (03PS1) 10Shirayuki: Fix double-space [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 [10:04:05] (03CR) 10Aude: [C: 032] Fix double-space [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [10:07:27] (03CR) 10jenkins-bot: [V: 04-1] Fix double-space [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [10:09:27] (03CR) 10Shirayuki: "Something wrong?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [10:09:44] yay [10:09:49] more people in here than in the old channel [10:10:43] (03CR) 10Aude: "nothing wrong except unrelated tests failing (https://gerrit.wikimedia.org/r/#/c/95855/ needs to be approved)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [10:16:09] what 'old channel' are people speaking of? was there a recent move? [10:16:37] we were in #wikimedia-wikidata [10:17:20] oh, that's pretty new. I didn't even know that channel existed. [10:37:23] Barras2: can you please kick the remaining people from #wikimedia-wikidata? [10:37:33] there are still quite a few people missing here [10:37:37] that's not so cool [10:37:41] lol [10:38:39] Lydia_WMDE: i have local ops, though i dunno if i can [10:38:52] rschen7754: would be cool if you could try :) [10:45:42] um, nobody's rejoining... [10:46:52] there we go [10:47:06] Finally. [10:47:07] was there any particular reason for the sudden change of name? [10:47:28] (just curious, this is obviously superior for being shorter :P) [10:47:54] * FastLizard4 smacks rschen7754 [10:48:00] lol [10:48:47] rschen7754: <3 [10:48:53] James_F: :D [10:48:53] thx [10:49:13] now Barras2 is in a channel by himself [10:49:25] poor Barras2 [10:55:43] awwww, i was kicked out of the old channel :( [10:55:48] lol [10:56:09] * aude has to be forced out :) [10:56:22] i kicked myself from the channel :P [10:56:30] heh [10:57:37] * nikki ran away at the last moment [11:07:20] hashar: ping [11:11:52] aude: more or less, expect packets loss [11:12:30] ? [11:12:33] :) [11:13:23] i would like to test / try changes to extensions-list on beta and run mergeMessageFileList.php [11:13:57] do you know when localisation cache rebuild gets run? [11:16:54] aude: on every code update iirc [11:16:59] so every ~ 6 minutes [11:17:01] ok, so every 6 min [11:17:15] aka via https://integration.wikimedia.org/ci/job/beta-code-update/ [11:17:20] annnd it is failing rightnow [11:17:20] if i run merge messages, it might break something for 6 min [11:17:27] because of parsoid? [11:17:38] then it won't break [11:17:40] 11:15:38 Unable to checkout '92b1b77deb559277b2ade519c62cb86aecccbc7c' in submodule path 'Parsoid' [11:17:40] 11:15:38 INFO:mwext:Exit code: 1 [11:17:41] :( [11:17:46] wtf? [11:18:47] that commit iso the HEAD of Parsoid at least [11:19:03] 11:14:51 error: Your local changes to the following files would be overwritten by checkout: [11:19:04] 11:14:51 php/ParsoidCacheUpdateJob.php [11:19:05] 11:14:51 Please, commit your changes or stash them before you can switch branches. [11:19:06] 11:14:51 Aborting [11:19:07] :( [11:19:52] it looks to me it might not be total failure [11:20:00] not sure [11:20:17] 09:33:41 Updating ExtensionMessages-master.php...No entry for terminal type "unknown"; [11:21:44] yeah that one I am not sure where it comes from [11:21:51] some shell script expecting a terminal set maybe [11:22:00] 11:21:54 INFO:main:Executions completed [0, 0, 0, 0, 0] [11:22:01] 11:21:54 INFO:main:Final exit code: 0 [11:22:01] 11:21:55 Finished: SUCCESS [11:22:02] \O/ [11:22:05] :) [11:22:11] I need to make that [0,0,0,0,0] more verbose [11:22:21] they are the exit code for each of the stages [11:22:42] alright, so is there a good time for me to try merge messages? or anytime is good? [11:23:08] it might not cause any problems [11:24:39] depends [11:24:51] if it is only for labs, anytime is fine [11:24:56] only for beta [11:25:27] ah ./wmf-config/extension-list-labs [11:25:38] we want to enable a "single git repo" with submodules for beta wikidata [11:25:49] rather than have all our stuff spread out [11:26:14] could have kept everything in the same git repo :D [11:26:19] :D [11:26:30] go ahead and play with extension-list-labs [11:26:33] ok [11:26:37] doesn't seem to cause any trouble with production [11:26:47] i can make a backup of ExtensionMessages-master.php [11:26:48] also please please ping Reedy / Ryan lane about it [11:26:52] yeah [11:27:01] that might impact git-deploy which doesn't support submodules in submodules iirc [11:27:07] and Sam want to know anyway [11:27:11] yep [11:27:20] of course if you have something on beta, that is a nice proof of concept [11:27:27] i think submodules in git-deploy is considered a requirement [11:27:33] before it's ready and ryan is aware [11:28:15] I just wanna make sure you make sure it is going to be implemented :] [11:28:37] yep [11:29:03] we already have one submodule in wikibase and thing some other extensions have such thing [11:29:09] think* [11:29:28] probably [11:29:39] Geshi_SyntaxHighligthning probably has [11:29:57] getting started extension is one [11:32:02] hmmm, i can even put output of merge messages some place else and not overwrite the actual one used [11:44:15] (03CR) 10Siebrand: [C: 031] "Trivial L10n/i18n changes." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [11:51:58] Finally Rschen7754 did kick in old channel [11:52:06] :p [11:52:19] *kicked [12:04:27] (03PS2) 10Jens Ohlig: Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 [12:06:43] is there a place where you can experiment with ask ???? [12:07:09] (03CR) 10jenkins-bot: [V: 04-1] Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [12:24:36] (03CR) 10Addshore: [C: 04-1] Refactored Wikibase Lua library code to make everything testable. (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [12:25:50] GerardM-: not currently, unless you go try the SMW version out [12:26:19] rschen7754: why not redirect the old channel here? :P [12:27:28] addshore for a long time I had Semantic Mediawiki running locally on a laptop [12:29:20] (03PS3) 10Jens Ohlig: Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 [12:29:42] Lydia_WMDE: do you have a few minuts to help me prioritize some things? [12:32:04] (03CR) 10jenkins-bot: [V: 04-1] Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [12:41:48] DanielK_WMDE: they are at lunch [= [12:42:11] addshore: yea, wrote an email [12:48:19] morning hashar [= [12:51:07] (03CR) 10Daniel Kinzler: "@tobi: huh, yea, i see that too now. why didn't i see this originally? odd. it's just a typo. will try to make a test case." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [13:08:11] [travis-ci] wmde/AskSerialization#7 (master - a64fa50 : jeroendedauw): The build has errored. [13:08:12] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/a2a91271476e...a64fa5051862 [13:08:12] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/14138375 [13:26:39] (03CR) 10Addshore: [C: 032] Cleanup in WikiPageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95707 (owner: 10Aude) [13:27:47] (03CR) 10Addshore: [C: 04-1] Store serialized entity in parser output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [13:29:58] (03CR) 10jenkins-bot: [V: 04-1] Cleanup in WikiPageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95707 (owner: 10Aude) [13:30:41] * aude rage [13:30:51] ahh neeed https://gerrit.wikimedia.org/r/#/c/95855/5 [13:30:54] (03PS6) 10Addshore: Ensure mPreparedEdit in WikiPage gets cleared if set. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95855 (owner: 10Aude) [13:30:58] maybe? [13:31:01] :) [13:31:07] that would help [13:32:08] (03CR) 10Aude: Store serialized entity in parser output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [13:33:59] (03CR) 10Addshore: [C: 032] Ensure mPreparedEdit in WikiPage gets cleared if set. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95855 (owner: 10Aude) [13:34:07] aude, addshore: i'm seeing a bunch of errors when running tests on master, e.g. this one: [13:34:16] 1) Wikibase\Test\Api\RemoveReferencesTest::testRequests [13:34:17] UsageException: Could not find the claim [13:34:20] you probably need what I have just merged above [13:34:24] oh wait... [13:34:47] same thing [13:34:50] merged what where? [13:34:56] https://gerrit.wikimedia.org/r/95855 [13:35:02] DanielK_WMDE: hey :) back now - will look at mail [13:35:02] my patch fixes everything! [13:35:50] essentially restoring previous behavior [13:35:50] (03PS2) 10Addshore: Cleanup in WikiPageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95707 (owner: 10Aude) [13:35:56] (03CR) 10Addshore: [C: 032] Cleanup in WikiPageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95707 (owner: 10Aude) [13:35:59] Lydia_WMDE: great :) working on (bug #56903) Introducing EntityInfoBuilder [13:36:24] (03PS6) 10Aude: Store serialized entity in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [13:36:57] aude, addshore: let me know when you guys have fixed master :) [13:37:09] soon as jenkins merges [13:37:17] it has merged [13:37:22] i'll just push my change, since i didn't see any related errors. [13:37:24] ok then stuff is fixed [13:37:45] (03PS6) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [13:38:09] got a bit bloated with changes to MockRepository for easier testing. [13:38:14] could split that off, if need be. [13:41:40] Lydia_WMDE: also JSON vor Quantities? ok... [13:42:00] (03Merged) 10jenkins-bot: Cleanup in WikiPageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95707 (owner: 10Aude) [13:42:06] DanielK_WMDE: as you get to it... what doesn't get done before your vacation doesn't get done [13:42:16] ooooh, vacation :) [13:43:50] gragagh the internet is so slow [13:43:55] it is! [13:44:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1223 (master - be4a69f : aude): The build was fixed. [13:44:04] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/37d94f66b763...be4a69f723f2 [13:44:04] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14139388 [13:44:04] * aude should get out my usb stick [13:44:12] \o/ [13:50:51] aude would https://gerrit.wikimedia.org/r/#/c/89792/6 make our loading issue bigger or not change it? :P [13:51:19] wait *just remembered the cause of the loading issue*, this will barely make any change at all :D [13:51:20] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1224 (master - da5ccdc : aude): The build was fixed. [13:51:20] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/be4a69f723f2...da5ccdc99c02 [13:51:20] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/14139669 [13:52:18] addshore: i think it needs follow up [13:52:43] to make use of stuff in parser output (and use parser cache), instead of doing stuff in output page [13:52:52] (03PS4) 10Addshore: Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [13:53:12] (03PS2) 10Addshore: Fix double-space [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [13:53:15] (03PS7) 10Addshore: Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [13:57:55] (03CR) 10Addshore: [C: 031] Refactored Wikibase Lua library code to make everything testable. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [13:58:39] (03CR) 10Addshore: [C: 032] Fix double-space [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [14:02:57] (03Merged) 10jenkins-bot: Fix double-space [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [14:07:17] (03CR) 10Shirayuki: "Thanks" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96004 (owner: 10Shirayuki) [14:13:24] (03Abandoned) 10Jens Ohlig: (bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted Patch set 3: Oops, I meant to reformat it like this. Patch set 4: ... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [14:35:36] (03PS1) 10Daniel Kinzler: Make dumpJson log to stderr. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96026 [14:36:44] (03PS2) 10Daniel Kinzler: Make dumpJson log to stderr. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96026 [14:38:39] addshore: Tobi_WMDE: not sure what I was thinking with this commit - also got merged without review - perhaps I was confusing repos or something [14:38:47] Please merge the revert https://github.com/wmde/WikibaseDatabase/pull/8 [14:40:42] (03PS1) 10Daniel Kinzler: Fix bad dumpJson output when skipping entities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96027 [14:43:07] [travis-ci] wmde/WikibaseDatabase#30 (revertautoloadcommit - ffe7088 : jeroendedauw): The build passed. [14:43:07] [travis-ci] Change view : https://github.com/wmde/WikibaseDatabase/commit/ffe7088f4f15 [14:43:07] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDatabase/builds/14142200 [14:43:23] Tobi_WMDE, Lydia_WMDE: two new (sub)items for the board, blockign the JSON dumps: [14:43:29] https://gerrit.wikimedia.org/r/96026 [14:43:34] https://gerrit.wikimedia.org/r/96027 [14:43:37] these need review [14:45:33] DanielK_WMDE: ok [14:49:40] aude: data and log output can now both be controlled with cli options: --output (default: stdout) and --log (default: etderr) [14:49:47] *stderr [14:50:28] ok [15:33:46] hi [15:36:34] (03CR) 10Addshore: [C: 04-1] "I'm not sure if this is perfect from a usability point of view." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95832 (owner: 10Lbenedix) [15:51:06] (03PS8) 10Addshore: Keeping track of claim index in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90507 (owner: 10Henning Snater) [15:51:13] (03PS7) 10Addshore: Implemented "movetoolbar" for claimviews in claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 (owner: 10Henning Snater) [16:14:32] (03CR) 10Addshore: [C: 032 V: 032] Add .gitreview and .gitignore [extensions/DataValuesInterfaces] - 10https://gerrit.wikimedia.org/r/88659 (owner: 10Reedy) [16:14:33] (03CR) 10Addshore: [C: 032 V: 032] Add .gitreview and .gitignore [extensions/DataValuesInterfaces] - 10https://gerrit.wikimedia.org/r/88659 (owner: 10Reedy) [16:21:17] addshore: so should i go ahead and split the datavalues repo up? are we using data values interfaces etc. ? [16:21:43] perhaps we should make sure we have the list of what we are splitting them into before we make the split :D [16:21:45] Lydia_WMDE: ^^ [16:22:10] on thursday, i was just going to split the stuff in DataValues/ValueView into ValueView etc. [16:22:16] including javascript [16:23:03] aude: addshore: a list does sound good, yes [16:23:09] (03CR) 10Jeroen De Dauw: "Looks generally good. One small thing to clean up though." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90507 (owner: 10Henning Snater) [16:23:29] well, DataValues has 4 subdirectories [16:23:47] i was going to strictly split by subdirectory [16:23:55] after that don't know how to proceed [16:24:00] or if we still want to do that [16:25:02] ok, better channel [16:25:05] aude, JeroenDeDauw: so, I'm wondering how to best "hack" the PropertyDataTypeLookup into SnakSerializer. My current approach, injecting via the SerializationOptions and warning if it's missing, causes a lot of pain. [16:25:22] i don't see a good solution with the current code structure [16:25:57] i can see two options: 1) don't complain if the lookup isn't there, but keep the injection-via-options. 2) use global state to grab the lookup, so it's always there. [16:26:54] what we would ideally want is a single SerializerFactory that comes from WikibaseRepo and knows the DataTypeLookup, and can then be used to create SnakSerializers. [16:27:07] * aude nods [16:27:22] but that requires us to touch a lot of files, and the architecture of the factory should be re-thought first [16:27:23] both sound like evil options [16:28:14] so, what to do? postpone until we have redesigned the serialization stack? [16:28:20] (03CR) 10Jeroen De Dauw: [C: 032] "This strikes me as a bug resulting from having to a to big method" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96027 (owner: 10Daniel Kinzler) [16:28:21] not good... [16:28:30] also evil [16:28:37] you pick [16:28:48] hehe... [16:35:25] DanielK_WMDE_: I think I already wrote some stuff about this down before you started working on this [16:35:51] Not sure in which mail at this point, quite some time ago by now [16:36:44] DanielK_WMDE_: to be clear, you are talking about this change right? https://gerrit.wikimedia.org/r/#/c/89852/ [16:37:11] DanielK_WMDE_: are you thinking of abandoning this and doing something else? Or what? [16:38:39] aand the move is successful [16:38:51] JeroenDeDauw: yes, i'm planning to abandon it in favor of a simpler but hacky solution. [16:39:13] the current approach just causes too much fallout. [16:39:28] JeroenDeDauw: we discussed this before, but i wasn't aware you wrote about it anywhere. [16:40:11] eventually, all the places that directly instantiate Serializers (or a SerializerFactory) need to be replaced by injection code. [16:40:18] but that's quite a bit of work.. [16:40:35] addshore: can you have a look at https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikibase-item-summary-wbmergeitems-to/en_(2) please? [16:40:43] well, i kind of started this with my current patch, but only kind of half way [16:43:28] addshore: and another one: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikibase-item-summary-wbeditentity-override/en [16:43:43] what about Wikibase-item-summary-wbmergeitems-from ? :P [16:44:33] DanielK_WMDE_: and one for you: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Valueformatters-desc/nb :) [16:47:46] (03PS1) 10Addshore: Remove i18n wbsetstatementrank for removed module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96049 [16:49:57] nb? [16:50:22] oh, that one is ancient [16:53:43] (03PS1) 10Addshore: Add i18n qqq for wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96050 [16:56:19] (03PS1) 10Addshore: Add extra context to i18n wbeditentity-override [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96052 [16:56:22] DanielK_WMDE_: what I wrote before basically is that in this case attemtpting to use dependency injection will not work out nicely, as the code is to broken to begin with [16:56:23] aude: Lydia_WMDE see what you think ^^ [16:56:27] (03CR) 10Aude: [C: 032] Remove i18n wbsetstatementrank for removed module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96049 (owner: 10Addshore) [16:56:33] * aude thinks it's good [16:56:38] DanielK_WMDE_: And that we either should rewrite the serialization stuff first or use a hack [16:57:03] DanielK_WMDE_: I'll have a look at this stuff again now [16:57:11] JeroenDeDauw: yes. so i'm working on the hack. and asked which one to use. [16:57:21] i'm currently going for option 1, with some modifications. [16:57:31] addshore: looks good :) [16:57:32] basically, the lookup service is an optional parameter to SnakSerializer. [16:57:47] ClaimSerializer and ReferenceSerializer will both require a SnakSerializer to be injected [16:58:06] (03CR) 10Aude: [C: 032] Add i18n qqq for wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96050 (owner: 10Addshore) [16:58:25] SerializerFactory can optionally have a data type lookup, for injection into new SnakSerializers# [16:58:30] that should do for now. [16:58:50] (03CR) 10Aude: [C: 032] Add extra context to i18n wbeditentity-override [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96052 (owner: 10Addshore) [16:59:00] i'm off to fix dinner soon, but should be back by 21:00, and plan to work late [16:59:15] DanielK_WMDE_: you are saying you are rewriting the serialization code altogether and fixing its design issues? [16:59:54] aude: once those are merged I am going to clean i18n up a bit more [17:00:01] (03CR) 10Lbenedix: "It uses the LanguageCode but it asks for the "Language"." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95832 (owner: 10Lbenedix) [17:00:07] addshore: ok :) [17:00:30] JeroenDeDauw: no, i'm adding optional parameters to a couple of classes, and leaving the design issues for later. [17:00:35] addshore: helps sometimes to have a native english speaker go through the messages and cleanup [17:00:45] :d [17:00:46] some of them are difficult to understand [17:00:48] :d [17:00:50] :dDDD [17:01:03] JeroenDeDauw: the alternative is a completely local hack using global state, but that would give us too lottle control for reliable testing [17:01:22] Lydia_WMDE: uh... i'm sure i had an account on twn at some point... [17:01:42] (03CR) 10Addshore: "We indeed need something in between the two, that uses language and language codes but with the nice javascriptiness of the site selector." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95832 (owner: 10Lbenedix) [17:01:45] DanielK_WMDE_: :D i can comment for you if you tell me what [17:03:11] Lydia_WMDE: i'm not sure i understand the actual problem :) [17:03:42] DanielK_WMDE_: formatter is used as a noun but that is awkward in some languages apparently [17:03:53] instead of as a verb [17:04:04] Lydia_WMDE: This message is the description of the ValueFormatters extension as a whole. [17:04:13] aude: I think we should set our dev / test instances up using anisble :D [17:04:21] just a random thought ;p [17:04:27] heh [17:04:29] DanielK_WMDE_: yeah.... john... ;-) [17:04:29] Lydia_WMDE: it's an extension for formatting values. *shrug* [17:04:40] then we could all easily poke them ;p [17:04:59] DanielK_WMDE_: in that case I'm not sure what this "option 1" is you mentioned. What does this refer to? [17:05:44] [17:25] i can see two options: 1) don't complain if the lookup isn't there, but keep the injection-via-options. 2) use global state to grab the lookup, so it's always there. [17:05:45] [17:26] what we would ideally want is a single SerializerFactory that comes from WikibaseRepo and knows the DataTypeLookup, and can then be used to create SnakSerializers. [17:05:49] gotta go now, bbl [17:06:07] DanielK_WMDE_: though yeah, a completely local hack using globa state would be good if this can be done. And if not, keep it as local as possible [17:06:18] (03Merged) 10jenkins-bot: Remove i18n wbsetstatementrank for removed module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96049 (owner: 10Addshore) [17:06:57] DanielK_WMDE_: If the change is local, it will not affect the rewrite of the component much, even if it adds another issue to the pile [17:08:19] DanielK_WMDE_: so to rephrase my opinion here: please do the simplest thing that will work for us and does not cuase non-local design issues [17:08:42] (03Merged) 10jenkins-bot: Add i18n qqq for wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96050 (owner: 10Addshore) [17:09:23] (03PS1) 10Addshore: Cleanup i18n file headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96054 [17:09:39] aude: ^^ xD [17:10:27] addshore: please refrain from doing not critical cleanup in DataValues - this has already happened in the fork, and will cause headache if it now also happens in the original [17:10:49] O_o where have I done non critical cleanup in DavaValues? [17:10:50] JeroenDeDauw: ? [17:11:01] (03CR) 10Aude: [C: 032] Cleanup i18n file headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96054 (owner: 10Addshore) [17:11:16] JeroenDeDauw: I dont think I have ever even touched the repo :P{ [17:11:34] addshore: you have not. I'm pointing this out preemtivly [17:11:42] haha! [17:11:47] So we do not end up with wasted effort [17:11:52] no, Im fixing the Wikibase i18n files :P [17:11:56] (03Merged) 10jenkins-bot: Add extra context to i18n wbeditentity-override [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96052 (owner: 10Addshore) [17:12:00] addshore: and you are the only one I'd expect to randomly go clean up stuff there [17:12:18] aude: ?? [17:12:37] JeroenDeDauw: what critical cleanpu? [17:12:40] cleanup* [17:12:53] aude: there is none, think you are misreading what I said [17:13:11] no i am not, but you already answered addshore [17:13:25] JeroenDeDauw: accusing me of things I havn't done yet ;p [17:13:30] hah [17:15:01] addshore: yeah, you have been trialed and found guilty of doing usefull things during the next week. Your sentance is a chocolate from the review box [17:15:21] addshore: alternatively you can bail yourself out by sending me 0.01 BTC [17:15:46] can I pass GO and collect 200 euros first? :d [17:16:03] (03Merged) 10jenkins-bot: Cleanup i18n file headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96054 (owner: 10Addshore) [17:18:17] ergh the i18n hurts my head [17:20:13] * aude rage [17:20:18] aude: you know...you can deploy the grrrit-wm changes yourself? [17:20:27] ugh: i can't merge them [17:20:35] Errrr [17:20:37] thats stupid. [17:20:43] agree [17:21:00] and then i need to look how to deploy them [17:21:05] let me see if I can fix it. [17:21:09] * aude can restart the bot [17:21:13] ok [17:23:36] aude: ok, I think you should be able to submit changes now. [17:23:43] ok [17:24:03] I just gave the extension-Wikibase group +2 rights >.> [17:24:45] it would be cool if it could just the ldap group [17:25:06] no idea if/how [17:35:56] (03PS3) 10Aude: (bug 57015) Make dumpJson log to stderr. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96026 (owner: 10Daniel Kinzler) [17:36:37] (03CR) 10Aude: [C: 032] "fixed typo in patchset #3, otherwise looks fine, tested" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96026 (owner: 10Daniel Kinzler) [17:41:15] (03Merged) 10jenkins-bot: (bug 57015) Make dumpJson log to stderr. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96026 (owner: 10Daniel Kinzler) [17:52:45] (03PS14) 10Addshore: Refactor Api Output to use ResultBuilder Pt1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [17:52:51] (03PS6) 10Addshore: Cleanup GetEntities ItemByTitleHelper and others [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 [17:52:57] (03PS6) 10Addshore: Cleanup of ClaimModificationHelper and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95125 [17:53:05] (03PS3) 10Addshore: Allow id and type params in wbeditentity data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [17:53:06]