[13:33:31] <wikibugs>	 (CR) Yaron Koren: [C: +1] show on select does not expand templates [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[13:39:01] <wikibugs>	 (CR) jerkins-bot: [V: -1] show on select does not expand templates [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[15:25:43] <wikibugs>	 (PS2) Anjali041: show on select does not expand templates [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638)
[16:16:02] <wikibugs>	 (PS2) Yaron Koren: Fix for 5a630b032598 - fix SMW handling in CreateClass [extensions/PageForms] - https://gerrit.wikimedia.org/r/682643 (https://phabricator.wikimedia.org/T280994)
[16:28:22] <wikibugs>	 (CR) Yaron Koren: [C: +2] Fix for 5a630b032598 - fix SMW handling in CreateClass [extensions/PageForms] - https://gerrit.wikimedia.org/r/682643 (https://phabricator.wikimedia.org/T280994) (owner: Yaron Koren)
[16:32:45] <wikibugs>	 (Merged) jenkins-bot: Fix for 5a630b032598 - fix SMW handling in CreateClass [extensions/PageForms] - https://gerrit.wikimedia.org/r/682643 (https://phabricator.wikimedia.org/T280994) (owner: Yaron Koren)
[17:05:34] <wikibugs>	 (PS2) Yaron Koren: Fix handling of blank values in #template_display [extensions/PageForms] - https://gerrit.wikimedia.org/r/682644
[17:22:56] <wikibugs>	 (CR) Yaron Koren: [C: +2] Fix handling of blank values in #template_display [extensions/PageForms] - https://gerrit.wikimedia.org/r/682644 (owner: Yaron Koren)
[17:27:58] <wikibugs>	 (CR) Anjali041: "recheck" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[17:42:16] <wikibugs>	 (CR) Yaron Koren: "This patch looks good now - but the commit message should be better: it should say what the patch does, not what the problem is." [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[17:44:11] <wikibugs>	 (Merged) jenkins-bot: Fix handling of blank values in #template_display [extensions/PageForms] - https://gerrit.wikimedia.org/r/682644 (owner: Yaron Koren)
[18:01:16] <wikibugs>	 (PS2) Yaron Koren: Improve linking in #template_display [extensions/PageForms] - https://gerrit.wikimedia.org/r/682709
[18:08:16] <wikibugs>	 (PS3) Anjali041: Make the show on select parameter expand the templates and match with identifiers when passed over. [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638)
[18:11:55] <wikibugs>	 (CR) Yaron Koren: [C: +2] Improve linking in #template_display [extensions/PageForms] - https://gerrit.wikimedia.org/r/682709 (owner: Yaron Koren)
[18:12:19] <wikibugs>	 (CR) Anjali041: "> Patch Set 2:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[18:16:30] <wikibugs>	 (CR) Yaron Koren: "The commit message is more accurate now, but too long! Around 70 characters should be the limit." [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[18:19:23] <wikibugs>	 (PS4) Anjali041: Make the show on select parameter expand the templates. [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638)
[18:23:28] <wikibugs>	 (CR) Anjali041: "> Patch Set 3:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[18:24:25] <wikibugs>	 (CR) Yaron Koren: "Okay, good enough (although it could be a little clearer - it's not clear what "the templates" means). And actually, looking again now at " [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[18:36:29] <wikibugs>	 (CR) Anjali041: "> Patch Set 4:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[18:45:53] <wikibugs>	 (CR) Anjali041: "I understood the approach. I will amend the patch." [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[18:55:56] <wikibugs>	 (Merged) jenkins-bot: Improve linking in #template_display [extensions/PageForms] - https://gerrit.wikimedia.org/r/682709 (owner: Yaron Koren)
[19:21:19] <wikibugs>	 (PS5) Anjali041: Make the show on select parameter match identifiers when passed over. [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638)
[19:30:09] <wikibugs>	 (CR) Yaron Koren: "The code looks great now (I'm glad you were able to simplify it), but I have to say the commit message makes even less sense now. What are" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[19:41:25] <wikibugs>	 (PS6) Anjali041: Make show on select parameter expand templates to be fully-formed in JS. [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638)
[19:43:00] <wikibugs>	 (CR) Anjali041: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[20:45:45] <wikibugs>	 (CR) Yaron Koren: "What do you mean by "JS" - JavaScript? This is all in PHP." [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[20:47:09] <wikibugs>	 (CR) Yaron Koren: [C: +2] "Oh... now I get it. This data is being "passed over" from PHP to JS. Fine - good enough! Thank you for all your effort on this." [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[21:00:27] <wikibugs>	 (Merged) jenkins-bot: Make show on select parameter expand templates to be fully-formed in JS. [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[21:05:10] <wikibugs>	 (CR) Anjali041: "> Patch Set 6: Code-Review+2" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682324 (https://phabricator.wikimedia.org/T217638) (owner: Anjali041)
[21:37:18] <wikibugs>	 (PS2) Yaron Koren: Replace deprecated "error", "warning" CSS classes [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766)
[21:43:38] <wikibugs>	 (CR) Yaron Koren: [C: +2] Replace deprecated "error", "warning" CSS classes [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766) (owner: Yaron Koren)
[21:47:16] <wikibugs>	 (CR) Jdlrobson: Replace deprecated "error", "warning" CSS classes (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766) (owner: Yaron Koren)
[21:52:18] <wikibugs>	 (CR) Yaron Koren: [C: -1] Replace deprecated "error", "warning" CSS classes [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766) (owner: Yaron Koren)
[22:03:01] <wikibugs>	 (CR) Yaron Koren: [C: +2] "@Jdlrobson - that sounds like a good idea, but not for this patch - Page Forms still supports MW 1.30, and Html::errorBox() et al. were on" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766) (owner: Yaron Koren)
[22:25:02] <wikibugs>	 (Merged) jenkins-bot: Replace deprecated "error", "warning" CSS classes [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766) (owner: Yaron Koren)
[22:53:58] <wikibugs>	 (CR) Jdlrobson: "> Patch Set 2: Code-Review+2" [extensions/PageForms] - https://gerrit.wikimedia.org/r/682715 (https://phabricator.wikimedia.org/T280766) (owner: Yaron Koren)