[00:45:43] <wikibugs>	 (PS2) Yaron Koren: Fix for 1653865680fb [extensions/PageForms] - https://gerrit.wikimedia.org/r/678091
[00:52:24] <wikibugs>	 (CR) Yaron Koren: [C: +2] Fix for 1653865680fb [extensions/PageForms] - https://gerrit.wikimedia.org/r/678091 (owner: Yaron Koren)
[00:56:29] <wikibugs>	 (Merged) jenkins-bot: Fix for 1653865680fb [extensions/PageForms] - https://gerrit.wikimedia.org/r/678091 (owner: Yaron Koren)
[01:07:40] <wikibugs>	 (CR) Yaron Koren: "@Palak199 - how did you test this? There was a bug in the code." [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199)
[10:34:50] <wikibugs>	 (CR) Palak199: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199)
[12:13:30] <wikibugs>	 (CR) Yaron Koren: ""It didn't seem to break anything" is not a very good test of code. :) The relevant page where this link is being added is Special:CargoTa" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199)
[14:02:16] <wikibugs>	 (PS2) Yaron Koren: Fix for 97ef7b5277c1 - change broke multiple-instance templates [extensions/PageForms] - https://gerrit.wikimedia.org/r/678097
[14:03:21] <wikibugs>	 (CR) Yaron Koren: "@Yashvarshney02 - could you explain why you changed line 1741 of PF_FormPrinter.php (to "elseif ( empty( $tif->getFields() ) == false )")?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/676573 (owner: Yashvarshney02)
[14:20:01] <wikibugs>	 (CR) Yaron Koren: [C: +2] Fix for 97ef7b5277c1 - change broke multiple-instance templates [extensions/PageForms] - https://gerrit.wikimedia.org/r/678097 (owner: Yaron Koren)
[14:24:08] <wikibugs>	 (Merged) jenkins-bot: Fix for 97ef7b5277c1 - change broke multiple-instance templates [extensions/PageForms] - https://gerrit.wikimedia.org/r/678097 (owner: Yaron Koren)
[14:34:12] <wikibugs>	 (CR) Yashvarshney02: "> Patch Set 12:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/676573 (owner: Yashvarshney02)
[14:37:49] <wikibugs>	 (CR) Yaron Koren: "Hi - the problem with this condition is not with "display=table", it's when there is no display set. You don't have to set "display=" for " [extensions/PageForms] - https://gerrit.wikimedia.org/r/676573 (owner: Yashvarshney02)
[15:17:00] <wikibugs>	 (CR) Yashvarshney02: "> Patch Set 12:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/676573 (owner: Yashvarshney02)
[15:58:18] <wikibugs>	 (PS2) Yaron Koren: Fix for d29c9f37d23d - caused infinite loop for some query string vals [extensions/PageForms] - https://gerrit.wikimedia.org/r/678098 (https://phabricator.wikimedia.org/T278947)
[16:09:34] <wikibugs>	 (CR) Yaron Koren: [C: +2] Fix for d29c9f37d23d - caused infinite loop for some query string vals [extensions/PageForms] - https://gerrit.wikimedia.org/r/678098 (https://phabricator.wikimedia.org/T278947) (owner: Yaron Koren)
[16:14:03] <wikibugs>	 (Merged) jenkins-bot: Fix for d29c9f37d23d - caused infinite loop for some query string vals [extensions/PageForms] - https://gerrit.wikimedia.org/r/678098 (https://phabricator.wikimedia.org/T278947) (owner: Yaron Koren)
[16:21:43] <wikibugs>	 (CR) Yaron Koren: "Sorry, I don't understand what you meant. I already reverted that one line - as far as I know, form printing works correctly again now. If" [extensions/PageForms] - https://gerrit.wikimedia.org/r/676573 (owner: Yashvarshney02)
[16:23:29] <wikibugs>	 (CR) Yashvarshney02: "> Patch Set 12:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/676573 (owner: Yashvarshney02)
[16:43:30] <wikibugs>	 (CR) Palak199: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199)
[16:51:10] <wikibugs>	 (CR) Yaron Koren: "Go to Special:CargoTables, and see if it looks correct." [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199)