[12:58:19] (PS3) Yaron Koren: Replace:: Linker::linkKnown with linkRenderer [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [13:02:59] (CR) jerkins-bot: [V: -1] Replace:: Linker::linkKnown with linkRenderer [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [13:06:51] (PS2) Yaron Koren: Fix over-setting of "delimiter" in generated #template_params call [extensions/PageForms] - https://gerrit.wikimedia.org/r/677391 [13:15:45] (CR) Yaron Koren: [C: +2] Fix over-setting of "delimiter" in generated #template_params call [extensions/PageForms] - https://gerrit.wikimedia.org/r/677391 (owner: Yaron Koren) [13:19:48] (Merged) jenkins-bot: Fix over-setting of "delimiter" in generated #template_params call [extensions/PageForms] - https://gerrit.wikimedia.org/r/677391 (owner: Yaron Koren) [13:24:45] (PS4) Palak199: Replace:: Linker::linkKnown with linkRenderer [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) [13:30:05] (CR) Yaron Koren: "Cool, this looks good now. Have you tested this code in any way?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [13:40:27] (CR) Palak199: "> Patch Set 4:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [13:50:33] (CR) Yaron Koren: "Well, that's just a formatting thing, or something. I mean actually seeing whether the link really gets displayed with this code." [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [13:53:45] (CR) Palak199: "> Patch Set 4:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [13:57:30] (CR) Yaron Koren: "Well, this code gets called in Cargo's Special:CargoTables page, so you could install the Cargo extension and see if it still works. Or ju" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [15:56:52] (CR) Palak199: "> Patch Set 4:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [16:22:21] (CR) Yaron Koren: "Do you mean, you don't know how to run Page Forms? Or Cargo? Are you running MediaWiki?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [16:26:39] (CR) Palak199: "> Patch Set 4:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [16:33:14] (CR) Yaron Koren: "Oh, I see. In order to run an extension, you just need to install it by adding a line for it in LocalSettings.php. See the documentation f" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199) [18:56:31] (CR) Palak199: "> Patch Set 4:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/677109 (https://phabricator.wikimedia.org/T279363) (owner: Palak199)