[01:34:49] (CR) DannyS712: "> Patch Set 9:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/608840 (owner: Yaron Koren) [01:43:53] (PS1) Yaron Koren: Fix setPostEditCookie() header [extensions/PageForms] - https://gerrit.wikimedia.org/r/612342 [01:44:12] (CR) Yaron Koren: "This change is ready for review." [extensions/PageForms] - https://gerrit.wikimedia.org/r/612342 (owner: Yaron Koren) [01:45:31] (PS2) Yaron Koren: Fix setPostEditCookie() header [extensions/PageForms] - https://gerrit.wikimedia.org/r/612342 [01:53:01] (CR) Yaron Koren: [C: +2] Fix setPostEditCookie() header [extensions/PageForms] - https://gerrit.wikimedia.org/r/612342 (owner: Yaron Koren) [01:56:51] (Merged) jenkins-bot: Fix setPostEditCookie() header [extensions/PageForms] - https://gerrit.wikimedia.org/r/612342 (owner: Yaron Koren) [02:02:06] (CR) Yaron Koren: "Can you explain what this does? I don't understand it." [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [10:03:41] (CR) Pastakhov: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [13:18:22] (CR) Yaron Koren: "Okay, I think I understand - it lets you modify some other page, behind the scenes, when the user clicks on #formlink. But why? What's an " [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [13:45:36] (CR) Pastakhov: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [16:05:17] (CR) Yaron Koren: "Okay, now I get it. But instead of combining #autoedit and #formlink into one, how about this other solution: have an #autoedit link calle" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [17:55:19] (CR) Pastakhov: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [19:20:02] (CR) Yaron Koren: "I don't know what you mean by "universal" - a feature with possibly only one use case seems like the opposite of universal. All the more s" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [19:38:43] (CR) Pastakhov: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [20:13:32] (CR) Yaron Koren: "Oh, I see - in your approach, the #formlink call is only displayed if no one has "locked" the page already. So the page can only be "locke" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [20:52:19] (CR) Umherirrender: Fix names on @param doc (6 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/611926 (owner: Umherirrender) [20:55:15] (CR) Yaron Koren: "Should I merge this in? Or are there still unresolved issues?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611926 (owner: Umherirrender) [21:26:29] (CR) Pastakhov: "In your solution, the main problem is that the button remains after the user begins to write the article and in this case, users must foll" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [22:06:47] (CR) Yaron Koren: "I'm not sure I understand which button you're talking about, but I think with a few #if calls, the logic can be made pretty simple: if no " [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [22:16:01] (CR) Pastakhov: "Ok, no problem. I'll remove these additional parameters and related code from the patch." [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [22:21:44] (CR) Pastakhov: "> Patch Set 5:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov) [23:11:39] (CR) Yaron Koren: "Yes, of course - you can create any additional extensions with any functionality you want." [extensions/PageForms] - https://gerrit.wikimedia.org/r/611462 (owner: Pastakhov)