[00:30:11] <wikibugs>	 (PS3) Sahajsk: Make date field in PageForms handle ancient dates correctly [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634
[00:34:33] <wikibugs>	 (CR) Sahajsk: "> Patch Set 2:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[00:38:03] <wikibugs>	 (CR) Yaron Koren: "Looks much better - and more similar to the previous code. But why did you call the variable "$dateformat"?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[01:59:14] <wikibugs>	 (CR) Sahajsk: "> Patch Set 3:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[02:53:25] <wikibugs>	 (CR) Yaron Koren: "Alright. That variable name still bothers me a little... "$dateformat" makes it sound like the variable *is* a format, but it *generates* " [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[03:29:08] <wikibugs>	 (CR) Sahajsk: "> Patch Set 3:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[03:34:09] <wikibugs>	 (CR) Sahajsk: "While surfing it seems developers tend to name the variable as $date itself." [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[04:54:29] <wikibugs>	 (PS1) Antoine Mercier-Linteau: Fix bug with query argument and optimize code [extensions/SemanticACL] - https://gerrit.wikimedia.org/r/582952
[04:57:51] <wikibugs>	 (CR) Antoine Mercier-Linteau: [C: +2] Fix bug with query argument and optimize code [extensions/SemanticACL] - https://gerrit.wikimedia.org/r/582952 (owner: Antoine Mercier-Linteau)
[04:58:18] <wikibugs>	 (Merged) jenkins-bot: Fix bug with query argument and optimize code [extensions/SemanticACL] - https://gerrit.wikimedia.org/r/582952 (owner: Antoine Mercier-Linteau)
[13:21:07] <wikibugs>	 (CR) Yaron Koren: "I agree that "$date" would have been a good name for the variable. What about $dateObj or $dateTime or $dateTimeObj, since this is an obje" [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[13:23:24] <wikibugs>	 (CR) Sahajsk: "> Patch Set 3:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[13:29:23] <wikibugs>	 (PS4) Sahajsk: Make date field in PageForms handle ancient dates correctly [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634
[14:01:01] <wikibugs>	 (CR) Yaron Koren: [C: +2] Make date field in PageForms handle ancient dates correctly [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[14:04:46] <wikibugs>	 (Merged) jenkins-bot: Make date field in PageForms handle ancient dates correctly [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)
[20:46:30] <wikibugs>	 (PS1) Yaron Koren: Add PFTemplate::setCargoTable() [extensions/PageForms] - https://gerrit.wikimedia.org/r/583141
[21:01:26] <wikibugs>	 (PS2) Yaron Koren: Add PFTemplate::setCargoTable() [extensions/PageForms] - https://gerrit.wikimedia.org/r/583141
[21:02:20] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add PFTemplate::setCargoTable() [extensions/PageForms] - https://gerrit.wikimedia.org/r/583141 (owner: Yaron Koren)
[21:03:42] <wikibugs>	 (PS3) Yaron Koren: Add PFTemplate::setCargoTable() [extensions/PageForms] - https://gerrit.wikimedia.org/r/583141
[21:11:35] <wikibugs>	 (CR) Yaron Koren: [C: +2] Add PFTemplate::setCargoTable() [extensions/PageForms] - https://gerrit.wikimedia.org/r/583141 (owner: Yaron Koren)
[21:15:05] <wikibugs>	 (Merged) jenkins-bot: Add PFTemplate::setCargoTable() [extensions/PageForms] - https://gerrit.wikimedia.org/r/583141 (owner: Yaron Koren)