[00:18:10] (PS2) Amr El-Absy: Add Paring to "unique for namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) [01:41:26] (PS3) Yaron Koren: Add Paring to "unique for namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [01:42:19] (CR) jerkins-bot: [V: -1] Add Paring to "unique for namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [01:51:44] (CR) Yaron Koren: "Oh, right, I forgot that this patch was created before we finalized the previous patch. The code looks good now! It just needs a few fixes" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [01:53:35] (CR) Amr El-Absy: "Am I required to do those fixes?! I may create new patch with the new code, but I am pretty sure this is not the right thing to do." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:08:50] (CR) Yaron Koren: "What's not the right thing to do?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:39:01] (CR) Amr El-Absy: "> What's not the right thing to do?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:40:26] (CR) Yaron Koren: "Right, it's better to modify this patch. You don't have to do it - if you don't want to, let me know and I'll make the fixes." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:42:03] (CR) Amr El-Absy: "Well, I don't know what the fixes I may make, so kindly make them, please." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:48:24] (PS4) Yaron Koren: Add parsing to "unique for namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:57:18] (CR) Yaron Koren: [C: +2] Add parsing to "unique for namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [02:59:56] (PS1) Legoktm: Avoid deprecated curly brace syntax [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/582624 [03:00:59] (Merged) jenkins-bot: Add parsing to "unique for namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [03:20:53] (CR) Yaron Koren: [C: +2] Avoid deprecated curly brace syntax [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/582624 (owner: Legoktm) [03:23:44] (Merged) jenkins-bot: Avoid deprecated curly brace syntax [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/582624 (owner: Legoktm) [04:02:53] (PS1) Sahajsk: Make date field in PageForms handle ancient dates correctly [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 [09:07:59] (Abandoned) Aklapper: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms into T246088-fix [extensions/PageForms] - https://gerrit.wikimedia.org/r/574927 (owner: Tingan) [10:38:36] (PS1) Seb35: Replace call to a function removed in MW 1.34 [extensions/PageForms] - https://gerrit.wikimedia.org/r/582780 [18:08:06] (PS1) Antoine Mercier-Linteau: Expand template in order to retrive the SEMANTICACL_PRIVATE_LINK magic word when it's inside a template [extensions/SemanticACL] - https://gerrit.wikimedia.org/r/582868 [18:09:14] (CR) Antoine Mercier-Linteau: [C: +2] Expand template in order to retrive the SEMANTICACL_PRIVATE_LINK magic word when it's inside a template [extensions/SemanticACL] - https://gerrit.wikimedia.org/r/582868 (owner: Antoine Mercier-Linteau) [18:15:02] (Merged) jenkins-bot: Expand template in order to retrive the SEMANTICACL_PRIVATE_LINK magic word when it's inside a template [extensions/SemanticACL] - https://gerrit.wikimedia.org/r/582868 (owner: Antoine Mercier-Linteau) [21:50:41] (PS2) Yaron Koren: Make date field in PageForms handle ancient dates correctly [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk) [22:14:11] (CR) Yaron Koren: "Sorry for the long delay. This looks good! It seems confusing, though, that the variable $date gets used to hold so many different things." [extensions/PageForms] - https://gerrit.wikimedia.org/r/582634 (owner: Sahajsk)