[09:54:16] (CR) jerkins-bot: [V: -1] build: Updating minimist to 1.2.5 [extensions/SemanticImageInput] - https://gerrit.wikimedia.org/r/581470 (owner: Libraryupgrader) [09:55:09] (CR) jerkins-bot: [V: -1] build: Updating minimist to 1.2.5 [extensions/SemanticPageSeries] - https://gerrit.wikimedia.org/r/581471 (owner: Libraryupgrader) [09:58:15] (CR) jerkins-bot: [V: -1] build: Updating minimist to 1.2.5 [extensions/SemanticSifter] - https://gerrit.wikimedia.org/r/581473 (owner: Libraryupgrader) [09:58:28] (CR) jerkins-bot: [V: -1] build: Updating minimist to 1.2.5 [extensions/SemanticWebBrowser] - https://gerrit.wikimedia.org/r/581474 (owner: Libraryupgrader) [16:17:43] (PS1) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [16:26:16] (CR) Umherirrender: [C: +2] "Resubmit" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579715 (owner: Umherirrender) [16:29:29] (CR) Umherirrender: [V: +2] build: Updating minimist to 1.2.5 [extensions/SemanticSifter] - https://gerrit.wikimedia.org/r/581473 (owner: Libraryupgrader) [16:30:21] (CR) Umherirrender: [V: +2] build: Updating minimist to 1.2.5 [extensions/SemanticWebBrowser] - https://gerrit.wikimedia.org/r/581474 (owner: Libraryupgrader) [16:30:51] (CR) Umherirrender: [V: +2] build: Updating minimist to 1.2.5 [extensions/SemanticImageInput] - https://gerrit.wikimedia.org/r/581470 (owner: Libraryupgrader) [16:31:22] (CR) Umherirrender: [V: +2] build: Updating minimist to 1.2.5 [extensions/SemanticPageSeries] - https://gerrit.wikimedia.org/r/581471 (owner: Libraryupgrader) [16:32:02] (Merged) jenkins-bot: Use MediaWikiServices::getMessageCache if available [extensions/PageForms] - https://gerrit.wikimedia.org/r/579715 (owner: Umherirrender) [17:12:33] (PS1) Amr El-Absy: Add Paring to "unique for namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581660 (https://phabricator.wikimedia.org/T246715) [17:29:47] (CR) Yaron Koren: "I don't think this will work for "values from query". And it won't work fully for "values from category" either, because of the $wgCapital" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [18:48:56] (CR) Amr El-Absy: "I think this set would resolve the "values from category" thing." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [18:49:11] (PS2) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [18:57:21] (CR) Yaron Koren: "Right, "values from query" calls some functions from the Semantic MediaWiki extension. You don't really need to worry about that - just ma" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [19:00:07] (PS3) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [19:03:54] (CR) Yaron Koren: "This code seems like it would work - but it looks a little hacky. Could you make it more straightforward?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [19:13:30] (PS4) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [19:18:09] (CR) Yaron Koren: "Actually, even this won't really work - "values from category" should get parsed even if $wgCapitalLinks is false." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [19:22:33] (CR) Amr El-Absy: "If I let "values from category" parsed even if $wgCapitalLinks is false, then the code will be simple, just a condition to check whether o" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [20:15:00] (PS5) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [20:18:31] (CR) Yaron Koren: "As before, this won't work fully for "values from category". The "values from category" value needs to be parsed whether or not $wgCapital" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [20:22:31] (CR) Amr El-Absy: "May you give me two or three examples on how the value of that parameter may be, and how should they be parsed based on $wgCapitalLinks?! " [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [20:29:58] (CR) Yaron Koren: "Sure, okay. This is a silly example, but if you have "values from category={{CONTENTLANGUAGE}}", on an English-language website, then, if " [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [20:56:56] (CR) Amr El-Absy: "> Sure, okay. This is a silly example, but if you have "values from" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [21:24:43] (CR) Yaron Koren: "Well, yes - I used {{CONTENTLANGUAGE}} as an example because it's something that would need to be parsed." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [21:40:19] (PS6) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [21:46:39] (CR) Yaron Koren: "Okay, this is looking a little better. But now "values from category" will be parsed twice, which might lead to problems." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [21:50:07] (PS7) Amr El-Absy: Add parsing to "Values from namespace/category" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [21:52:44] (CR) Amr El-Absy: "I don't know what exactly is better, to call the parsing function in the condition statement for "values from concept" AND "values from na" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [23:08:17] (CR) Yaron Koren: "Sorry for the delay. I think the first one is better - calling the parsing within each condition statement." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [23:14:22] (PS8) Amr El-Absy: Add parsing to "Values from namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [23:16:08] (CR) Yaron Koren: "Looks good! It could be even a little cleaner, though - look at how it's done for "values"." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy) [23:26:16] (PS9) Amr El-Absy: Add parsing to "Values from namespace/category/concept" [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) [23:59:01] (CR) Yaron Koren: "It looks good! Some of the tabs need some work, but I think that's the only problem." [extensions/PageForms] - https://gerrit.wikimedia.org/r/581631 (https://phabricator.wikimedia.org/T246715) (owner: Amr El-Absy)