[01:05:14] (CR) Amr El-Absy: "It can be handled, but I think I would need to use JavaScript, which you told me not to." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [01:27:38] (PS2) AdhamKhatean: Fix the problem of Label clicking does not affect checkbox [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) [01:27:40] (CR) Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [01:36:40] (CR) Yaron Koren: "You don't need JS. The layout already looked good in Patch Set 3 - I just thought the CSS could be simpler." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [01:37:54] (CR) Yaron Koren: "Are you still sure that all of this JavaScript is needed?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [01:42:10] (CR) AdhamKhatean: "> Are you still sure that all of this JavaScript is needed?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [01:49:47] (PS5) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [02:11:40] (CR) Yaron Koren: "Just commit/upload a new version - it doesn't matter." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [02:18:17] (CR) Yaron Koren: "It looks good now! But the commit message is way too long - it doesn't need to describe all the versions of the patch, it just needs to ex" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [02:18:39] (PS3) AdhamKhatean: Fix the problem of Label clicking does not affect checkbox [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) [02:22:40] (PS6) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [02:30:01] (CR) Yaron Koren: "Is this what you meant to upload? Let me know when I should review the code." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [02:31:24] (PS7) Yaron Koren: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [03:28:08] (PS4) AdhamKhatean: Fix the problem of Label clicking does not affect checkbox [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) [05:03:20] (CR) Yaron Koren: "I'll test this tomorrow, but it looks like you're on the right track here. :)" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [13:39:24] (PS5) Yaron Koren: Fix the problem of Label clicking does not affect checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [13:48:46] (CR) Yaron Koren: [C: +2] Fix the problem of Label clicking does not affect checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [13:51:38] (CR) jerkins-bot: [V: -1] Fix the problem of Label clicking does not affect checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [13:54:36] (CR) Yaron Koren: "This looks great. My only comment is on the commit message - it should clarify that you also changed something else, which is the "wrappin" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [13:57:01] (PS6) Yaron Koren: Fix the problem of Label clicking does not affect checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [13:57:55] (CR) Yaron Koren: [C: +2] "Trying again... hopefully that verify problem was just a temporary error." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [14:01:03] (CR) jerkins-bot: [V: -1] Fix the problem of Label clicking does not affect checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [14:14:09] (PS8) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [14:23:32] (CR) Yaron Koren: "The change looks good - except that you added "10px in each side", which is not true..." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [14:29:40] (PS9) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [14:38:22] (CR) Yaron Koren: [C: +2] Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [15:04:56] (CR) jerkins-bot: [V: -1] Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [15:30:06] (CR) Yaron Koren: [C: +2] "It looks like there might have been some changes to Jenkins validation that are preventing changes to Page Forms from getting approved - t" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [15:30:13] (CR) Yaron Koren: [C: +2] "It looks like there might have been some changes to Jenkins validation that are preventing changes to Page Forms from getting approved - t" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [16:25:59] (CR) jerkins-bot: [V: -1] Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [16:26:02] (CR) jerkins-bot: [V: -1] Fix the problem of Label clicking does not affect checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [17:47:16] (PS1) Yaron Koren: Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 [17:48:09] (PS2) Yaron Koren: Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 [17:55:46] (CR) Yaron Koren: [C: +2] Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren) [18:05:39] (CR) jerkins-bot: [V: -1] Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren) [18:13:42] (PS3) Yaron Koren: Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 [18:22:39] (CR) Yaron Koren: [C: +2] Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren) [18:29:52] (CR) jerkins-bot: [V: -1] Fix for blank section names in form [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren) [18:35:21] (PS4) Yaron Koren: Fixes to get code to pass Jenkins validation again [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 [18:36:16] (CR) jerkins-bot: [V: -1] Fixes to get code to pass Jenkins validation again [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren) [18:37:35] (PS5) Yaron Koren: Fixes to get code to pass Jenkins validation again [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 [18:39:24] (CR) jerkins-bot: [V: -1] Fixes to get code to pass Jenkins validation again [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren) [18:46:11] (PS6) Yaron Koren: Fixes to get code to pass Jenkins validation again [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 [18:48:04] (CR) jerkins-bot: [V: -1] Fixes to get code to pass Jenkins validation again [extensions/PageForms] - https://gerrit.wikimedia.org/r/580094 (owner: Yaron Koren)