[03:29:36] (CR) Yaron Koren: "@AdhamKhatean - I just tried this out. Cool, it works! But is this new code too complicated? Can you explain what that "if" statement is d" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [04:01:19] (CR) Yaron Koren: "This looks pretty good! And forget what I wrote about the labels being too low - that looks like just how Google Chrome displays it." [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [08:53:14] (CR) AdhamKhatean: "> @AdhamKhatean - I just tried this out. Cool, it works! But is this" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [11:36:10] (Abandoned) Amr El-Absy: Fixing Checkboxes Layout [extensions/PageForms] - https://gerrit.wikimedia.org/r/579449 (owner: Amr El-Absy) [12:05:44] (PS6) Edward Chernenko: Show two datepickers (Start/End) for date properties [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/579330 [12:06:35] (CR) jerkins-bot: [V: -1] Show two datepickers (Start/End) for date properties [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/579330 (owner: Edward Chernenko) [12:10:04] (PS2) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [12:21:51] (CR) Yaron Koren: "Hi - I didn't test this, but it seems like it would work. It seems "too clever", though - I would prefer a solution that just uses CSS. Ca" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [12:22:14] (CR) Yaron Koren: "(It's great that you figured out Gerrit, though.)" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [12:24:25] (PS7) Edward Chernenko: Show two datepickers (Start/End) for date properties [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/579330 [12:32:16] (CR) Amr El-Absy: "> Hi - I didn't test this, but it seems like it would work. It seems" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [13:22:47] (CR) Yaron Koren: "Why not put the extra padding, or margin, *after* each label, instead of before each checkbox? That way, you don't need special handling f" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [16:17:57] (PS3) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [18:33:12] (CR) Yaron Koren: "It looks good now! But can the CSS changes be simplified?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [19:34:29] (PS4) Amr El-Absy: Fix The Appearance of Checkboxes [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) [21:04:29] (CR) Yaron Koren: "Please just restrict the new code to what you think is actually necessary. If it turns out that you removed some code that is important, t" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579801 (https://phabricator.wikimedia.org/T217516) (owner: AdhamKhatean) [21:13:47] (CR) Yaron Koren: "This looks good; the use of "inline-block" display definitely makes the layout look nicer. However the CSS may be a little *too* simple no" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [21:19:04] (CR) Amr El-Absy: "> This looks good; the use of "inline-block" display definitely makes" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy) [21:36:53] (CR) Yaron Koren: "It looks nice, but it also makes the "checkboxes" input have a different alignment from the other input types, which is not good. Also, as" [extensions/PageForms] - https://gerrit.wikimedia.org/r/579694 (https://phabricator.wikimedia.org/T217517) (owner: Amr El-Absy)