[06:41:16] (PS1) Tingan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms into T246088-fix [extensions/PageForms] - https://gerrit.wikimedia.org/r/574927 [06:41:18] (PS1) Tingan: reformat code with spaces [extensions/PageForms] - https://gerrit.wikimedia.org/r/574928 [07:12:41] (CR) Nikerabbit: "Please use --amend. We do not follow the GitHub model, here we update patchsets until they are ready to be merged." [extensions/PageForms] - https://gerrit.wikimedia.org/r/574793 (https://phabricator.wikimedia.org/T246088) (owner: Tingan) [07:30:56] (PS2) Tingan: reformat code with spaces [extensions/PageForms] - https://gerrit.wikimedia.org/r/574928 [08:50:43] (CR) Thiemo Kreuz (WMDE): [C: -2] "Oh, that doesn't look like it belongs here. Please use --amend for Gerrit. This is different from GitHub, unfortunately." [extensions/PageForms] - https://gerrit.wikimedia.org/r/574927 (owner: Tingan) [09:13:11] (PS3) Tingan: reformat code with spaces [extensions/PageForms] - https://gerrit.wikimedia.org/r/574928 [11:02:34] "Unfortunately" as in they don't follow our model, stupid them. :) [11:03:01] I have to check how some of these do it https://libreplanet.org/wiki/Fsf_2019_forge_evaluation [12:03:17] (PS1) Tingan: fix WikiEditor not show in pageforms textarea editor=wikieditor [extensions/PageForms] - https://gerrit.wikimedia.org/r/575006 [15:44:52] (PS1) Edward Chernenko: UX: Click on semanticDrilldownCombobox should start Search immediately [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/575032 [15:48:22] (CR) jerkins-bot: [V: -1] UX: Click on semanticDrilldownCombobox should start Search immediately [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/575032 (owner: Edward Chernenko) [15:58:17] (PS2) Edward Chernenko: UX: Click on semanticDrilldownCombobox should start Search immediately [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/575032 [16:04:57] (CR) Yaron Koren: [C: +2] UX: Click on semanticDrilldownCombobox should start Search immediately [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/575032 (owner: Edward Chernenko) [16:24:05] (Merged) jenkins-bot: UX: Click on semanticDrilldownCombobox should start Search immediately [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/575032 (owner: Edward Chernenko) [19:48:46] (PS3) Yaron Koren: Switch away from Title::getUserPermissionsErrors for MW 1.33+ [extensions/PageForms] - https://gerrit.wikimedia.org/r/575051 (https://phabricator.wikimedia.org/T246195) (owner: DannyS712) [19:51:04] (PS4) Yaron Koren: Switch away from Title::getUserPermissionsErrors for MW 1.33+ [extensions/PageForms] - https://gerrit.wikimedia.org/r/575051 (https://phabricator.wikimedia.org/T246195) (owner: DannyS712) [20:03:30] (CR) Yaron Koren: [C: +2] Switch away from Title::getUserPermissionsErrors for MW 1.33+ [extensions/PageForms] - https://gerrit.wikimedia.org/r/575051 (https://phabricator.wikimedia.org/T246195) (owner: DannyS712) [20:06:38] (Merged) jenkins-bot: Switch away from Title::getUserPermissionsErrors for MW 1.33+ [extensions/PageForms] - https://gerrit.wikimedia.org/r/575051 (https://phabricator.wikimedia.org/T246195) (owner: DannyS712) [20:26:27] (PS1) Pastakhov: Decode html entity in forminput parameters [extensions/PageForms] - https://gerrit.wikimedia.org/r/575080 [20:33:25] (CR) Yaron Koren: [C: +2] Decode html entity in forminput parameters [extensions/PageForms] - https://gerrit.wikimedia.org/r/575080 (owner: Pastakhov) [20:36:39] (Merged) jenkins-bot: Decode html entity in forminput parameters [extensions/PageForms] - https://gerrit.wikimedia.org/r/575080 (owner: Pastakhov) [22:53:07] (PS3) Awight: Use editRevId for better edit conflict detection [extensions/PageForms] - https://gerrit.wikimedia.org/r/445250 (https://phabricator.wikimedia.org/T58849)