[02:37:53] (PS3) Yaron Koren: Remove dead, unused parameter from PFCreatePageJob [extensions/PageForms] - https://gerrit.wikimedia.org/r/566741 (owner: Thiemo Kreuz (WMDE)) [02:41:28] (CR) Yaron Koren: [C: +2] Remove dead, unused parameter from PFCreatePageJob [extensions/PageForms] - https://gerrit.wikimedia.org/r/566741 (owner: Thiemo Kreuz (WMDE)) [02:53:54] (Merged) jenkins-bot: Remove dead, unused parameter from PFCreatePageJob [extensions/PageForms] - https://gerrit.wikimedia.org/r/566741 (owner: Thiemo Kreuz (WMDE)) [03:03:36] (PS3) Yaron Koren: Simplify Hooks section in extension.json [extensions/PageForms] - https://gerrit.wikimedia.org/r/566739 (owner: Thiemo Kreuz (WMDE)) [03:08:31] (CR) Yaron Koren: [C: +2] Simplify Hooks section in extension.json [extensions/PageForms] - https://gerrit.wikimedia.org/r/566739 (owner: Thiemo Kreuz (WMDE)) [03:11:55] (Merged) jenkins-bot: Simplify Hooks section in extension.json [extensions/PageForms] - https://gerrit.wikimedia.org/r/566739 (owner: Thiemo Kreuz (WMDE)) [03:13:37] (PS3) Yaron Koren: Remove unused argument in PFParserFunctions [extensions/PageForms] - https://gerrit.wikimedia.org/r/566745 (owner: Thiemo Kreuz (WMDE)) [03:27:51] (CR) Yaron Koren: [C: +2] Remove unused argument in PFParserFunctions [extensions/PageForms] - https://gerrit.wikimedia.org/r/566745 (owner: Thiemo Kreuz (WMDE)) [03:31:29] (Merged) jenkins-bot: Remove unused argument in PFParserFunctions [extensions/PageForms] - https://gerrit.wikimedia.org/r/566745 (owner: Thiemo Kreuz (WMDE)) [03:43:48] (PS3) Yaron Koren: Do not expect the Parser by reference [extensions/PageForms] - https://gerrit.wikimedia.org/r/566740 (owner: Thiemo Kreuz (WMDE)) [03:54:14] (CR) Yaron Koren: [C: +2] Do not expect the Parser by reference [extensions/PageForms] - https://gerrit.wikimedia.org/r/566740 (owner: Thiemo Kreuz (WMDE)) [03:57:41] (Merged) jenkins-bot: Do not expect the Parser by reference [extensions/PageForms] - https://gerrit.wikimedia.org/r/566740 (owner: Thiemo Kreuz (WMDE)) [03:59:48] (CR) Yaron Koren: [C: +2] Fix "post edit cookie" [extensions/PageForms] - https://gerrit.wikimedia.org/r/567199 (owner: Jeroen De Dauw) [03:59:51] (PS2) Yaron Koren: Fix "post edit cookie" [extensions/PageForms] - https://gerrit.wikimedia.org/r/567199 (owner: Jeroen De Dauw) [04:21:44] (CR) Yaron Koren: [C: +2] "." [extensions/PageForms] - https://gerrit.wikimedia.org/r/567199 (owner: Jeroen De Dauw) [04:29:00] (Merged) jenkins-bot: Fix "post edit cookie" [extensions/PageForms] - https://gerrit.wikimedia.org/r/567199 (owner: Jeroen De Dauw) [04:39:52] (PS3) Yaron Koren: Update a few pieces of documentation [extensions/PageForms] - https://gerrit.wikimedia.org/r/566742 (owner: Thiemo Kreuz (WMDE)) [04:43:02] (CR) Yaron Koren: [C: +2] Update a few pieces of documentation [extensions/PageForms] - https://gerrit.wikimedia.org/r/566742 (owner: Thiemo Kreuz (WMDE)) [04:46:26] (Merged) jenkins-bot: Update a few pieces of documentation [extensions/PageForms] - https://gerrit.wikimedia.org/r/566742 (owner: Thiemo Kreuz (WMDE)) [05:07:04] (CR) Yaron Koren: [C: -2] "It looks like the "??" operator was added in PHP 7.0, and Page Forms still supports PHP 5.5 and 5.6 (since it still supports MW < 1.31), s" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [09:14:45] (CR) Thiemo Kreuz (WMDE): "Oh, I assure you, this can be merged. Compatibility with old MediaWiki versions was broken long ago. It's not covered by the current CI (c" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [13:55:05] (CR) Yaron Koren: [C: -2] "The current master of Page Forms is indeed compatible with older MediaWiki versions, going back to 1.28. At least, it's supposed to be." [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [14:12:54] (CR) Thiemo Kreuz (WMDE): "It's not, any it can't be any more. There is nothing in place here any more that checks that kind of compatibility. The Wikimedia infrastr" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [14:30:18] (CR) Yaron Koren: [C: -2] "Sorry, I don't really understand what you're saying. If someone is running, say, MediaWiki 1.30 on their site, and they install the latest" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [16:00:38] (CR) Thiemo Kreuz (WMDE): "That might be the case, or not. How do you know this user is running every possible code-path? Maybe there is already one that is not comp" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE)) [16:10:42] (PS4) TheSandDoctor: Replace $wgParser with MediaWikiServices [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/561232 (https://phabricator.wikimedia.org/T241565) [16:10:55] (CR) jerkins-bot: [V: -1] Replace $wgParser with MediaWikiServices [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/561232 (https://phabricator.wikimedia.org/T241565) (owner: TheSandDoctor) [16:12:41] (CR) TheSandDoctor: ">" (1 comment) [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/561232 (https://phabricator.wikimedia.org/T241565) (owner: TheSandDoctor) [16:46:30] (CR) Ammarpad: "> >" (1 comment) [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/561232 (https://phabricator.wikimedia.org/T241565) (owner: TheSandDoctor) [17:35:29] (CR) Yaron Koren: [C: -2] "Well, okay, but there's a lot about Page Forms that isn't being tested by Jenkins, or anything else - just passing the validation tests do" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744 (owner: Thiemo Kreuz (WMDE))