[06:13:50] <wikibugs>	 (CR) Thiemo Kreuz (WMDE): [C: +2] "I'm going to self-merge this for now. This is trivial, a single line only. Identical patches have been merged about a hundred times the pa" (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/566857 (owner: Thiemo Kreuz (WMDE))
[06:16:47] <wikibugs>	 (Merged) jenkins-bot: Fix test compatibility with PHPUnit 8 [extensions/PageForms] - https://gerrit.wikimedia.org/r/566857 (owner: Thiemo Kreuz (WMDE))
[10:26:50] <wikibugs>	 (PS2) Thiemo Kreuz (WMDE): Replace a few isset() with PHP's ?? feature [extensions/PageForms] - https://gerrit.wikimedia.org/r/566744
[10:26:53] <wikibugs>	 (PS2) Thiemo Kreuz (WMDE): Update a few pieces of documentation [extensions/PageForms] - https://gerrit.wikimedia.org/r/566742
[10:26:57] <wikibugs>	 (PS2) Thiemo Kreuz (WMDE): Remove dead, unused parameter from PFCreatePageJob [extensions/PageForms] - https://gerrit.wikimedia.org/r/566741
[10:27:01] <wikibugs>	 (PS2) Thiemo Kreuz (WMDE): Do not expect the Parser by reference [extensions/PageForms] - https://gerrit.wikimedia.org/r/566740
[10:27:04] <wikibugs>	 (PS2) Thiemo Kreuz (WMDE): Simplify Hooks section in extension.json [extensions/PageForms] - https://gerrit.wikimedia.org/r/566739
[10:27:32] <wikibugs>	 (PS2) Thiemo Kreuz (WMDE): Remove unused argument in PFParserFunctions [extensions/PageForms] - https://gerrit.wikimedia.org/r/566745
[11:22:48] <wikibugs>	 (CR) Daimona Eaytoy: [C: +2] Remove use of global $wgUser (part 1) [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[11:25:53] <wikibugs>	 (Merged) jenkins-bot: Remove use of global $wgUser (part 1) [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[14:20:20] <wikibugs>	 (CR) Yaron Koren: "Sorry for not responding before. I think at least some of your arguments are based on the assumption that these static functions could be " [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[14:25:08] <wikibugs>	 (CR) Daimona Eaytoy: [C: +2] "> Sorry for not responding before. I think at least some of your" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[14:51:28] <wikibugs>	 (CR) Yaron Koren: "> IMHO, using the global state (to pass around stateful objects) is out of the question for any non-trivial application." [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[15:14:09] <wikibugs>	 (CR) Daimona Eaytoy: [C: +2] "> I don't agree with this. Definitely, if the global variables are" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[15:46:53] <wikibugs>	 (CR) Yaron Koren: "I don't think the "testability" thing is a big deal - most of these utilities can't be tested in a standalone way, which of course means t" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[16:43:26] <wikibugs>	 (PS1) Yaron Koren: Partial revert of 11ed5bd2831f [extensions/PageForms] - https://gerrit.wikimedia.org/r/567097
[16:52:01] <wikibugs>	 (PS2) Yaron Koren: Partial revert of 11ed5bd2831f [extensions/PageForms] - https://gerrit.wikimedia.org/r/567097
[16:54:11] <wikibugs>	 (CR) jerkins-bot: [V: -1] Partial revert of 11ed5bd2831f [extensions/PageForms] - https://gerrit.wikimedia.org/r/567097 (owner: Yaron Koren)
[16:59:40] <wikibugs>	 (PS3) Yaron Koren: Partial revert of 11ed5bd2831f [extensions/PageForms] - https://gerrit.wikimedia.org/r/567097
[17:05:06] <wikibugs>	 (CR) Yaron Koren: [C: +2] Partial revert of 11ed5bd2831f [extensions/PageForms] - https://gerrit.wikimedia.org/r/567097 (owner: Yaron Koren)
[17:24:59] <wikibugs>	 (CR) Daimona Eaytoy: [C: +2] "> I don't think the "testability" thing is a big deal - most of these" [extensions/PageForms] - https://gerrit.wikimedia.org/r/566653 (https://phabricator.wikimedia.org/T243487) (owner: DannyS712)
[17:27:48] <wikibugs>	 (Merged) jenkins-bot: Partial revert of 11ed5bd2831f [extensions/PageForms] - https://gerrit.wikimedia.org/r/567097 (owner: Yaron Koren)