[00:10:28] (PS8) markahershberger: Don't show 'Select a form to create this page:' if there are no forms [extensions/PageForms] - https://gerrit.wikimedia.org/r/552157 (https://phabricator.wikimedia.org/T238806) [00:10:30] (PS2) markahershberger: Fix handling of defaults for radiobuttons [extensions/PageForms] - https://gerrit.wikimedia.org/r/552091 (https://phabricator.wikimedia.org/T137701) [00:29:00] (PS3) markahershberger: Remove stray, meaningless "return true" [extensions/PageForms] - https://gerrit.wikimedia.org/r/551662 [00:29:02] (PS3) markahershberger: Sort excluded rules and add exclusion for UnrecognizedAnnotation [extensions/PageForms] - https://gerrit.wikimedia.org/r/551663 [00:29:04] (PS3) markahershberger: Automatic fixes from phpcbf [extensions/PageForms] - https://gerrit.wikimedia.org/r/551664 [00:38:22] (PS8) markahershberger: Update rules and correct a @ and return [extensions/PageForms] - https://gerrit.wikimedia.org/r/551697 [00:38:24] (PS8) markahershberger: Fix messages so if the test is skipped you have a better reason why [extensions/PageForms] - https://gerrit.wikimedia.org/r/551698 [00:51:44] (PS5) markahershberger: Move files into a place that seems to match core better. [extensions/PageForms] - https://gerrit.wikimedia.org/r/551823 [00:53:17] (CR) jerkins-bot: [V: -1] Move files into a place that seems to match core better. [extensions/PageForms] - https://gerrit.wikimedia.org/r/551823 (owner: markahershberger) [01:15:51] (PS9) markahershberger: Don't show 'Select a form to create this page:' if there are no forms [extensions/PageForms] - https://gerrit.wikimedia.org/r/552157 (https://phabricator.wikimedia.org/T238806) [01:15:53] (PS3) markahershberger: Fix handling of defaults for radiobuttons [extensions/PageForms] - https://gerrit.wikimedia.org/r/552091 (https://phabricator.wikimedia.org/T137701) [01:30:35] (Abandoned) markahershberger: Replace $wgOut, $wgParser, $wgRequest, and $wgUser [extensions/PageForms] - https://gerrit.wikimedia.org/r/534857 (owner: markahershberger) [01:30:46] (Abandoned) markahershberger: Remove $wgUser from PFUtils::printRedirectForm() by passing it in. [extensions/PageForms] - https://gerrit.wikimedia.org/r/534932 (owner: markahershberger) [01:31:01] (Abandoned) markahershberger: Add isQuery and isDisabled properties [extensions/PageForms] - https://gerrit.wikimedia.org/r/534898 (owner: markahershberger) [01:31:20] (Abandoned) markahershberger: Use UnitTestsList Hook [extensions/PageForms] - https://gerrit.wikimedia.org/r/534547 (owner: markahershberger) [01:31:44] (Abandoned) markahershberger: Start work on TextInput [extensions/PageForms] - https://gerrit.wikimedia.org/r/533369 (owner: markahershberger) [01:33:25] (Abandoned) markahershberger: Use class instead of string check for db compatibility [extensions/PageForms] - https://gerrit.wikimedia.org/r/524518 (owner: markahershberger) [01:35:57] (Abandoned) markahershberger: Add tests to demonstrate errors [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [03:01:18] (CR) Yaron Koren: [C: +2] Fix handling of defaults for radiobuttons [extensions/PageForms] - https://gerrit.wikimedia.org/r/552091 (https://phabricator.wikimedia.org/T137701) (owner: markahershberger) [03:01:49] (CR) Yaron Koren: [C: -1] "Oops, didn't mean to hit +2. I think my previous comments still apply to this patch..." [extensions/PageForms] - https://gerrit.wikimedia.org/r/552091 (https://phabricator.wikimedia.org/T137701) (owner: markahershberger) [04:10:55] (PS1) markahershberger: formatting [extensions/PageForms] - https://gerrit.wikimedia.org/r/552648 [05:08:59] (CR) markahershberger: "> Ah. I'm sorry for implying something." [extensions/PageForms] - https://gerrit.wikimedia.org/r/551823 (owner: markahershberger) [14:06:28] (PS1) Tombolano: Fix for wikieditor not being loaded on MediaWiki 1.33 [extensions/PageForms] - https://gerrit.wikimedia.org/r/552655 (https://phabricator.wikimedia.org/T239023) [15:18:57] (CR) Zoranzoki21: "recheck" [extensions/PageForms] - https://gerrit.wikimedia.org/r/552655 (https://phabricator.wikimedia.org/T239023) (owner: Tombolano) [20:45:01] (PS2) Tombolano: Fix for wikieditor not being loaded on MediaWiki 1.33 [extensions/PageForms] - https://gerrit.wikimedia.org/r/552655 (https://phabricator.wikimedia.org/T239023) [20:59:01] (PS3) Yaron Koren: Fix for wikieditor not being loaded on MediaWiki 1.33 [extensions/PageForms] - https://gerrit.wikimedia.org/r/552655 (https://phabricator.wikimedia.org/T239023) (owner: Tombolano) [21:23:35] (CR) Yaron Koren: [C: +2] Fix for wikieditor not being loaded on MediaWiki 1.33 [extensions/PageForms] - https://gerrit.wikimedia.org/r/552655 (https://phabricator.wikimedia.org/T239023) (owner: Tombolano) [21:26:04] (Merged) jenkins-bot: Fix for wikieditor not being loaded on MediaWiki 1.33 [extensions/PageForms] - https://gerrit.wikimedia.org/r/552655 (https://phabricator.wikimedia.org/T239023) (owner: Tombolano)