[03:47:04] (PS1) markahershberger: Add tests to demonstrate errors [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) [03:48:07] (CR) jerkins-bot: [V: -1] Add tests to demonstrate errors [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [03:50:22] (CR) jerkins-bot: [V: -1] Add tests to demonstrate errors [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:17:56] (CR) markahershberger: [C: +2] "I'd like to merge these failing tests so that the follow up patch can fix them." [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:20:24] (PS1) markahershberger: Added handling of missing template in for template [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) [04:20:34] (CR) jerkins-bot: [V: -1] Add tests to demonstrate errors [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:21:46] (CR) jerkins-bot: [V: -1] Added handling of missing template in for template [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:22:41] (CR) jerkins-bot: [V: -1] Added handling of missing template in for template [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:23:53] (CR) markahershberger: [C: +2] "I believe you can merge this (and then merge If9f996a3b0c0d4781f5c09f710ca2536c775889e to fix the failing tests) by removing jenkins-bot's" [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:26:25] (CR) jerkins-bot: [V: -1] Add tests to demonstrate errors [extensions/PageForms] - https://gerrit.wikimedia.org/r/534720 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:26:41] (PS2) markahershberger: Added handling of missing template in for template [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) [04:29:32] (CR) jerkins-bot: [V: -1] Added handling of missing template in for template [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [04:51:55] (PS3) markahershberger: Added handling of missing template in for template [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) [14:30:12] (CR) Yaron Koren: "Thanks for this patch. Okay, there's a lot going on here. It would be better if the different parts of this were split up into different p" [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger) [15:33:33] (CR) Yaron Koren: [C: -1] "Sorry, it wasn't the RadioButtonInput change I was wondering about, it was the FormPrinterTest change." [extensions/PageForms] - https://gerrit.wikimedia.org/r/534721 (https://phabricator.wikimedia.org/T232112) (owner: markahershberger)