[08:09:35] (Abandoned) Thiemo Kreuz (WMDE): Replace unnecessary count() with more trivial [] comparisons [extensions/PageForms] - https://gerrit.wikimedia.org/r/480051 (owner: Thiemo Kreuz (WMDE)) [15:41:14] (PS1) Your1: Multiple fixes for XSS and SQL Injections on the special page. [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/492694 [15:42:28] (CR) Your1: "More fixes regarding https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SemanticDrilldown/+/490807" [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/492694 (owner: Your1) [15:43:52] (CR) Your1: "> Patch Set 1:" [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/490807 (owner: Your1) [15:43:58] (Abandoned) Your1: Added xss fix, esscape the in printFilterValue [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/490807 (owner: Your1) [16:00:13] (PS1) Your1: Workaround for https://phabricator.wikimedia.org/T216805. [extensions/PageForms] - https://gerrit.wikimedia.org/r/492712 [16:00:54] (CR) Your1: "Regarding the discussion on https://github.com/wikimedia/mediawiki-extensions-PageForms/commit/5f69c1dde9879f1cf254b9e17f9fac26d602f2eb" [extensions/PageForms] - https://gerrit.wikimedia.org/r/492712 (owner: Your1) [17:23:08] (CR) Yaron Koren: [C: +2] "Great! This is obviously a hack, but it looks like an improvement over the current state of things. Thank you." [extensions/PageForms] - https://gerrit.wikimedia.org/r/492712 (owner: Your1) [17:24:48] (CR) Yaron Koren: [C: +2] "Fantastic, thank you!" [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/492694 (owner: Your1) [17:27:50] (Merged) jenkins-bot: Workaround for https://phabricator.wikimedia.org/T216805. [extensions/PageForms] - https://gerrit.wikimedia.org/r/492712 (owner: Your1) [17:27:52] (CR) jerkins-bot: [V: -1] Multiple fixes for XSS and SQL Injections on the special page. [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/492694 (owner: Your1) [17:29:45] (CR) jenkins-bot: Workaround for https://phabricator.wikimedia.org/T216805. [extensions/PageForms] - https://gerrit.wikimedia.org/r/492712 (owner: Your1) [18:26:10] (CR) Yaron Koren: "Thiemo - I agree with you that removing the support for MediaWiki versions less than 1.27 makes sense. However, it's tricky for me, becaus" [extensions/PageForms] - https://gerrit.wikimedia.org/r/480051 (owner: Thiemo Kreuz (WMDE)) [19:45:34] (CR) Thiemo Kreuz (WMDE): "I think it's technically easily possible to raise the required PHP version without raising the required MediaWiki version. The only issue " [extensions/PageForms] - https://gerrit.wikimedia.org/r/480051 (owner: Thiemo Kreuz (WMDE))