[08:53:43] (CR) Thiemo Kreuz (WMDE): [C: -1] "What I wrote in PS5 still applies. What this patch currently does is impossible to fix the issue mentioned in the commit message. Either t" [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [12:07:42] (PS1) Thiemo Kreuz (WMDE): Remove redundant text documenting constructors as "constructors" [extensions/PageForms] - https://gerrit.wikimedia.org/r/478908 [12:09:38] (PS1) Thiemo Kreuz (WMDE): Add some missing PHPDoc type hints [extensions/PageForms] - https://gerrit.wikimedia.org/r/478910 [12:11:55] (PS7) Thiemo Kreuz (WMDE): Type hints to narrow "parameter must be an array" error down [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [12:17:53] (PS1) Thiemo Kreuz (WMDE): Use instanceof instead of get_class [extensions/PageForms] - https://gerrit.wikimedia.org/r/478912 [12:19:45] (PS1) Thiemo Kreuz (WMDE): Make use of the …::class feature whenever possible [extensions/PageForms] - https://gerrit.wikimedia.org/r/478913 [12:21:15] (CR) jerkins-bot: [V: -1] Make use of the …::class feature whenever possible [extensions/PageForms] - https://gerrit.wikimedia.org/r/478913 (owner: Thiemo Kreuz (WMDE)) [12:22:50] (CR) jerkins-bot: [V: -1] Make use of the …::class feature whenever possible [extensions/PageForms] - https://gerrit.wikimedia.org/r/478913 (owner: Thiemo Kreuz (WMDE)) [12:23:34] (CR) Thiemo Kreuz (WMDE): [C: 1] "I added a ton of "array" type hints in PS7. This will not fix the bug, but will make the code explode much earlier, and hopefully result i" (2 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [12:24:27] (PS2) Thiemo Kreuz (WMDE): Make use of the …::class feature whenever possible [extensions/PageForms] - https://gerrit.wikimedia.org/r/478913 [12:29:04] (Abandoned) Thiemo Kreuz (WMDE): Statically call the Users::EDIT_TOKEN_SUFFIX constant. [extensions/PageForms] - https://gerrit.wikimedia.org/r/477612 (https://phabricator.wikimedia.org/T61113) (owner: Matthewrbowker) [12:30:49] (CR) Thiemo Kreuz (WMDE): [C: 2] Whitespace fixes [extensions/PageForms] - https://gerrit.wikimedia.org/r/443392 (owner: Your1) [12:34:27] (CR) Thiemo Kreuz (WMDE): [C: 1] "Who is running PHPUnit tests with such an outdated, unsupported version of MediaWiki? I mean, seriously. Even if the extension itself need" [extensions/PageForms] - https://gerrit.wikimedia.org/r/428056 (https://phabricator.wikimedia.org/T142120) (owner: Gopavasanth) [12:53:22] (CR) Paladox: [C: 2] Type hints to narrow "parameter must be an array" error down [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [12:53:34] (CR) Paladox: [C: 2] "Thanks!" [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [12:54:31] (CR) Paladox: [C: 2] Use instanceof instead of get_class [extensions/PageForms] - https://gerrit.wikimedia.org/r/478912 (owner: Thiemo Kreuz (WMDE)) [12:54:58] (CR) Paladox: [C: 2] Add some missing PHPDoc type hints [extensions/PageForms] - https://gerrit.wikimedia.org/r/478910 (owner: Thiemo Kreuz (WMDE)) [12:55:50] (CR) Paladox: "I believe this extension supports a older mw version." [extensions/PageForms] - https://gerrit.wikimedia.org/r/478913 (owner: Thiemo Kreuz (WMDE)) [13:04:58] (Merged) jenkins-bot: Type hints to narrow "parameter must be an array" error down [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [13:05:00] (Merged) jenkins-bot: Use instanceof instead of get_class [extensions/PageForms] - https://gerrit.wikimedia.org/r/478912 (owner: Thiemo Kreuz (WMDE)) [13:09:02] (CR) jenkins-bot: Use instanceof instead of get_class [extensions/PageForms] - https://gerrit.wikimedia.org/r/478912 (owner: Thiemo Kreuz (WMDE)) [13:10:51] (CR) jenkins-bot: Type hints to narrow "parameter must be an array" error down [extensions/PageForms] - https://gerrit.wikimedia.org/r/456996 (https://phabricator.wikimedia.org/T203196) (owner: Paladox) [13:11:19] (Merged) jenkins-bot: Add some missing PHPDoc type hints [extensions/PageForms] - https://gerrit.wikimedia.org/r/478910 (owner: Thiemo Kreuz (WMDE)) [13:13:14] (CR) jenkins-bot: Add some missing PHPDoc type hints [extensions/PageForms] - https://gerrit.wikimedia.org/r/478910 (owner: Thiemo Kreuz (WMDE)) [21:03:22] (CR) Umherirrender: "::class is from php5.5, the short array [] is from php5.4, this extension supports at least php5.3" [extensions/PageForms] - https://gerrit.wikimedia.org/r/478913 (owner: Thiemo Kreuz (WMDE)) [22:36:05] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageForms] - https://gerrit.wikimedia.org/r/479103 (owner: L10n-bot)