[03:17:36] (PS1) Edward Chernenko: Add analogue of EditFormInitialText hook from MediaWiki core [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 [03:52:54] (Draft2) Yaron Koren: Added support for SMW 3 - patch by Ike Hecht [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/420951 [03:57:32] (CR) Yaron Koren: [C: 2] Added support for SMW 3 - patch by Ike Hecht [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/420951 (owner: Yaron Koren) [03:59:42] (Merged) jenkins-bot: Added support for SMW 3 - patch by Ike Hecht [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/420951 (owner: Yaron Koren) [11:17:31] (CR) Yaron Koren: "Did you test this, and/or are you using this?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 (owner: Edward Chernenko) [11:27:13] (CR) Edward Chernenko: "I tested it." [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 (owner: Edward Chernenko) [11:51:12] (CR) Yaron Koren: [C: 2] "Okay, that sounds good! I'm always happy to add new hooks into the code if they're useful." [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 (owner: Edward Chernenko) [11:53:22] (CR) jerkins-bot: [V: -1] Add analogue of EditFormInitialText hook from MediaWiki core [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 (owner: Edward Chernenko) [12:00:33] (CR) Yaron Koren: [C: 2] "Yeah, "else" should be on the same line as the previous "}"." [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 (owner: Edward Chernenko) [12:02:15] (CR) jerkins-bot: [V: -1] Add analogue of EditFormInitialText hook from MediaWiki core [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 (owner: Edward Chernenko) [12:17:22] (PS2) Edward Chernenko: Add analogue of EditFormInitialText hook from MediaWiki core [extensions/PageForms] - https://gerrit.wikimedia.org/r/420950 [19:39:03] So I tried to install semantic mediawiki on my test wiki (via composer). It shows up on Special:Version, but things like Special:Browse don't show up [19:39:10] I'm not sure what I did wrong [19:39:27] high probability it was something stupid [19:40:09] Forgot enableSemantics() in LocalSettings? [19:43:00] I have that. The "browse properties" does show up in my sidebar, its the special page itself that is missing [19:43:47] (If I remove enableSemantics() Browse properties goes away from the sidebar) [19:44:54] Then I don't know :? [19:53:03] curious... I remember having had the same issue once... and it was something stupid yes but I don't remember what [19:53:52] Its weird, Special:Browse is definitely registered in $wgSpecialPages [19:53:57] maybe it was loading order, some other extension initializing special page aliases too early before smw added them [19:54:09] shorturl extension maybe? [19:54:42] https://gerrit.wikimedia.org/r/c/389994/ [19:54:57] either you have old version or some other extension causes the same thing [20:02:31] Yeah, confirmed via var_dump() from specialPageFactory::getList [20:04:14] /vagrant/mediawiki/extensions/CentralNotice/CentralNotice.hooks.php(88) [20:05:10] Hmm, I can't decide whose fault this is. CentralNotice from accesing special pages so early, smw for registering so late, or MediaWiki for silently assuming $wgSpecialPages never changes [20:05:17] probs mediawiki [20:23:31] While I fixed it https://gerrit.wikimedia.org/r/421131