[09:56:49] (CR) Rammanojpotla: "> It works for me with the current code in Git... I don't know why" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [12:20:09] (CR) Yaron Koren: "Oh, I guess this works. I thought calling "$conditions['cl_from'] = $titlekey;" without having declared $conditions as an array would cras" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [13:17:57] (CR) Yashdeep97: "> Cool, this looks nearly ready. A few questions/comments:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97) [13:21:17] (CR) Yaron Koren: "Okay, cool. Yes, I think an array as a parameter would be better." [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97) [14:29:53] (PS5) Rammanojpotla: Enable all categories in Parent category drop-down [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) [14:30:50] (CR) Rammanojpotla: "> Basic test build succeeded." [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [14:50:51] (PS2) Yashdeep97: forminput: Enable Comma Seperated List in #forminput parser function [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) [14:50:53] (PS1) Yashdeep97: forminput: Enable Comma-seperated List in #forminput parser function [extensions/PageForms] - https://gerrit.wikimedia.org/r/410453 (https://phabricator.wikimedia.org/T187110) [16:33:10] (CR) Yaron Koren: "Did you update the code correctly? This looks like the same code from patch 1..." [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97) [16:37:14] (CR) Yaron Koren: "Okay, cool. The conditions would probably be better declared as an array (they just don't need to be set to a variable). That's a minor po" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [19:22:06] (Abandoned) Umherirrender: Remove wfProfileIn/wfProfileOut [extensions/SemanticPageMaker] - https://gerrit.wikimedia.org/r/409575 (owner: Umherirrender) [19:39:24] (CR) Yashdeep97: "> Did you update the code correctly? This looks like the same code" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97) [20:07:49] (PS3) Yashdeep97: forminput: Enable Comma-seperated List in #forminput parser function [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) [20:09:49] (Abandoned) Yashdeep97: forminput: Enable Comma-seperated List in #forminput parser function [extensions/PageForms] - https://gerrit.wikimedia.org/r/410453 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97) [22:39:33] (CR) Yaron Koren: "It's very close now! It would be good if formDropdownHTML() could be called with no arguments, instead of having to call "PFUtils::formDro" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97)