[02:03:44] (PS1) Rammanojpotla: Enable all categories in Parent category drop-down [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) [02:26:19] (CR) Yaron Koren: "You're definitely on the right track - though getAllCategories() doesn't need to have a variable called $title, and getCategoriesForPage()" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [02:33:14] (PS2) Rammanojpotla: Enable all categories in Parent category drop-down [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) [02:35:26] (CR) Rammanojpotla: "> You're definitely on the right track - though getAllCategories()" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [02:47:24] (CR) Yaron Koren: "Well, it's good to be fearless, in this case - I'll do more testing this time." [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [03:00:54] (PS3) Rammanojpotla: Enable all categories in Parent category drop-down [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) [03:02:03] (CR) Rammanojpotla: "> Basic test build succeeded." [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [03:15:40] (CR) Yaron Koren: "Great! But what about getCategoriesForPage()?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [03:20:47] (CR) Rammanojpotla: "> Great! But what about getCategoriesForPage()?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [03:28:00] (CR) Yaron Koren: "Well, getCategoriesForPage() was formerly sometimes called with a null value for $title, but now $title will always be non-null." [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [05:04:19] (PS4) Rammanojpotla: Enable all categories in Parent category drop-down [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) [05:19:17] (CR) Rammanojpotla: "I think it looks fine but I don't know if $conditions = null is needed? as it worked fine without it" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [15:28:27] (CR) Yaron Koren: "Alright. Did you test this?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [15:34:59] (CR) Rammanojpotla: "> Alright. Did you test this?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [16:20:39] (CR) Yaron Koren: "What about displaying the "edit with form" tab correctly - which uses getCategoriesForPage()?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [17:51:39] (CR) Rammanojpotla: "> What about displaying the "edit with form" tab correctly - which" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [18:05:33] (CR) Yaron Koren: "It works for me with the current code in Git... I don't know why it's not working for you. Let me know if you can't figure out the problem" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410098 (https://phabricator.wikimedia.org/T67755) (owner: Rammanojpotla) [19:23:42] (PS1) Yashdeep97: forminput: Enable Comma Seperated List in #forminput parser function [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) [20:33:59] (CR) Yaron Koren: "Cool, this looks nearly ready. A few questions/comments:" [extensions/PageForms] - https://gerrit.wikimedia.org/r/410237 (https://phabricator.wikimedia.org/T187110) (owner: Yashdeep97) [22:01:54] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageForms] - https://gerrit.wikimedia.org/r/410318 (owner: L10n-bot)