[06:42:50] (CR) Thiemo Mättig (WMDE): Add explict var visibility (2 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394672 (owner: Umherirrender) [06:43:19] (CR) Thiemo Mättig (WMDE): [C: 2] DB_SLAVE -> DB_REPLICA [extensions/PageForms] - https://gerrit.wikimedia.org/r/394658 (owner: Umherirrender) [06:45:00] (Merged) jenkins-bot: DB_SLAVE -> DB_REPLICA [extensions/PageForms] - https://gerrit.wikimedia.org/r/394658 (owner: Umherirrender) [11:12:29] (CR) Thiemo Mättig (WMDE): Add explict var visibility (5 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394672 (owner: Umherirrender) [11:46:25] (CR) Thiemo Mättig (WMDE): [C: 2] Use short array syntax (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394697 (owner: Umherirrender) [11:47:53] (CR) Thiemo Mättig (WMDE): [C: 2] Remove unused globals [extensions/PageForms] - https://gerrit.wikimedia.org/r/394662 (owner: Umherirrender) [11:49:31] (Merged) jenkins-bot: Remove unused globals [extensions/PageForms] - https://gerrit.wikimedia.org/r/394662 (owner: Umherirrender) [12:40:36] (CR) Thiemo Mättig (WMDE): [C: -1] "I find a few minor mistakes." (34 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394752 (owner: Umherirrender) [12:44:03] (CR) Thiemo Mättig (WMDE): [C: 2] Use short array syntax (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394697 (owner: Umherirrender) [12:55:29] (CR) Thiemo Mättig (WMDE): [C: 1] "Full review done. All changes look fine. I do have a few additional suggestions that could be improved either in this patch or a later one" (9 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394721 (owner: Umherirrender) [13:50:50] (PS2) Umherirrender: Add explict var visibility [extensions/PageForms] - https://gerrit.wikimedia.org/r/394672 [13:51:09] (CR) Umherirrender: Add explict var visibility (5 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394672 (owner: Umherirrender) [14:01:47] (PS2) Umherirrender: Use short array syntax [extensions/PageForms] - https://gerrit.wikimedia.org/r/394697 [14:02:55] (CR) Umherirrender: "Patch Set 2: Rebased" [extensions/PageForms] - https://gerrit.wikimedia.org/r/394697 (owner: Umherirrender) [14:10:25] (CR) Umherirrender: "Changes are made when parent's merge conflict is resolved" (4 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394752 (owner: Umherirrender) [14:11:24] (CR) Umherirrender: "Changes are made when the short array patch set is merged and the merge conflict could be resolved easier." (2 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394721 (owner: Umherirrender) [14:25:00] (CR) Thiemo Mättig (WMDE): [C: 1] Add phpcs and make pass (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394721 (owner: Umherirrender) [14:27:16] (CR) Thiemo Mättig (WMDE): [C: 2] Add explict var visibility (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394672 (owner: Umherirrender) [14:28:59] (Merged) jenkins-bot: Add explict var visibility [extensions/PageForms] - https://gerrit.wikimedia.org/r/394672 (owner: Umherirrender) [14:32:46] (CR) Thiemo Mättig (WMDE): [C: -1] "I agree with all your "out of scope" responses. They are not meant as change requests." [extensions/PageForms] - https://gerrit.wikimedia.org/r/394752 (owner: Umherirrender) [15:03:16] (PS4) Umherirrender: Use short array syntax [extensions/PageForms] - https://gerrit.wikimedia.org/r/394697 [15:03:18] (PS2) Umherirrender: Add phpcs and make pass [extensions/PageForms] - https://gerrit.wikimedia.org/r/394721 [15:03:50] (CR) Umherirrender: "Patch Set 2: Addressed comments" (7 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394721 (owner: Umherirrender) [15:33:57] (PS2) Umherirrender: Improve some parameter docs [extensions/PageForms] - https://gerrit.wikimedia.org/r/394752 [15:34:34] (CR) Umherirrender: "Patch Set 2: Addressed inline comments" (30 comments) [extensions/PageForms] - https://gerrit.wikimedia.org/r/394752 (owner: Umherirrender)