[08:30:31] (CR) Joeytje50: "The "typical" maximum width of comments is 80 characters: https://stackoverflow.com/a/578090/1256925 (this is also what I've learned in ev" [extensions/PageForms] - https://gerrit.wikimedia.org/r/360338 (owner: Joeytje50) [08:47:40] SemanticMediaWiki/SemanticFormsSelect#272 (master - dfb9de5 : Jeroen De Dauw): The build was broken. [08:47:40] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/e0e7eaef8d2e...dfb9de591044 [08:47:40] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247426877 [08:48:04] (CR) Joeytje50: Working += and -= functionality. (1 comment) [extensions/PageForms] - https://gerrit.wikimedia.org/r/360811 (owner: Joeytje50) [08:55:19] SemanticMediaWiki/SemanticFormsSelect#273 (rel211 - dfb9de5 : Jeroen De Dauw): The build failed. [08:55:19] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/rel211 [08:55:19] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247429155 [08:57:30] (PS1) Joeytje50: Implement suggested changes code-review [extensions/PageForms] - https://gerrit.wikimedia.org/r/361635 [08:57:36] SemanticMediaWiki/SemanticFormsSelect#274 (rel211 - 364e5d7 : Karsten Hoffmeyer): The build failed. [08:57:36] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/dfb9de591044...364e5d7d1354 [08:57:36] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247429644 [09:04:59] SemanticMediaWiki/SemanticFormsSelect#277 (rel211 - a50eb8d : Karsten Hoffmeyer): The build is still failing. [09:04:59] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/791df6694a99...a50eb8d823c7 [09:04:59] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247431813 [09:05:29] SemanticMediaWiki/SemanticFormsSelect#276 (rel211 - 791df66 : Karsten Hoffmeyer): The build is still failing. [09:05:29] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/e86e3fd811ef...791df6694a99 [09:05:29] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247431284 [09:08:16] (CR) Joeytje50: "I've implemented the changes you suggested (with the asterisk that I only reduced the comments to ~80 characters assuming you use tab widt" [extensions/PageForms] - https://gerrit.wikimedia.org/r/361635 (owner: Joeytje50) [09:08:46] SemanticMediaWiki/SemanticFormsSelect#278 (rel211 - 6f29469 : Karsten Hoffmeyer): The build is still failing. [09:08:46] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/a50eb8d823c7...6f29469e7be3 [09:08:46] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247432417 [09:11:25] SemanticMediaWiki/SemanticFormsSelect#279 (rel211 - 9022625 : Karsten Hoffmeyer): The build is still failing. [09:11:25] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/6f29469e7be3...90226252ed67 [09:11:25] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247432556 [13:38:34] (CR) Yaron Koren: "You make a reasonable point with the tabs - I use vim for my editing, and it defaults to 8 spaces per tab. I'm not sure how I feel about c" [extensions/PageForms] - https://gerrit.wikimedia.org/r/360338 (owner: Joeytje50) [13:49:14] (CR) Yaron Koren: "What about just creating a new patch, with all of your changes in one place?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/361635 (owner: Joeytje50) [14:08:54] (CR) Yaron Koren: "Personally, I think hideIfEmpty() is fine, because the meaning becomes clear from context. isHideIfEmpty() is fine too, even though it's a" [extensions/PageForms] - https://gerrit.wikimedia.org/r/361238 (owner: FreedomFighterSparrow) [14:15:53] SemanticMediaWiki/SemanticFormsSelect#281 (rel211 - 37fa801 : Karsten Hoffmeyer): The build was fixed. [14:15:53] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/90226252ed67...37fa8016b4f8 [14:15:53] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247534415 [14:50:02] (CR) Brian Wolff: "Just so you know, capital links can also be a per namespace setting. It might be better to look at MWNamespace::isCapitalized( $nsId )" [extensions/PageForms] - https://gerrit.wikimedia.org/r/354004 (owner: Yaron Koren) [14:53:52] SemanticMediaWiki/SemanticFormsSelect#283 (master - 6e03026 : Karsten Hoffmeyer): The build was fixed. [14:53:52] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/dfb9de591044...6e0302671c68 [14:53:52] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247551289 [14:56:44] (CR) Brian Wolff: "You may want to consider escaping backslashes too, as php also allows the syntax \1 instead of $1." [extensions/PageForms] - https://gerrit.wikimedia.org/r/359171 (owner: Yaron Koren) [14:56:53] SemanticMediaWiki/SemanticFormsSelect#284 (2.1.1 - 6e03026 : Karsten Hoffmeyer): The build passed. [14:56:53] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/2.1.1 [14:56:53] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247551788 [15:00:47] SemanticMediaWiki/SemanticFormsSelect#285 (dev220 - 6e03026 : Karsten Hoffmeyer): The build passed. [15:00:47] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/dev220 [15:00:47] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247552330 [15:03:08] SemanticMediaWiki/SemanticFormsSelect#286 (dev220 - e1c9c8b : Karsten Hoffmeyer): The build passed. [15:03:08] Change view : https://github.com/SemanticMediaWiki/SemanticFormsSelect/compare/6e0302671c68...e1c9c8b37e42 [15:03:08] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticFormsSelect/builds/247553200