[11:19:11] (CR) Joeytje50: [C: -1] "Never mind these commits; I noticed some changes made here broke the autoedit-functionality. I'm not really able to find the exact place, " [extensions/PageForms] - https://gerrit.wikimedia.org/r/358574 (owner: Joeytje50) [13:10:52] (PS1) Joeytje50: Step one: Split up some variables to support OOP [extensions/PageForms] - https://gerrit.wikimedia.org/r/360337 [13:10:54] (PS1) Joeytje50: Step two: Reduce comments to fewer lines [extensions/PageForms] - https://gerrit.wikimedia.org/r/360338 [13:10:57] (PS1) Joeytje50: Step three: split out several processing functions [extensions/PageForms] - https://gerrit.wikimedia.org/r/360339 [13:10:59] (PS1) Joeytje50: Fixed missing variable; removed some comments [extensions/PageForms] - https://gerrit.wikimedia.org/r/360340 [13:11:01] (PS1) Joeytje50: Step four: Move the entire definition-processing function out [extensions/PageForms] - https://gerrit.wikimedia.org/r/360341 [13:14:41] (CR) Joeytje50: "I re-did the changes I tried to make earlier, to prevent the thing from breaking like it did last time. Because of the major changes I've " [extensions/PageForms] - https://gerrit.wikimedia.org/r/360341 (owner: Joeytje50) [13:58:54] (CR) Yaron Koren: "Sorry - for some reason I'm only seeing all of these patches now. I wish I had seen them earlier!" [extensions/PageForms] - https://gerrit.wikimedia.org/r/358574 (owner: Joeytje50) [14:10:12] (PS2) Joeytje50: Step four: Move the entire definition-processing function out [extensions/PageForms] - https://gerrit.wikimedia.org/r/360341 [15:03:21] (CR) Yaron Koren: "Can this be merged by itself, or does it require other things to be merged first?" [extensions/PageForms] - https://gerrit.wikimedia.org/r/360341 (owner: Joeytje50) [19:56:13] (Draft2) Yaron Koren: Trivial changes [extensions/PageForms] - https://gerrit.wikimedia.org/r/360408