[03:53:59] <grrrit-wm>	 (CR) Yaron Koren: "Sorry for the delay. As I said before, I don't think $sfgWarning is that good a name for this variable. If you were describing this variab" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm)
[11:10:55] <grrrit-wm>	 (PS11) Billm: Apply setting variable instead of direct warning value [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105)
[16:13:08] <grrrit-wm>	 (CR) Billm: "Hi Yaron, it was a mistake I did while committing. Please would you give this another review? Also for the 2nd change in SF_FormEdit.php, " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm)
[16:41:56] <grrrit-wm>	 (CR) Yaron Koren: "Why is the word "Default" in the variable name? If an admin changes it, it's no longer the default value." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm)
[16:58:07] <grrrit-wm>	 (CR) Billm: "True but I was thinking in the light that the value placed in the variable is the default error level. By changing it to "sfgErrorLevel", " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm)
[17:07:43] <grrrit-wm>	 (CR) Yaron Koren: "$sfgErrorLevel would be better (since the word "Default" there doesn't make sense), but I don't know if it's ideal. Again - if you were de" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm)