[00:45:04] (PS1) Billm: Apply setting variable instead of direct warning value [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) [01:03:18] (CR) Yaron Koren: "Have you tried either of these changes to see whether the code still works? My guess is that the first change, with "WARNING", will not wo" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [01:06:42] (CR) Yaron Koren: "I'm glad you're still looking into this! But I think my two comments from before still apply." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [01:15:28] (CR) Billm: "I didn't test the code directly but after having changed it no abnormal behaviour was happening when I went through the software and tried" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [01:19:06] (CR) Billm: "And thanks for your criticism over this patch" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [01:24:35] (CR) Yaron Koren: [C: -2] "Alright. Please test a patch before you submit it." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [09:54:49] (CR) Billm: "I now tried the changes some few hours ago and the code still works. Please I wish to know why your gut feeling was telling you that the c" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [11:00:20] (CR) Nikerabbit: "Why?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/275889 (owner: Yaron Koren) [11:24:47] Hello [11:26:05] Have you create a page to explain how to solve "Too many redirects" issue ? [11:57:03] (CR) 01tonythomas: [C: -1] "Please tag your patch with the correct task in phab, it tries to fix. Thank You. It seems like you meant T46105" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [12:07:55] (CR) Billm: "Sorry and will improve on the next patches" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T89682) (owner: Billm) [12:08:47] (PS2) Billm: Apply setting variable instead of direct warning value [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) [12:48:14] (CR) Yaron Koren: "You can see why in the very next commit:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/275889 (owner: Yaron Koren) [13:43:24] [SemanticMediaWiki] kghbln created messagetweak (+1 new commit): https://git.io/valgU [13:43:24] SemanticMediaWiki/messagetweak ecd96bc Kghbln: Amend system message... [13:44:44] [SemanticMediaWiki] kghbln opened pull request #1457: Amend system message (master...messagetweak) https://git.io/valgW [15:42:03] (CR) Yaron Koren: "By "the code still works", do you mean that you've tried out that particular code? Or do you just mean that Semantic Forms hasn't crashed?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm) [16:03:16] (PS17) Paladox: Updating Maps js file [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [16:07:01] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [16:14:24] (CR) Yaron Koren: "This looks great!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [16:15:55] (PS18) Paladox: Use JS from OpenLayers extension if it is installed [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [16:26:11] (CR) Yaron Koren: [C: 2] "This is great - thank you very much for all your effort!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [16:27:31] (CR) Paladox: "Thanks." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [16:33:10] (CR) Paladox: "What do you we do about extensions using this extension." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [16:36:51] (PS1) Paladox: Update grunt-contrib-jshint to 1.0.0 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277266 [17:04:42] (CR) Paladox: "recheck" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277266 (owner: Paladox) [17:08:18] (CR) Yaron Koren: [C: 2] Update grunt-contrib-jshint to 1.0.0 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277266 (owner: Paladox) [17:18:30] (CR) Paladox: "@Yaron Koren this needs re C+2 reason because zuul was restarted because it froze." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277266 (owner: Paladox) [18:50:35] (CR) Yaron Koren: [C: 2] "Thank you!" [extensions/SemanticInternalObjects] - https://gerrit.wikimedia.org/r/276953 (owner: Kghbln) [22:09:27] (CR) Billm: "@Yaron: I just wanted to mean that Semantic Forms didn't crash and was still working as usual" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/277179 (https://phabricator.wikimedia.org/T46105) (owner: Billm)