[03:25:45] (CR) Yaron Koren: "Alright. A few more questions/comments:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [09:41:59] [SemanticMediaWiki] JeroenDeDauw pushed 2 new commits to master: https://git.io/vgEHD [09:41:59] SemanticMediaWiki/master dd75c60 Translation updater bot: Localisation updates from https://translatewiki.net.... [09:41:59] SemanticMediaWiki/master 4ce5137 Translation updater bot: Localisation updates from https://translatewiki.net.... [11:02:44] I am trying to use SolrStore extension for improving SMW search.The SOLR installation zip does not possess any .war file anymore, which SolrStore says to copy into the tomcat/webapps folder. Also, after installing the extension and clicking on the Solr Search option on Special page, it says "You have requested an invalid Special page." [11:02:57] Can someone pls help how to use the extension [11:18:10] I am trying to use SolrStore extension for improving SMW search.The SOLR installation zip does not possess any .war file anymore, which SolrStore says to copy into the tomcat/webapps folder. Also, after installing the extension and clicking on the Solr Search option on Special page, it says "You have requested an invalid Special page." [11:18:17] what to do now? [12:15:44] I am trying to use SolrStore extension for improving SMW search.The SOLR installation zip does not possess any .war file anymore, which SolrStore says to copy into the tomcat/webapps folder. Also, after installing the extension and clicking on the Solr Search option on Special page, it says "You have requested an invalid Special page." [12:16:34] Searching in the search text box also gives the error: "Declaration of SolrResult::getTitleSnippet() should be compatible with SearchResult::getTitleSnippet() " [17:11:52] (PS1) Yaron Koren: Fixed #formredlink with 'create page' - was making blank pages [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269434 [17:13:09] (CR) Yaron Koren: [C: 2 V: 1] Fixed #formredlink with 'create page' - was making blank pages [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269434 (owner: Yaron Koren) [19:33:54] morning Yaron, hopefully an NDA coming your way today....gotta keep on the boss about that [19:50:45] This isn't really the place to discuss that sort of thing... [19:51:38] Not that it's secret or anything; I just don't want to clog up the channel. [20:15:28] (CR) Nikerabbit: "I am wondering whether these patches are tested at all..." (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267411 (owner: Paladox) [20:16:06] Yaron: ^ [20:16:34] (CR) Paladox: "Yes they are but I am wondering why they are failing for one of the repos in GitHub but not when testing on a website." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267411 (owner: Paladox) [20:17:40] (CR) Nikerabbit: "The actual error is:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267411 (owner: Paladox) [20:21:23] (PS1) Paladox: Follow-up: I04679e8f6f895b97b7bafd36916aeb2e79d3dd25 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 [20:22:11] (CR) jenkins-bot: [V: -1] Follow-up: I04679e8f6f895b97b7bafd36916aeb2e79d3dd25 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:22:15] (CR) Paladox: "Sorry. I fixed it here https://gerrit.wikimedia.org/r/#/c/269479/ if you could review since I also discovered that anothing configs path s" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267411 (owner: Paladox) [20:23:00] (PS2) Paladox: Follow-up: I04679e8f6f895b97b7bafd36916aeb2e79d3dd25 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 [20:23:35] (CR) Nikerabbit: Follow-up: I04679e8f6f895b97b7bafd36916aeb2e79d3dd25 (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:25:18] (PS3) Paladox: Follow-up: I04679e8f6f895b97b7bafd36916aeb2e79d3dd25 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 [20:25:58] (CR) Paladox: Follow-up: I04679e8f6f895b97b7bafd36916aeb2e79d3dd25 (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:28:48] (CR) Yaron Koren: "This doesn't seem like enough... $sfgIP is used in other files, so I would think those other files need to change as well, if you're chang" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:30:49] (CR) Paladox: "@Yaron Koren ive reverted that change so I am not chaning $sfgIP. I will do that If any users are having problems with that." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:31:30] (CR) Paladox: "Woops sorry I am. I am changing from __FILE__ to __DIR__." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:33:55] (CR) Paladox: "Would dirname( __DIR__ ) work. Or should I change it to __DIR__ . '/../'" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:34:49] (CR) Nikerabbit: "Unless I am mistaken, the only place where sfgIP is used is includes/SF_AutoeditAPI.php." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:36:18] (CR) Paladox: "We would need to keep that for compatibility reasons so yes we would have to return a constant." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:39:08] (CR) Paladox: "If the function would be emptied would it cause an error. So if I was todo an if statement and say only mediawiki 1.21 or lower could use " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:42:46] (CR) Yaron Koren: [C: 2] "Actually, I was wrong - this looks good, looking at it again. Thanks for the fix!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:43:44] (CR) Paladox: "Oh so the config doesn't cause any problems." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:44:03] (CR) Yaron Koren: "Paladox - thanks for the fix; and Nikerabbit - thanks for spotting the error." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267411 (owner: Paladox) [20:44:05] (CR) Paladox: "Thanks." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:47:32] (CR) Yaron Koren: "I understand; I don't really do that either. :) (I mostly test SF with Cargo.)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:48:38] (CR) Paladox: "Yes. Sorry for not catching the error. But I belive there should be little error now. Ive had a big look at the paths and all look ok." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/269479 (owner: Paladox) [20:57:47] [SemanticMediaWiki] JeroenDeDauw pushed 1 new commit to master: https://git.io/vggma [20:57:47] SemanticMediaWiki/master 6919d3b Translation updater bot: Localisation updates from https://translatewiki.net.... [21:21:37] ~ /query Yaron undestood [21:22:01] doh! [23:09:09] (PS1) Foxtrott: Fix classname of datpicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/269550 [23:09:44] (CR) Foxtrott: [C: 2 V: 2] Fix classname of datpicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/269550 (owner: Foxtrott)