[16:12:52] [SemanticMediaWiki] kghbln created issue1390 (+1 new commit): https://git.io/vgcPH [16:12:52] SemanticMediaWiki/issue1390 a46069d Kghbln: Add PLURAL support to system message... [16:13:52] [SemanticMediaWiki] kghbln opened pull request #1403: Add PLURAL support to system message (master...issue1390) https://git.io/vgcXe [16:20:28] (CR) Yaron Koren: "@Paladox - is this ready for review?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [16:22:23] (CR) Paladox: "@Yaron Koren Ok. yes ready for review I can do the map thing in a separate review. Please reply either yes or no for separating map chang" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [16:26:23] (CR) Yaron Koren: "Cool. Yes! Definitely yes." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [16:27:07] (CR) Paladox: "Ok. I will do that in a sec." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [16:59:49] (PS58) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [17:00:16] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [17:01:58] (PS59) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [17:05:16] (PS1) Paladox: Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [17:06:10] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [17:06:33] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [17:07:29] (CR) Paladox: "@Yaron Koren ok ive have moved the maps change to https://gerrit.wikimedia.org/r/#/c/268694/ and changed it here so the change isent done " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [17:07:47] (CR) Paladox: "@Yaron Koren please review." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [17:35:23] (CR) Yaron Koren: "This is great! I haven't tested it, but I looked through all the changes, and I have the following questions and comments:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [18:14:16] (PS3) Foxtrott: Remove direct insertions of JS into the page HTML [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 [18:19:19] (CR) Yaron Koren: "@Foxtrott - am I supposed to review/merge this?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 (owner: Foxtrott) [18:20:48] (CR) Foxtrott: "Yes, please. :)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 (owner: Foxtrott) [18:25:35] (CR) Paladox: "@Yaron Koren here are the answers to your questsion following in your order of questions starting from 1" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [18:26:49] (PS60) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [18:28:20] (PS2) Paladox: Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [18:32:33] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [18:56:10] (CR) Yaron Koren: "@Foxtrott - the SFI "datepicker" input type doesn't work with this patch, though then again it doesn't work without the patch either. :) I" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 (owner: Foxtrott) [19:00:34] (CR) Yaron Koren: "Thanks. I still think those three files - libs/SF_maps.js, includes/forminputs/SF_OpenLayersInput.php, and includes/forminputs/SF_GoogleM" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [19:00:37] (CR) Foxtrott: "The datepicker input uses more Javascript put directly into the HTML code. I am working on that right now." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 (owner: Foxtrott) [19:08:30] (CR) Yaron Koren: [C: 2 V: 1] "Alright, cool." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 (owner: Foxtrott) [19:15:26] (Merged) jenkins-bot: Remove direct insertions of JS into the page HTML [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268244 (owner: Foxtrott) [21:17:54] (PS61) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [21:18:14] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [21:18:44] (CR) jenkins-bot: [V: -1] Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [21:37:58] (PS62) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [21:38:24] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [21:38:55] (CR) jenkins-bot: [V: -1] Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [21:44:10] (PS63) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [21:47:12] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [21:48:35] (PS64) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [21:56:46] (PS3) Paladox: Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [21:57:04] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [21:57:38] (CR) Paladox: "@Yaron Koren Ok done ive moved the changes as you suggested." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [21:57:54] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [22:11:09] (CR) Yaron Koren: "Okay, I tried it out, and everything works well!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [22:12:08] (CR) Paladox: "Yes ok I will do that now." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [22:13:06] (PS1) Yaron Koren: Fixed tabbing in SF_GoogleMapsInput.php [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268812 [22:14:14] (PS65) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [22:14:31] (PS4) Paladox: Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [22:14:44] (CR) Yaron Koren: [C: 2 V: 1] Fixed tabbing in SF_GoogleMapsInput.php [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268812 (owner: Yaron Koren) [22:15:15] (CR) jenkins-bot: [V: -1] Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [22:15:17] (PS5) Paladox: Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [22:16:28] (PS66) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 [22:16:43] (CR) jenkins-bot: [V: -1] Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [22:21:13] (PS6) Paladox: Update maps [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 [22:21:40] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [22:21:59] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268694 (owner: Paladox) [22:28:32] (CR) Paladox: "@Yaron Koren ok done. I have done the autoload.php change in https://gerrit.wikimedia.org/r/#/c/268694/" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [22:51:24] (PS1) Foxtrott: Add input type datepicker to SemanticForms [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268820 [22:52:46] (PS2) Foxtrott: Add input type datepicker to SemanticForms [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268820 [23:00:13] (PS1) Foxtrott: Remove input type datepicker; follow changed input type registration in SF 3.4.3 [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/268824 [23:00:33] (CR) jenkins-bot: [V: -1] Remove input type datepicker; follow changed input type registration in SF 3.4.3 [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/268824 (owner: Foxtrott) [23:02:53] (CR) Foxtrott: [C: 2 V: 2] Remove input type datepicker; follow changed input type registration in SF 3.4.3 [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/268824 (owner: Foxtrott) [23:03:52] (PS3) Foxtrott: Add input type datepicker to SemanticForms [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/268820 [23:04:02] (CR) jenkins-bot: [V: -1] Remove input type datepicker; follow changed input type registration in SF 3.4.3 [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/268824 (owner: Foxtrott) [23:58:14] (CR) Paladox: "recheck" [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/268824 (owner: Foxtrott)