[01:19:07] Hey Yaron can you help me understand one quick one [01:42:35] (CR) Yaron Koren: "@Paladox - this is great! I'm glad it takes care of the bugs. I have two comments:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [02:13:37] Deep6: what's going on? [02:18:32] hey sorry [02:18:37] just got back [02:18:51] so I have a field with a default=now [02:19:00] but... I have that as a conditional [02:19:04] show [02:19:18] but regardless of whether it's shown or not it saves to the form [02:19:24] sorry to the template [02:38:16] Deep6: you can just have the template not show that value, if it's not supposed to be shown. [02:39:55] oh how do I do that? [02:40:08] a conditional show of the value [02:40:09] ? [02:41:02] and is that conditional show predicated on a different value [02:41:22] i.e for me I have a field Has DNS Disabled (boolean) [02:41:46] and I have Has DNS Disabled Date (date) [06:47:39] (CR) Nikerabbit: [C: -1] "This doesn't seem to make any sense and does not explain what problem it is solving. No other extension does this." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267155 (owner: Paladox) [06:58:43] (CR) Nikerabbit: [C: -1] Fix $sfgFormPrinter setting, Also move hook AdminLinks to extension functions (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [07:31:36] (CR) Florianschmidtwelzow: [C: -1] "And it, btw., shouldn't be needed. Like Nikerabbit: I would be happy to read a detailed explanation about what you're trying to fix and wh" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267155 (owner: Paladox) [08:30:07] (CR) Paladox: "Hi because if we load this extension through other extensions such as SemanticFormsSelect when it try's to find extension.json it will loo" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267155 (owner: Paladox) [08:34:59] (CR) Paladox: "@Yaron Koren the define carnt go anywhere else since in extension.json it is very hard to use define since it is not supported fully." (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [13:53:42] (CR) Nikerabbit: "There is already core config to define where extensions are placed in." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267155 (owner: Paladox) [15:12:40] (CR) Paladox: "Hi could I have help to do that please." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267155 (owner: Paladox) [16:03:01] (CR) Yaron Koren: "This might sound extreme, but - maybe it's worth once again disabling the use of extension.json until a later MediaWiki version (1.27, may" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [16:14:06] (CR) Paladox: "Hi I belive the issue will be fixed in this patch. Since I have been doing some testing." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [16:38:59] (CR) Yaron Koren: "Well, I know of three remaining issues:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [16:42:54] (CR) Paladox: "Ok I will do some testing with some fixes I think should work. Just need to upload the files to my website which I am doing now to start s" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [16:49:27] (PS1) Yaron Koren: Temporarily disabling use of extension.json, due to ongoing issues [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267275 [16:53:55] (PS5) Paladox: Fix $sfgFormPrinter setting, Also move hook AdminLinks to extension functions [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) [16:54:59] (CR) Paladox: [C: -1] "Ive found a fix. Please see https://gerrit.wikimedia.org/r/#/c/267161/ patch again." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267275 (owner: Yaron Koren) [16:55:26] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [16:58:37] (CR) Paladox: "@Yaron Koren please review. Also does this fix the 3 problems that people are having. Also I doint need to include the define in the names" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:09:58] (PS6) Paladox: Move defined( 'SF_VERSION' ) down to below wfLoadExtension call [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) [17:11:04] (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:11:59] (CR) Paladox: "Ive tested this on my wiki and none off the errors shows now. It all works as expected including SemanticFormsSelect." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:12:15] (CR) Paladox: "@Yaron Koren could you merge this please." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:25:16] (CR) Paladox: "I will add" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267155 (owner: Paladox) [17:38:04] (CR) Yaron Koren: "Cool. Shouldn't the defined() check still be at the top, though?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:39:16] (CR) Paladox: "No I thought that but did a test and seems that it works now. Tested it with another extension and the define in that extension detects it" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:42:46] (CR) Yaron Koren: "Do you mean that it fails if the "if defined()" check is at the top? If so, do you know why?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:44:55] (CR) Paladox: "Because it was defined twice once on top of the function that calls extension.json and again in the callback inside the extension.json fil" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:47:21] (CR) Yaron Koren: "No, I understand why the define() call has to be lower, but I'm talking about the *defined()* call. Are you sure it has to move? I just wa" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:49:41] (CR) Paladox: "Well as the function is made to be at the top and we also use that defined in extension.json callback it is causing an error because it sa" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:53:52] (CR) Yaron Koren: "I am sorry to drag out this conversation, but I simply don't understand: if SemanticForms.php is being bypassed, what does it matter where" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [17:55:57] (CR) Paladox: "Because we want to make sure we doint break extensions detecting if the extension is installed through define." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:00:54] (CR) Yaron Koren: "Sorry, I think you misunderstood my question." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:03:14] (CR) Paladox: "Because if we also use it in the extension.json callback they will cause the extension to stop working because return 1 will only allow th" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:16:19] (CR) Florianschmidtwelzow: "Removing myself as reviewer. One comment only (which might be false, because I looked over the change very fast): I think you would have l" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:20:15] (CR) Paladox: "I think he is keeping it for compatibility reasons." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:23:35] (CR) Yaron Koren: "@Paladox - I simply don't understand your explanation, maybe because you keep using the word "it" to refer to different things. Could you " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:25:57] (CR) Paladox: "Ok I am." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [18:49:39] (CR) Yaron Koren: [C: 2] "Alright - I confess that I still don't understand, but I trust that you know what you're doing. Thank you!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox) [23:32:13] (CR) Paladox: "Thanks." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/267161 (https://phabricator.wikimedia.org/T124149) (owner: Paladox)