[14:01:45] <bb8r2d2>	 hi what visual editor works with current mediawiki stable release and semantic forms
[14:02:00] <bb8r2d2>	 i want a text editor bar in the freetext area
[15:07:14] <bb8r2d2>	 and for that matter, if i want to use semantic forms  which version of semantic mediawiki should i use with current stable mediawiki version
[15:37:15] <bb8r2d2>	 WikiEditor doesn't show formatted preloaded text so im wondering if there is something else?
[15:55:36] <bb8r2d2>	 The Editor essentially shows Wiki Markup  and i dont what it to
[16:07:07] <bb8r2d2>	 .j mediawiki
[16:13:17] <grrrit-wm>	 (PS1) Yaron Koren: Added catching of Cargo exceptions [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/263622
[16:19:30] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] Added catching of Cargo exceptions [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/263622 (owner: Yaron Koren)
[16:29:13] <bb8r2d2>	 Does VisualEditor Work in the free text area?
[16:31:45] <grus>	 bb8r2d2 I think it is, but did not install on my system
[16:32:06] <grus>	 but as far as I know Wikipedia uses VisualEditor, you can try there after login
[16:33:15] <grus>	 bye for now
[18:23:28] <grrrit-wm>	 (PS1) Yaron Koren: Removed/replaced more global vars ($wgOut, etc.) [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/263636
[18:42:30] <grrrit-wm>	 (CR) Yaron Koren: [C: 2] Removed/replaced more global vars ($wgOut, etc.) [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/263636 (owner: Yaron Koren)
[19:30:54] <grrrit-wm>	 (CR) Yaron Koren: "@Paladox - sorry for the delay! I finally tested out the code, and found one issue - see the comment." (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:07:26] <grrrit-wm>	 (CR) Paladox: Replace usage of addScript with addModules (1 comment) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:09:36] <grrrit-wm>	 (PS15) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[20:10:00] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:11:50] <grrrit-wm>	 (PS3) Paladox: Use ResourceLoader::makeInlineScript instead of Html::inlineScript [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221)
[20:11:58] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[20:12:12] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren please review." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[20:22:02] <grrrit-wm>	 (PS28) Paladox: Fix jshint errors, Also run npm and composer tests [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678
[20:22:35] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox)
[20:33:54] <grrrit-wm>	 (CR) Yaron Koren: "That's still not quite correct - there's a missing ' on that line, I think." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:45:24] <grrrit-wm>	 (CR) Paladox: "Ok but that would include js code that would be required in the wrong places in php since it would load it twice if we were to require the" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:45:47] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren what would the code look like." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:50:26] <grrrit-wm>	 (CR) Yaron Koren: "It's a good idea - but does Html::inlineScript() still need to be included?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[20:51:23] <grrrit-wm>	 (CR) Paladox: "Yes." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[20:52:10] <grrrit-wm>	 (CR) Yaron Koren: "There's no reason to require the module twice, is there? I'm thinking you could just remove the 2nd call to addModules()." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:55:43] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren what should the code be like in https://gerrit.wikimedia.org/r/#/c/258688/15/libs/SF_CreateTemplate.js I'm unsure what you me" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[20:58:19] <grrrit-wm>	 (PS16) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[21:00:00] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[21:01:14] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren please review." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox)
[21:05:00] <grrrit-wm>	 (CR) Yaron Koren: "Cool, that looks good. The only issue I see now is that that line of CreateTemplate.js is still not correct - I assume you've never tried " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[21:05:17] <grrrit-wm>	 (PS17) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[21:08:07] <grrrit-wm>	 (CR) Yaron Koren: "Are you sure? RL::makeInlineScript() already calls Html::inlineScript(). Wouldn't this lead to one <script> tag inside another?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[21:08:19] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren no I doint try this because I would not know what I would be looking error wise. And I am not sure if semantic mediawiki need" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[21:09:49] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren @Krinkle who is the head of the resourceloader team I think for mediawiki said to keep inline:: but too add ResourceLoader::m" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[21:10:20] <grrrit-wm>	 (CR) Paladox: "Adding @Krinkle." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[21:10:47] <grrrit-wm>	 (CR) Yaron Koren: "No, it's still not correct - it should be + , not '+' ." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[21:12:07] <grrrit-wm>	 (PS18) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[21:13:41] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[21:16:08] <grrrit-wm>	 (CR) Yaron Koren: "SF_maps.js seems to have the same problem as before, unless I'm missing something. I really think you should install SF and try this out y" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox)
[21:17:03] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren what problem is SF_maps.js having." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox)
[21:30:00] <grrrit-wm>	 (CR) Yaron Koren: "I haven't tested this version, but I assume it has the same problem as before - you're creating parameters called "google" and "OpenLayers" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox)
[23:07:16] <grrrit-wm>	 (CR) Paladox: "I just relooked at code and I think I put it into the wrong place. I think it needs to be switched around" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221) (owner: Paladox)
[23:10:57] <grrrit-wm>	 (PS4) Paladox: Use ResourceLoader::makeInlineScript instead of Html::inlineScript [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221)
[23:12:43] <grrrit-wm>	 (PS5) Paladox: Use ResourceLoader::makeInlineScript instead of Html::inlineScript [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262371 (https://phabricator.wikimedia.org/T121221)