[00:35:06] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren or @TheDJ please could you review this patch." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[10:46:41] <grrrit-wm>	 (CR) D3r1ck01: "Hi Yaron Koren, the class "error" is defined in a CSS file in mw-config/config.css from the wikimedia root directory. In the CSS file from" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[16:29:47] <grrrit-wm>	 (CR) Yaron Koren: "Sorry about that - I'll fix those later today." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262327 (owner: Yaron Koren)
[17:41:28] <createproperty>	 Hey, so I'm using the semantics form extension for mediawiki and the tutorial mentioned that there should be a special page called createproperty but it does not exist in the list of special pages. Is this normal?
[20:21:31] <grrrit-wm>	 (PS1) Yaron Koren: More fixes for formHTML() -> SFFormField moves [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262753
[20:23:20] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] More fixes for formHTML() -> SFFormField moves [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262753 (owner: Yaron Koren)
[20:24:00] <grrrit-wm>	 (CR) Yaron Koren: "Okay, I think these are all fixed now." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/262327 (owner: Yaron Koren)
[20:42:25] <grrrit-wm>	 (CR) Yaron Koren: "Thanks for this change, and the information - this looks like a great change, which gets rid of both outdated HTML and unnecessary hardcod" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[21:58:42] <smw-github>	 [SemanticMediaWiki] kghbln created issue1350 (+1 new commit): https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/bbe9be8ed056
[21:58:42] <smw-github>	 SemanticMediaWiki/issue1350 bbe9be8 Kghbln: Enlarged input field on special page "Browse"...
[21:59:34] <smw-github>	 [SemanticMediaWiki] kghbln opened pull request #1352: Enlarged input field on special page "Browse" (master...issue1350) https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/1352
[22:23:51] <smw-github>	 [SemanticMediaWiki] kghbln created www (+1 new commit): http://git.io/vuVbJ
[22:23:51] <smw-github>	 SemanticMediaWiki/www 1d6d775 Kghbln: Swap to https://www...
[22:24:51] <smw-github>	 [SemanticMediaWiki] kghbln opened pull request #1353: Swap to https://www... (master...www) http://git.io/vuVbs
[22:44:36] <grrrit-wm>	 (CR) D3r1ck01: "Yaron, how do you think we can fix line 317? Should we just replace 'font' with 'span'? What are your suggestions?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:46:42] <grrrit-wm>	 (CR) Paladox: "Yes please. font should be replaced with span and the error class added and colour removed." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:50:30] <grrrit-wm>	 (PS3) D3r1ck01: Removed deprecated <font> tags from SF [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911)
[22:52:02] <grrrit-wm>	 (CR) D3r1ck01: "Paladox, changes has been made and tested. It works fine for me. Review and give feedback :)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:53:04] <grrrit-wm>	 (CR) Paladox: "Thanks. I have now reviewed and all looks good." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:53:11] <grrrit-wm>	 (CR) Paladox: [C: 1] Removed deprecated <font> tags from SF [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:54:54] <grrrit-wm>	 (CR) D3r1ck01: "Hey, its kind of our job to make sure the codes are most perfect. Thanks too for the collaboration to make it work :)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:55:55] <grrrit-wm>	 (CR) D3r1ck01: "So is someone else going to +2 this for it to be merged? :)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:58:56] <d3r1ck>	 Hey, i never knew there was a channel like this :)
[22:59:06] <d3r1ck>	 Media Wiki really has many channels :)
[22:59:13] <grrrit-wm>	 (CR) Paladox: "Yes it would have to be Yaron Koren or the other code reviewers that have +2." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[22:59:28] <d3r1ck>	 paladox: hey, so you are here, why are you not in wikimedia-dev?
[23:00:48] <paladox>	 d3r1ck: Hi i am in the channels wikimedia-releng and mediawiki. Im in this one here because i am asking for help related to fixing a hook that is breaking the web updater
[23:02:14] <d3r1ck>	 paladox: ohhh, i see. Thats cool.
[23:02:26] <d3r1ck>	 paladox: so the changes, it is ok?
[23:03:20] <paladox>	 d3r1ck: Yes they look ok. A user named TheDJ who works at wikimedia or i think he does anyways suggested to do that.
[23:05:09] <d3r1ck>	 yeah. I have realized that Open Source mostly work very well with a team than an individual :)
[23:06:11] <paladox>	 d3r1ck: Yes.
[23:18:11] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] "This is great! Thanks to both of you for your efforts!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[23:21:02] <grrrit-wm>	 (CR) D3r1ck01: "Yaron Koren, whats your IRC nick so we can have a chat on IRC please?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/261764 (https://phabricator.wikimedia.org/T121911) (owner: D3r1ck01)
[23:22:55] <grrrit-wm>	 (CR) Paladox: "@Yaron Koren could you review this please." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258676 (https://phabricator.wikimedia.org/T121322) (owner: Paladox)
[23:26:25] <grrrit-wm>	 (PS12) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[23:35:49] <grrrit-wm>	 (PS13) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[23:36:41] <grrrit-wm>	 (CR) Paladox: "Adding @Krinkle since he is with the resource loader team. So he may be able to help migrate any code to the new way. and also give feedba" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[23:39:18] <grrrit-wm>	 (PS14) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688
[23:39:43] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[23:40:04] <grrrit-wm>	 (CR) Paladox: "check experimental" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)
[23:46:25] <d3r1ck>	 paladox: You want me to review?
[23:47:21] <paladox>	 d3r1ck: Yes please. You may spot something i havent or you may think a change i did needs a ajustment or code change.
[23:47:47] <d3r1ck>	 paladox: Ok
[23:49:28] <paladox>	 d3r1ck: Thanks.
[23:50:17] <grrrit-wm>	 (PS26) Paladox: Fix extension registration support [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258676 (https://phabricator.wikimedia.org/T121322)