[03:34:34] (CR) Yaron Koren: "Paladox - this is great! Thank you for the effort you've put in already. Moving all the inline JS into its own files is something that's b" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox) [14:37:39] (PS4) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 [14:38:16] (CR) jenkins-bot: [V: -1] Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox) [14:40:07] (PS5) Paladox: Replace usage of addScript with addModules [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 [14:49:48] (CR) Paladox: "Two files left to convert" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox) [14:50:02] (CR) Paladox: "I haven't tested this." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox) [16:58:03] [SemanticMediaWiki] paladox opened pull request #1307: Update composer.json (master...patch-4) http://git.io/v0CGY [16:59:47] [SemanticMediaWiki] paladox opened pull request #1308: Faster builds (master...patch-5) http://git.io/v0CGz [17:30:32] [SemanticMediaWiki] mwjames closed pull request #1308: Faster builds (master...patch-5) http://git.io/v0CGz [20:21:53] [SemanticMediaWiki] paladox closed pull request #1307: Update composer.json (master...patch-4) http://git.io/v0CGY [20:22:33] [SemanticMediaWiki] paladox opened pull request #1310: Update composer.json (master...patch-6) http://git.io/v0WIi [22:44:55] (PS1) Reedy: Replace deprecated loadContent with fetchContent [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258900 [23:04:13] (CR) Yaron Koren: "Perhaps loadContent() should just be removed, since fetchContent() is already called in the next line?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258900 (owner: Reedy) [23:05:04] (PS1) Reedy: Replace deprecated editToken with getEditToken [extensions/SemanticPageMaker] - https://gerrit.wikimedia.org/r/258908 [23:07:09] (PS2) Reedy: Remove deprecated loadContent [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258900 [23:08:44] (CR) Yaron Koren: "Paladox - this is great! Having JS that is well-formatted and passes the tests will be a big step forward." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [23:09:53] (CR) Yaron Koren: [C: 2] Remove position from ext.semanticforms.wikieditor module [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258681 (owner: Paladox) [23:15:10] (CR) Yaron Koren: "Paladox - thank you for the further changes, although this patch is not yet usable, as you've probably guessed." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox) [23:26:24] (CR) Yaron Koren: [C: 2] "Thank you!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258900 (owner: Reedy) [23:26:57] (Merged) jenkins-bot: Remove deprecated loadContent [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258900 (owner: Reedy) [23:31:49] (CR) Paladox: "Ok. Could I have help on doing that part and making this usable please." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox) [23:49:56] (CR) Paladox: "Ok I will split them up I will do the smaller changes which have less code changes is what I mean." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258678 (owner: Paladox) [23:59:52] (CR) Yaron Koren: "I looked more closely into your changes, and I see now that you're further along than I thought you were; although it's still not fully do" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/258688 (owner: Paladox)