[00:00:28] (CR) Yaron Koren: [C: 2 V: 1] Removed/replaced some unnecessary calls to SFUtils::addJavascriptAndCSS() [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251904 (owner: Yaron Koren) [00:23:03] (PS1) Yaron Koren: Removed some usage of globals like $wgOut, $wgRequest [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251905 [00:24:41] (CR) Yaron Koren: [C: 2 V: 1] Removed some usage of globals like $wgOut, $wgRequest [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251905 (owner: Yaron Koren) [04:32:50] [SemanticMediaWiki] JeroenDeDauw pushed 1 new commit to master: http://git.io/v8ESv [04:32:52] SemanticMediaWiki/master fc991c4 Translation updater bot: Localisation updates from https://translatewiki.net.... [05:43:57] [SemanticMediaWiki] JeroenDeDauw created JeroenDeDauw-patch-1 (+1 new commit): http://git.io/v8uf5 [05:43:57] SemanticMediaWiki/JeroenDeDauw-patch-1 b67290b Jeroen De Dauw: Add Composer cache to TravisCI [05:44:27] [SemanticResultFormats] JeroenDeDauw pushed 1 new commit to master: http://git.io/v8ufp [05:44:27] SemanticResultFormats/master abb0c93 Jeroen De Dauw: Add Composer cache to TravisCI [05:44:38] [SemanticMaps] JeroenDeDauw pushed 1 new commit to master: http://git.io/v8uJJ [05:44:38] SemanticMaps/master d9844e8 Jeroen De Dauw: Add Composer cache to TravisCI [05:58:32] SemanticMediaWiki/SemanticMediaWiki#4624 (JeroenDeDauw-patch-1 - b67290b : Jeroen De Dauw): The build has errored. [05:58:32] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/b67290b5011c [05:58:32] Build details : https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/90035273 [13:35:43] [SemanticMediaWiki] mwjames closed pull request #1262: Add Composer cache to TravisCI (master...JeroenDeDauw-patch-1) http://git.io/v8ufd [13:35:49] [SemanticMediaWiki] mwjames deleted JeroenDeDauw-patch-1 at b67290b: http://git.io/v8g76 [14:52:43] (CR) Yaron Koren: [C: 2] "Thank you!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251476 (owner: Robert Vogel) [14:53:56] (Merged) jenkins-bot: SF_UploadWindow: Fixed hook parameter [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251476 (owner: Robert Vogel) [15:10:50] (PS1) Yaron Koren: Renamed SFUtils::addJavascriptAndCSS() to addFormRLModules() [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251965 [15:13:02] (CR) Yaron Koren: [C: 2 V: 1] Renamed SFUtils::addJavascriptAndCSS() to addFormRLModules() [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251965 (owner: Yaron Koren) [15:22:04] (PS1) Nikerabbit: Stop duplicating header of empty section as contents of ultimate section [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251967 (https://phabricator.wikimedia.org/T72202) [15:23:16] Yaron: wana review some of my patches as well? I fixed some annoying bugs [15:40:01] [SemanticMaps] hangya closed pull request #47: Update SM_MapPrinter.php (master...master) http://git.io/v8Zu3 [15:52:57] Yaron: :o [16:00:55] [SemanticMediaWiki] hangya opened pull request #1264: Removed pg_unescape_bytea-ing the result (master...master) http://git.io/v8aOE [16:40:26] Nikerabbit: sorry! I just saw this now. [16:40:33] Yes, I do! Thank you for all your patches! [16:40:47] It's a lot to review... I hope to get to it all today. [16:53:41] Yaron: np... I hope they cause no regressions this time [17:00:46] (CR) Yaron Koren: "@Foxtrott - oops, sorry, I added you as a reviewer because I thought you had originally written this code, but now I see that it was writt" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251823 (owner: Nikerabbit) [17:07:49] (CR) Yaron Koren: "Nikerabbit - this looks great! But should "celement" be just "element" on line 1165?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251829 (owner: Nikerabbit) [17:13:12] (CR) Yaron Koren: [C: 2] "Great - thank you!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251967 (https://phabricator.wikimedia.org/T72202) (owner: Nikerabbit) [17:16:28] Yaron: absolutely [17:16:54] (PS2) Nikerabbit: Small cleanup to JavaScript code for dependent fields [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251829 [17:26:41] Nikerabbit: what's the deal with changing "jQuery" to "$"? I never know which one to use, and the mediawiki.org "coding conventions" page doesn't explicitly say. [17:27:02] Is "$" just generally preferred? [17:28:47] Yaron: in MediaWiki everyone uses $, but they also use (function ( $ ) { code goes here })( jQuery ); [17:29:50] Alright... [17:30:50] Yaron: I noticed both are used on that file, so I just went with $ by habit [17:32:12] Well, consistency makes sense. [17:42:45] (CR) Yaron Koren: [C: 2] "This is a nice improvement - thank you!" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251829 (owner: Nikerabbit) [19:34:59] I'm trying to upgrade a MediaWiki and I have some issues with upgrading from SemanticWeb from 1.8 to 2.3. Or I think it's Semantic_Forms that's causing the problems.. The Forms Special page is empty and I don't get a "Edit this form" on pages with forms.. Any suggestions to what's wrong? I've never used SemanticWeb before :) [19:35:48] empty? completely white page? [19:37:29] "There are no result for this report" [19:37:53] ok I dunno then [19:38:41] ok... No php errors in any of the logs... [21:36:44] (CR) Yaron Koren: "Hi - "values dependent on" already works for me, when both fields are of type "combobox". What combination(s) of input types don't work wi" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251828 (owner: Nikerabbit) [21:50:24] (CR) Nikerabbit: "Snippet:" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251828 (owner: Nikerabbit) [21:59:57] (CR) Yaron Koren: [C: 2 V: 1] "Nikerabbit - fantastic, thanks! I just tried it, and it seems to work the same (but better). I don't know why the original author went wit" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/251823 (owner: Nikerabbit) [22:07:18] (CR) Cicalese: "Karsten, this change seems perfectly reasonable. Would it be possible for you please to fix the name of Bernadette's user page in the comm" [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln) [22:22:45] (PS3) Kghbln: Increment version to v2.2.1 [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 [22:24:55] (CR) Cicalese: [C: 2 V: 2] Increment version to v2.2.1 [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln) [22:25:21] (CR) Kghbln: "Heiya Cindy, no problem at all. I ended up moving this section to the top to make it more visible. The riverbees are out there now. :) Bes" [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln) [22:26:52] (CR) Cicalese: "Thank you, Karsten - will do!" [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln) [22:36:52] (CR) Kghbln: "Thanks! :) What is still needed is to tag this version, probably previous releases too though this is not as important any longer." [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln) [22:46:16] (CR) Cicalese: "Done! I just tagged 2.2.1. Yes, it would have been a good idea to tag the previous releases as well. I just learned how to do that with ge" [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln) [22:52:43] (CR) Kghbln: "Cool, it's there. Thanks a bunch. :)" [extensions/SemanticRating] - https://gerrit.wikimedia.org/r/251705 (owner: Kghbln)