[08:02:45] (CR) Tpt: [C: -1] "Thank you very much for this change!" [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [08:07:59] (CR) Tpt: "A third point: please, use when it's possible "private" or "protected" methods in order to help readability of class boundaries." [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [08:11:34] (CR) Tpt: "And a useful tip: if you could, try to base your commits on the current master and not your previous commit: with that, you don't have to " [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [09:37:01] (CR) Wilkins: [C: 1] "Hi," [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [09:56:04] (CR) Tpt: "* I'm not sure I understand your comment about basing the commit on the current master... If I commit and the commit is not reviewed yet, " [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [10:00:07] (CR) Wilkins: "Ok fine." [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [11:45:24] [SemanticMediaWiki] mwjames created nlke-allow (+1 new commit): http://git.io/vCwbb [11:45:24] SemanticMediaWiki/nlke-allow 8469877 mwjames: Fix NLKE for allowed values, refs 1207 [11:58:55] [SemanticMediaWiki] mwjames opened pull request #1210: Fix NLKE for allowed values, refs #1207 (master...nlke-allow) http://git.io/vCwxp [12:23:31] (Abandoned) Wilkins: Creating tag to insert the tree into pages [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245904 (owner: Wilkins) [12:23:55] (Abandoned) Wilkins: Refactoring the FamilyTree calls with a FamilyTreeFactory into the SpecialPage and the FamilyTreeTag object [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245905 (owner: Wilkins) [12:23:59] (Abandoned) Wilkins: PSR2 Syntax and one class per file [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245906 (owner: Wilkins) [12:24:03] (Abandoned) Wilkins: Adding a 'Genealogy' group in Special:SpecialPages [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245907 (owner: Wilkins) [12:24:07] (Abandoned) Wilkins: Syntax and documentation (to be continued...) [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245908 (owner: Wilkins) [12:24:11] (Abandoned) Wilkins: Code cleanup from PHPMD suggestions [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245910 (owner: Wilkins) [12:24:15] (Abandoned) Wilkins: Changing Extension version [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245911 (owner: Wilkins) [12:24:18] (Abandoned) Wilkins: Correcting notice and refactoring the SpecialPage form [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245912 (owner: Wilkins) [12:24:35] (Abandoned) Wilkins: Adding Changelog and README [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245909 (owner: Wilkins) [12:24:38] (Abandoned) Wilkins: Dynamic loading for all types of FamilyTrees - Adding TODO file [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/245913 (owner: Wilkins)