[01:20:02] <smw-github>	 [SemanticMediaWiki] mwjames deleted store at 525d858: http://git.io/ovfw9A
[01:20:12] <smw-github>	 [SemanticMediaWiki] mwjames deleted delete at 5e746cc: http://git.io/vxi1VQ
[03:19:05] <smw-github>	 [SemanticResultFormats] JeroenDeDauw closed pull request #27: Check for instanceof Title (master...tagcloud-null-title) http://git.io/ACZAkQ
[03:47:20] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 1] Making js files pass jshint [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121679 (owner: Jatin)
[09:43:27] <pawan_seerwani>	 Hi FoxT , I have submitted a patch for https://bugzilla.wikimedia.org/show_bug.cgi?id=51505 . I would appreciate if you could review it. :)
[09:44:36] <FoxT>	 pawan_seerwani: Cool. I'll have a look.
[10:17:15] <grrrit-wm>	 (PS4) Jatin: Making js files pass jshint test [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121679
[10:28:16] <jatin>	 FoxT: Earlier jenkins was not giving these errors <https://integration.wikimedia.org/ci/job/mwext-SemanticFormsInputs-jslint/30/consoleFull>, then why now?
[10:29:30] <FoxT>	 jatin: I have no clue
[10:31:10] <FoxT>	 jatin: Maybe somebody changed the jshint settings in the meantime?
[10:32:12] <jatin>	 FoxT: So, what should I do now? Should I add a .jshntrc file?
[10:33:29] <FoxT>	 jatin: To be quite honest, I see this bug as a political thing by somebody who likes to see green indicator lights, but (as seen by his answer in the bug report) has no real idea what he is asking for
[10:34:45] <FoxT>	 I am not sure changing a perfectly working code to achieve this green light is what should be done
[10:36:18] <FoxT>	 Which does not answer your question of course :)
[10:36:52] <FoxT>	 I would not add any config file.
[10:37:07] <jatin>	 yeah, probably, I should add a .jshintrc files with some rules and get this green light :)
[10:39:53] <FoxT>	 If you want to introduce this file, I would suggest to revert all changes to JS files that were imported to SFI from somewhere else (this includes jquery.mulit-select.js) and exclude them from checking
[10:41:12] <grrrit-wm>	 (PS5) Jatin: making js files pass jshint [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121679
[11:06:30] <pawan_seerwani>	 FoxT, My patch for the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=32678 is merged, but the status is not yet resolved. Why so?
[11:07:44] <FoxT>	 pawan_seerwani: I think this is not done automatically. Just edit the bug and set it to RESOLVED and FIXED.
[11:08:05] <grrrit-wm>	 (CR) Pawanseerwani: "If there are no more changes to be done in this, I think its good for merge :)" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani)
[11:12:42] <pawan_seerwani>	 ok
[11:16:11] <pawan_seerwani>	 FoxT, I can't find the link to edit status of the bug.. I don't think I have the permission to change status of the bug.
[11:16:41] <FoxT>	 Every body with an account has. It is at the very bottom of the page.
[11:17:21] <JeroenDeDauw>	 pawan_seerwani: gsoc student?
[11:17:40] <pawan_seerwani>	 JeroenDeDauw, Yes.
[11:20:34] <pawan_seerwani>	 FoxT, I tried again. No such link.
[11:20:47] <FoxT>	 Hmm, odd. I'll do it
[11:20:57] <pawan_seerwani>	 Ok
[11:50:53] <grrrit-wm>	 (PS5) Foxtrott: Add class to "Additional Query" in SF_RunQuery.php [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani)
[11:51:35] <grrrit-wm>	 (CR) Foxtrott: [C: 2 V: 2] Add class to "Additional Query" in SF_RunQuery.php [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani)
[12:07:13] <grrrit-wm>	 (CR) Foxtrott: "I like it. Two inline comments." (2 comments) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/121698 (owner: Pawanseerwani)
[18:08:10] <jatin>	 Hi, can anyone help me where to start for solving this bug <https://bugzilla.wikimedia.org/show_bug.cgi?id=28646>? I am able to reproduce the bug.
[20:48:11] <grrrit-wm>	 (PS1) Jatin: default=now for datepicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979
[20:53:03] <grrrit-wm>	 (PS2) Jatin: default=now for datepicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979
[20:53:12] <jatin>	 FoxT: I have submitted a patch for bug <https://bugzilla.wikimedia.org/show_bug.cgi?id=61363>. Can you please review it?
[20:53:23] <FoxT>	 jatin: Looking at it right now
[20:53:45] <jatin>	 FoxT: ok :)
[21:00:38] <FoxT>	 jatin: Have you tested it?
[21:01:03] <jatin>	 yes, its working fine...
[21:01:21] <jatin>	 FoxT: did you test it?
[21:01:31] <FoxT>	 I'll do now
[21:02:03] <jatin>	 FoxT: ok.
[21:28:15] <jatin>	 FoxT: Is it working fine?
[21:29:43] <grrrit-wm>	 (CR) Foxtrott: "This change has several problems:" [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979 (owner: Jatin)
[21:30:00] <FoxT>	 jatin: Alas not at all. There are several problems
[21:31:35] <jatin>	 FoxT: ohh, I'll try to fix them.
[21:31:44] <FoxT>	 k
[21:36:17] <FoxT>	 jatin: Easiest would probably be to check $cur_Value in the constructor if it is 'now' and in that case set it to today's date
[21:36:41] <FoxT>	 It's a hack. But the whole thing is a hack back from days when I did npot know any better
[21:37:30] <jatin>	 yeah, sure I was thinking to that.
[21:37:39] <FoxT>	 Oh, the format of todays date should be yyyy/mm/dd, no matter what the user date format says
[21:38:17] <jatin>	 ohh, that was the thing that was troubling me, now you made it easy :)
[21:54:53] <grrrit-wm>	 (PS3) Jatin: default=now for datepicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979
[21:59:57] <jatin>	 FoxT: Is it correct now?
[22:10:41] <grrrit-wm>	 (CR) Foxtrott: "Getting there." (1 comment) [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979 (owner: Jatin)
[22:27:28] <grrrit-wm>	 (PS4) Jatin: default=now for datepicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979
[22:27:32] <jatin>	 FoxT: I don't know why but date format 'Y/m/d' changes to 'Y.m.d' automatically. Is it fine?
[22:28:22] <FoxT>	 jatin: you mean Y/m/d to d.m.Y?
[22:30:05] <jatin>	 FoxT: No, I have set date format for 'now' as 'Y/m/d' but in the form it displays as 'Y.m.d'
[22:30:33] <grrrit-wm>	 (PS5) Jatin: default=now for datepicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979
[22:30:41] <FoxT>	 That'S odd, it should change the order
[22:31:51] <jatin>	 FoxT:  So, do I need to do something? Because I'm not getting why this is happening.
[22:35:15] <FoxT>	 jatin: Have you changed $sfigSettings->datePickerDateFormat in your LocalSettings?
[22:35:41] <jatin>	 FoxT: No
[22:37:30] <FoxT>	 jatin: Then I have no idea what is going on. It works for me. When I set default=now, it shows 29/03/2014 in the date field
[22:38:34] <jatin>	 FoxT: So, is it fine to get merged?
[22:40:44] <FoxT>	 jatin: We are two people, for one it works, for the other it does not. 50% failure rate is not very impressive. We really should find out, why it is not working for you.
[22:42:33] <jatin>	 Why is not working for me, I haven't changed anything other than adding those 4 line in the SFI_DatePicker.php.
[22:45:22] <jatin>	 But if try 'Y-m-d', it works fine.
[22:46:20] <FoxT>	 Where do you put Y-m-d?
[22:47:28] <jatin>	 I'm talking about the line I have added ("$cur_value = date('Y-m-d');") in the constructor.
[22:48:22] <FoxT>	 So, if you put Y-m-d in the constructor then you see 29/03/2014 in your date field?
[22:49:44] <jatin>	 No, then I see what I have put there (which is 2014-03-29).
[22:51:11] <jatin>	 Problem is with '/' as a seperator (and that too just for 'Y/m/d') and not with any other symbol.
[22:52:13] <jatin>	 If I put 'd/m/Y', then it works fine and displays 29/03/2014
[22:52:57] <jatin>	 But if I put 'Y/m/d', it displays 2014.03.29
[22:53:01] <FoxT>	 Yes. but it will also store 29/03/2014, which is wrong
[22:53:54] <FoxT>	 Which language is your wiki in?
[22:54:34] <jatin>	 en
[22:59:00] <FoxT>	 jatin: If you go to the page MediaWiki:Semanticformsinputs-dateformatshort in your wiki, what does it say?
[22:59:30] <jatin>	 dd/mm/yy
[23:01:13] <FoxT>	 jatin: I hv+
[23:01:16] <FoxT>	 Sorry
[23:01:17] <jatin>	 FoxT: I found something, browser cache was causing the problem, when I deleted the cache Y/m/d is not changing to Y.m.d but now its changing to d/m/Y
[23:01:56] <FoxT>	 Ah, good, that is the expected behaviour
[23:02:26] <jatin>	 I think everything is fine now :)
[23:02:53] <FoxT>	 I guess so :)
[23:02:53] <jatin>	 This cache thing causes problems sometime!
[23:03:23] <grrrit-wm>	 (CR) Foxtrott: [C: 2 V: 2] default=now for datepicker [extensions/SemanticFormsInputs] - https://gerrit.wikimedia.org/r/121979 (owner: Jatin)
[23:04:33] <jatin>	 FoxT:  I guess, I should go to sleep now, its 4:30 in the morning here.
[23:05:24] <FoxT>	 Good night then.
[23:05:40] <FoxT>	 I should probably go as well. It's midnight here
[23:05:55] <jatin>	 FoxT: Good night :)