[10:49:42] (PS1) Pawanseerwani: Add class to "Additional Query" in SF_RunQuery.php [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 [10:53:47] Hi Yaron , I have submitted a patch for https://bugzilla.wikimedia.org/show_bug.cgi?id=41538 I would appreciate if you could review it. [10:54:58] Nice. [10:55:21] How did you come up with "secondHeading" as a class name? Is that used anywhere else? [10:58:19] Yaron, Actually firstHeading is used for the mail title Eg. (

Run query: Book

) [10:58:29] *main title [10:59:00] Thats the reason I have used "secondHeading" [11:00:46] Oh, interesting - I had forgotten that. [11:02:07] I think something RunQuery-specific makes more sense, though - especially if anything else starts using "secondHeading". [11:02:27] (To the extent that any class name makes sense - I think this is kind of a weird bug.) [11:03:54] (CR) Foxtrott: "Would it make sense to also wrap the whole additional query in a div with a defined class name? That way the query form as a whole can be " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [11:07:06] (CR) Mitchelln: "I agree. Wrapping in a div would give much more flexibility." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [11:13:56] (CR) Pawanseerwani: "That would be be more meaningful. Thanks." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [11:19:46] (CR) Foxtrott: "Using span will not work. Span only allows phrasing content, which includes neither h1 nor form." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [11:34:45] Yaron, : Sorry got disconnected earlier, So how about "
" inside the h2 tag? [11:36:39] (CR) Pawanseerwani: "Ok. Thanks." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [11:51:14] (CR) Foxtrott: "What about 'sf-runquery-additionalquery'?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [13:10:12] (CR) Yaron Koren: "That sounds good; though why this whole thing is necessary, I don't know. Other special pages don't provide classes for all their elements" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [13:24:08] (CR) Mitchelln: "This is a case where the special page is directly accessed by the end user. So it is important that the look and feel can be modified, esp" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [13:39:47] (CR) Nikerabbit: "Perhaps even more important use case for good classes is integration testing." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [13:47:48] (CR) Yaron Koren: "Is that relevant to this patch?" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [15:12:41] (CR) Yaron Koren: "I'm guessing that's a "no". Anyway, this is hardly the only special page meant to be viewed by regular users; Special:Search and Special:R" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [15:17:29] (CR) Foxtrott: "Let me quote: "That way the query form as a whole can be addressed by CSS and JS (e.g. to add a hiding switch, put a border around it, wha" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [15:17:31] (PS1) Addshore: Use getcwd() in test bootstrap [extensions/SemanticResultFormats] - https://gerrit.wikimedia.org/r/120536 [15:25:55] (CR) Yaron Koren: "That's true - more classes are rarely a bad idea. On the other hand, it should be noted that MediaWiki already adds a class name for every" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [15:30:19] (Abandoned) Addshore: Use getcwd() in test bootstrap [extensions/SemanticResultFormats] - https://gerrit.wikimedia.org/r/120536 (owner: Addshore) [15:33:55] (CR) Foxtrott: "IMO, that would not be enough to add a hiding switch or put a border around the form." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [15:43:32] (PS1) Cicalese: Protect against XSS attack. [extensions/SemanticTitle] - https://gerrit.wikimedia.org/r/120544 [15:56:05] (CR) Yaron Koren: "Well, feel free to modify the patch accordingly, then." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani) [16:24:23] (CR) Yaron Koren: [C: 1] Protect against XSS attack. [extensions/SemanticTitle] - https://gerrit.wikimedia.org/r/120544 (owner: Cicalese) [17:59:30] Curious http://twiki.org/cgi-bin/view/Plugins/XmlQueryPlugin [22:14:00] (PS2) Pawanseerwani: Add class to "Additional Query" in SF_RunQuery.php [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 [22:40:43] (CR) Yaron Koren: "Pawan - the
shouldn't be within

(that doesn't make sense) - it should be around the whole "additional query" area, or around th" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120501 (owner: Pawanseerwani)