[07:20:31] (CR) Foxtrott: "You are probably right that uit does not make much sense to have two parameters. I will change it to one parameter showing both links." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [11:41:00] (CR) Mitchelln: "I don't think you can try to automatically 2nd guess when the user would want to see the select all checkbox." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [12:24:41] (CR) Siebrand: [C: 1] "L10n reviewed." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [13:11:29] Yaron, Hi. I saw your comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=38884 Then I used grep cmd and found that it is mostly used in SF_AutoeditAPI.php But I am still at loss to figure how exactly is it being used there. [13:12:40] I think the relevant place to make changes is SF_FormPrinter.php, actually... [13:13:04] ...since this doesn't affect just dropdowns but radiobuttons, checkboxes, etc. as well. [13:13:19] I mean, the sorting should be the same across all of them. [13:13:54] Oh. Okay. But could you give me an example of where and how the dropdown input is used? I still couldn't figure that out. [13:13:54] It should be the $values variable that gets modified, I think. [14:32:27] (CR) Yaron Koren: "> Thus it is not practically possible to decide on the right number of values to show the switches." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [14:56:13] pawan_seerwani: sorry, I totally missed your follow-up question! [14:56:27] ...even though it only showed up a second after my response. [14:57:09] You can have something like "{{{field|City|input type=dropdown|values from category=Cities}}}". [14:57:44] (CR) Mitchelln: [C: 1] "I would have thought the person creating the form would be the best person to decide when the apply the select all or not." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [14:59:21] Oh, okay. I will try that. But the $values variable is being used in function formHTML() , so I have to focus only on this function right. (btw, it is a 1400 lines function) [15:03:39] I know - it's a monster! [15:08:59] So a line like "{{{field|City|input type=dropdown|values from category=Cities}}}" is used in *templates*, from which form is generated. And in the form the dropdown values should be sorted, correct? [15:51:47] pawan_seerwani: sorry again. No, it's used in the form definition itself. [15:52:12] Yes, the values should be sorted. I thought they were sorted already, though, so I don't fully know what the bug means. [17:32:04] (PS4) Foxtrott: Select all/Select none links for checkboxes input type [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 [17:42:34] (CR) Foxtrott: "Modified as suggested. See commit message." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [17:42:44] (CR) Yaron Koren: "Stephan - this looks great! I think this is really going to be the best of both worlds. (And now I'd like to have similar behavior for ext" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [17:43:13] Heh, mid-air collision :D [17:45:12] (CR) Yaron Koren: "Oh, I missed your comment about remote autocompletion. The one downside to always using it is that it's noticeably slower than having the " [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [17:46:25] (CR) Foxtrott: "What needs to be updated in SF_Messages.php? It only contains the link labels. They don't change." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [17:51:27] (CR) Yaron Koren: [C: 2 V: 1] "Oh, right you are - I'll blame it on post-lunch drowsiness. Given that everything here looks fine, and Siebrand okayed it as well, I'm app" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [17:51:30] (Merged) jenkins-bot: Select all/Select none links for checkboxes input type [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/119893 (owner: Foxtrott) [21:57:02] (PS1) Jatin: Standard inputs lose their values on preview Bug: xxxxxx Change-Id: If1f51c4fe30da8ad4963a0ba072161906ccc291b [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120149 [23:05:13] (PS2) Jatin: Standard inputs lose their values on preview Bug: 50199 Change-Id: If1f51c4fe30da8ad4963a0ba072161906ccc291b [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120149 [23:28:48] (CR) Foxtrott: "Did not run it, but it looks good. Two small inline comments." (2 comments) [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120149 (owner: Jatin) [23:54:48] (PS3) Jatin: Standard inputs lose their values on preview Bug: 50199 Change-Id: If1f51c4fe30da8ad4963a0ba072161906ccc291b [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/120149