[12:10:58] <grrrit-wm>	 (PS1) Pawanseerwani: Appropriate log message for property creation [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973
[12:21:38] <pawan_seerwani>	 hi Yaron , on the bug 35370, when you said " in /specials/SF_CreateClass.php, one should be passed in when creating the SFCreatePageJob instance.", should i pass an edit_summary as a parameter?
[12:21:58] <Yaron>	 Yes.
[12:22:42] <pawan_seerwani>	 ok, thanks
[12:23:57] <grrrit-wm>	 (CR) Yaron Koren: [C: -1] "The edit summary should be an i18n message, not hardcoded English." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973 (owner: Pawanseerwani)
[12:31:08] <pawan_seerwani>	 Yaron, To add i18n message in SF_MessageEn.php, can I add a new parameter in $m_SpecialProperties?
[12:31:23] <Yaron>	 No.
[12:33:00] <pawan_seerwani>	 So, I should add a new parameter in SF_Language.php , say protected $m_AutoSummary ; and its corresponding function and define its value in SF_MessageEn.php
[12:33:12] <Yaron>	 No.
[12:33:18] <Yaron>	 Just add a message.
[12:34:44] <pawan_seerwani>	 you mean, just a variable like $new_prop_msg = "Created a property of type $1" in SF_MessageEn.php?
[12:35:02] <Yaron>	 No.
[12:35:19] <Yaron>	 Have you looked at how the i18n stuff works?
[12:35:52] <pawan_seerwani>	 I thought we define it in corresponding language file and use it.
[12:36:01] <pawan_seerwani>	 I will look it up
[13:48:47] <grrrit-wm>	 (PS2) Pawanseerwani: Appropriate log message for property creation [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973
[14:32:18] <pawan_seerwani>	 Yaron, I have added i18n msg and submitted the patch. Would be great if you could review
[14:32:21] <pawan_seerwani>	 https://gerrit.wikimedia.org/r/#/c/118973/2
[14:33:50] <Yaron>	 pawan_seerwani: this looks much better!
[14:34:07] <Yaron>	 Does it work for you? Did you try it with both Special:CreateProperty and Special:CreateClass?
[14:37:08] <pawan_seerwani>	 I am sure of Special:CreateProperty, I will check with the other one. 1 min.
[14:47:33] <pawan_seerwani>	 the logs aren't being generated in Special:CreateClass.
[14:47:54] <pawan_seerwani>	 I will recheck and get back
[14:51:19] <pawan_seerwani>	 the edit_summary parameter in SFCreatePageJob  has no effect
[14:53:27] <Yaron>	 Well, that should be fixed.
[14:54:28] <pawan_seerwani>	 Ok, on it :)
[15:00:02] <Yaron>	 By the way, you should always test code before submitting a patch.
[15:16:18] <pawan_seerwani>	 I will keep that in mind. Sorry.
[16:23:13] <pawan_seerwani>	 Yaron, there doesn't seem to be an edit_summary parameter for SFCreatePageJob, and there is no documentation of it as well.  A little help would be appreciated :)
[16:23:51] <Yaron>	 Have you been working on it this whole time?
[16:24:23] <pawan_seerwani>	 Yes
[16:24:46] <Yaron>	 Oh, okay.
[16:24:49] <pawan_seerwani>	 Unable to find anything related to edit_summary parameter in any of the Job related classes
[16:25:11] <Yaron>	 I'm looking at the SFCreatePageJob code, and 'edit_summary' is definitely mentioned there.
[16:26:03] <Yaron>	 Do you see it?
[16:26:27] <pawan_seerwani>	 Oh, now I saw it. Silly me. Should I just uncomment it?
[16:26:49] <Yaron>	 Might be worth trying. :)
[16:27:26] <pawan_seerwani>	 I will get back to work then :)
[16:43:24] <pawan_seerwani>	 Yaron, uncommenting doesn't work. This itself is another bug I think.
[16:43:43] <Yaron>	 Same bug, no?
[16:44:50] <pawan_seerwani>	 well, true that.
[16:46:05] <Yaron>	 Well, it might be time to do some debugging - there are various "nice" ways to debug, but the easiest is to use a combination of print, print_r, die() etc.
[17:33:44] <dreamer>	 ohai, I read that now 'composer' is used to install SMW
[17:34:28] <dreamer>	 I'm upgrading from al onder version. does it work the same?
[17:34:31] <dreamer>	 older*
[17:40:56] <dreamer>	 hmm, I got a [ErrorException]                                          escapeshellarg() has been disabled for security reasons
[17:42:27] <dreamer>	 oh meh, I don't have access to php.ini ..
[17:42:36] <dreamer>	 (reading: http://www.mediawiki.org/wiki/Safe_mode)
[17:43:39] <dreamer>	 can I then use the old-style way of upgrading? (ie. placing the new files in extensions/)
[21:16:58] <grrrit-wm>	 (PS3) Pawanseerwani: Appropriate log message for property creation [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973
[21:29:16] <Yaron>	 pawan_seerwani: cool; so does the patch work now?
[21:30:05] <pawan_seerwani>	 Yes :)
[21:30:48] <Yaron>	 So what happened? Why didn't it work before?
[21:31:23] <pawan_seerwani>	 I had put the edit message in connecting_property
[21:31:39] <Yaron>	 Oh, I see.
[21:31:47] <Yaron>	 It should be in both, really.
[21:32:33] <pawan_seerwani>	 No Has type property for connecting_property then?
[21:33:09] <Yaron>	 I don't understand.
[21:34:13] <pawan_seerwani>	 I have used  $messages['en']['sf_createproperty_logmsg']= "Created a property of type [[Has type::$1]]"
[21:34:30] <pawan_seerwani>	 which has a Has type property for normal properties
[21:34:46] <pawan_seerwani>	 but for connecting property there won't be a datatype..
[21:35:00] <Yaron>	 It's of type "Page".
[21:35:35] <pawan_seerwani>	 Oh, din't know that. I have never used it actually.
[21:36:14] <pawan_seerwani>	 Ok, I will set it to Has type::Page then.
[21:36:25] <Yaron>	 You shouldn't have to do that.
[21:37:27] <pawan_seerwani>	 I don't understand.
[21:37:47] <Yaron>	 I don't understand either. :)
[21:38:11] <Yaron>	 Why can't you just add the same handling for the two kinds of properties being created by 'CreateClass'?
[21:41:37] <pawan_seerwani>	 Same handling can be done provided the property type returned by $smwgContLang->getDatatypeLabels(); in SF_CreateClass is Page
[21:43:08] <Yaron>	 Well, I still don't understand, but if you think you have it under control, that's fine.
[21:44:41] <pawan_seerwani>	 I will do it.
[21:46:29] <grrrit-wm>	 (CR) Yaron Koren: "A few minor comments: 'sf_createproperty_logmsg' would probably be better renamed to something like 'sf_createproperty_editsummary'; and i" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973 (owner: Pawanseerwani)
[21:46:54] <Yaron>	 I just added a few small, unrelated comments about the patch.
[21:50:15] <pawan_seerwani>	 Sure. I will consider them for upcoming patch version :)
[21:51:43] <grrrit-wm>	 (CR) Pawanseerwani: "Thanks yaron. I will make sure to include them in upcoming patch version." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973 (owner: Pawanseerwani)
[22:15:58] <grrrit-wm>	 (PS4) Pawanseerwani: Appropriate log message for property creation [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973
[22:17:29] <pawan_seerwani>	 Yaron, I have done it all  now :)
[22:17:52] <Yaron>	 Excellent!
[22:24:31] <grrrit-wm>	 (CR) Yaron Koren: [C: -1] "I think CreateClass needs inContentLanguage() calls too." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/118973 (owner: Pawanseerwani)
[22:30:37] <pawan_seerwani>	 Yaron, I thought about that, but I saw the pattern that none of the other functions in CreateClass.php call WfMessage with inContentLanguage.  So I dropped it.
[22:36:54] <Yaron>	 Ah.
[22:37:35] <Yaron>	 Do you know what inContentLanguage() does, by the way?
[22:57:49] <pawan_seerwani>	 Not Much.. Just that it converts the message to $wgContLang
[23:13:14] <Yaron>	 pawan_seerwani: okay - do you know the difference between user and content messages?
[23:17:04] <pawan_seerwani>	 Yaron, I read the documentation and I think content messages are default language messages and user messages are user selected language messages.
[23:17:23] <Yaron>	 No, that's not accurate.
[23:18:00] <Yaron>	 Content messages are messages that show up in wiki pages and logs; user messages are everything else - everything that doesn't affect the contect of the wiki.
[23:21:38] <pawan_seerwani>	 Yaron, how is message in wiki page different from user messages then?
[23:21:58] <Yaron>	 Not everything that shows up on the screen comes from a wiki page.
[23:22:37] <Yaron>	 The names of the "view", "edit", etc. tabs do not, for instance.
[23:22:59] <Yaron>	 Oh, dinner time - talk to you later.