[14:25:07] (CR) Jeroen De Dauw: "Suggest the "problematic" part is dropped from this commit so the rest does not sit in limbo" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/111521 (owner: Chad) [16:42:39] So I want a hook to automatically create pages for red links upon page save: $wgHooks['ArticleSaveComplete'][] = 'MyExtensionHooks::SFCreatePageJob'; where SFCreatePageJob is as defined here: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FSemanticForms.git/8ab4f7aab17510c013ee8becd21f8cbdd918b3aa/includes%2FSF_CreatePageJob.php [16:42:47] What would be the correct syntax? I'm not sure if and how to input any parameters in SFCreatePageJob [16:42:59] Thanks, and apologies if this is the second time you see this question. [17:15:54] (PS2) Chad: Remove a bunch of the $wgTitles in SemanticForms [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/111521 [22:43:33] Hie FoxT are you there? [22:43:46] zeke: yes [22:45:02] I was working on this. https://bugzilla.wikimedia.org/show_bug.cgi?id=50199 . Have gone through the entire file SF_AutoeditAPI.php, but I am not able to figure out where the warning is being generated from. I mean where the list of parametres are matched to tell which parameter is unrecognized.. please help :/ [22:45:25] oops not that.. this https://bugzilla.wikimedia.org/show_bug.cgi?id=51505 [22:48:59] zeke: I do not think this warning is generated inside the Autoedit API module. I think some code outside notices, that the Autoedit module does not process the parameter and complains [22:50:15] FoxT: I think the same and I feel that this check must be performed during the prepareAction() function because at the end of it, it sets the status to 200. So i checked through the calls inside prepareAction, but still didn't get :/ [22:51:02] The setting at the end of prepareAction is just an initialization [22:51:49] I even went through doAction... because thats how the call proceeds... prepareAction -> doAction -> finalizeResults -> setheaders [22:52:02] Have a look at the end of doAction. depending on the requested action a method is called. [22:52:16] Ok let me see it again [22:52:25] I think only for doStore the token needs to be checked. [22:54:04] but it might be worth having a look at EditPage how they do it. Could be, they also check the token when doing a diff [22:56:51] All right :)