[04:09:02] (PS8) Nischayn22: [WIP]Adding support for DataVisualizer [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/98390 [04:09:03] (CR) jenkins-bot: [V: -1] [WIP]Adding support for DataVisualizer [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/98390 (owner: Nischayn22) [11:18:22] JeroenDeDauw: we figured out that semantic maps on IE has a problem when the zoom-factor is bigger than 15 and when we have more objects that are outside of the displayed area [12:53:34] s6581: please file a bug here https://github.com/JeroenDeDauw/SemanticMaps/issues [13:07:44] JeroenDeDauw: yes, will do [13:29:03] Hello [13:29:45] I would like to know how the autoloading of the SemanticResultFormat extension works. [13:30:18] I see the code where the different formats are registered and the classes which handle those formats are defined. [13:30:53] But the php files have different names - with an underscore separating SRF and the class name. [13:31:23] I don't find the bit where the class name is mapped to the php file which is to be loaded. [13:31:35] s/is to be/should be/ [13:45:40] JeroenDeDauw: you are a contributor to SemanticResultFormats? [13:47:00] Hi Yaron, your name is mentioned as a SemanticResultFormats contributor. [13:50:02] JeroenDeDauw: done [13:57:56] kami: hello! Yes. [13:58:26] I just wrote a question regarding the autoloading of the different handler class php files. [13:58:41] Ooh... okay; I may or may not be able to help with that. [13:58:45] Do you have a log handy, or shall I paste the question. [13:58:46] ? [13:59:00] I don't have a log, no. [13:59:15] wait a sec. [13:59:20] I would like to know how the autoloading of the SemanticResultFormat extension works. [13:59:25] The internal structure of SRF has changed somewhat since I was heavily involved with it, so I may or may not be able to help, by the way. [13:59:27] Alright. [13:59:34] I see the code where the different formats are registered and the classes which handle those formats are defined. [13:59:48] But the php files have different names - with an underscore separating SRF and the class name. [13:59:59] I don't find the bit where the class name is mapped to the php file which is to be loaded. [14:00:26] e.g. icalendar is handled by SRFiCalendar IIRC, and the php file is SRF_iCalendar.php [14:01:14] Right... I think that might be defined in the the classes themselves, but I'm not sure. [14:01:16] Let me look. [14:02:37] Yaron: you're right. there is a function getFileName [14:03:16] No, that's not it... [14:03:42] It's not for finding the PHP file. [14:04:09] The reason why I ask is that I get such errors: Class 'SRFiCalendar' not found in /home/darabi/repo/mediawiki/semantic-bundle/SemanticMediaWiki/includes/query/SMW_QueryProcessor.php on line 554, referer: http://wiki.local/mw/index.php/Main_Page [14:04:47] Oh, that's strange. [14:04:59] BUT: I am using the SemanticBundle repo [14:05:03] Yes. [14:05:16] You have the iCalendar file in there, in the SRF /formats directory? [14:05:51] I have SemanticResultFormats/formats/icalendar/SRF_iCalendar.php [14:07:05] Okay, cool. [14:07:29] Do you have a call to icalendar in your main page? [14:10:15] I have a stock install of MW _master_ with SemanticBundle _dev_ versions. I have followed the instructions in https://www.mediawiki.org/wiki/Semantic_Bundle [14:10:49] And can see in Special:Versions that all SB extension report their respective version. [14:11:31] I haven't modified the main page besides minor edits to the 'Getting Started' section. [14:12:37] The only thing I can see on the main page which resembles something which needs an iCalendar is the line 'This page was last modified on 4 January 2014, at 06:56.' [14:12:47] No, that's not it. [14:12:57] Man... maybe it's a general problem in Semantic Bundle. [14:13:25] OK. I will then reset to the 'release' versions of the repos and test again. Does that make sense? [14:13:26] There was just a new SB released a few days ago, so assuming you're using that one, you're among its first users. [14:13:46] Yes... although it would be good to know if SB has a major bug. :) [14:13:52] JeroenDeDauw: are you there? [14:14:13] kami: feel free to modify your extension versions if you don't want to be a guinea pig. :) [14:14:29] Yaron: I would like to learn more about how it works. [14:14:58] I wouldn't mind debugging/adding log messages etc. to pinpoint the problem if there is one. [14:16:10] But I'm not a php pro. I'd be happy if someone could give me some hints. [14:16:18] What is your time zone? [14:17:05] I have to leave for about 2-3 hours and will then be back online. [14:17:21] And start looking into this issue. [14:22:17] kami: I'm on US Eastern time. [14:23:06] That's great. See you later (hopefully). Bye. [16:36:33] (PS1) Nischayn22: Merge branch 'master' of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SemanticDrilldown [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/105697 [16:36:36] (CR) jenkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SemanticDrilldown [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/105697 (owner: Nischayn22) [16:38:20] (Abandoned) Nischayn22: Merge branch 'master' of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SemanticDrilldown [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/105697 (owner: Nischayn22) [16:42:19] (PS9) Nischayn22: [WIP]Adding support for DataVisualizer [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/98390 [18:15:11] Yaron: ping [18:22:32] The reason why autoloading doesn't work for SemanticResultForms seems to be the change 1eb0b55 "Add PHPUnit bootstarp and update autoloading to use Composer" [18:24:21] I have read a bit about composer on http://getcomposer.org/ [18:24:50] There is indeed a file SemanticResultForms/composer.json [18:26:43] It seems like it is necessary to run composer after checking out SemanticResultForms from git to create vendor/autoload.php [19:06:58] kami: hello! Sorry, I didn't see this until now. [19:07:13] Okay, that's bad.... I guess we need to re-release SB. [19:07:26] JeroenDeDauw: are you there now? [19:08:00] We'll get on this, in any case. That's great detective work, in figuring out the problem. [19:56:27] Yaron: how is the composer stuff intended to be used? [19:56:56] the bundle zip/tar should contain the autoload.php file, right? [19:58:11] Hi - I don't actually know. :) I have yet to try any of the Composer stuff, though I hope to do it very soon. [19:58:42] Hmm. I will try it right now. Just too curious :) [21:40:41] Yaron: composer.json contains a section .. "autoload": { .. "classmap": [ "formats/", "SemanticResultFormats.hooks.php", "SemanticResultFormats.parser.php", "SemanticResultFormats.utils.php" ] } [21:41:53] Then you run 'composer dump-autoload' which creates vendor/autoload.php [21:43:52] autoload.php loads a file vendor/composer/autoload_classmap.php which contains an array containing all classes which could be found in the files/dirs of the autoload section in composer.json [21:44:12] kami: oh, I get it - the Composer file itself contains the class-to-file mappings. [21:44:37] Well, clearly SB needs to be incorporating an older version of SRF, then - before that change happened. [21:44:46] return array( ... 'SRFiCalendar' => $baseDir . '/formats/icalendar/SRF_iCalendar.php',...) [21:45:08] Yaron: note that I have NOT tried the release version [21:45:29] Alright. [21:45:49] let me check which version is in SemanticBundle/externals [21:47:17] externals contains 1.8.x which still contained the explicit [21:47:17] $wgAutoloadClasses['SRFiCalendar'] = $formatDir . 'icalendar/SRF_iCalendar.php'; [21:47:44] Well, that's what I thought... [21:47:56] So my problem comes from being too eager to try bleeding edge stuff :) [21:48:00] Oh! [21:48:10] I thought you were just using the SB code when the problem started. [21:49:25] What happened - you got the SB code, and then manually upgraded your SRF code before running the wiki? [21:50:21] No, I cloned SemanticBundle and run make dev instead of 'make all' [21:50:35] Ah, I see. [21:50:57] Yes, that won't work... I'm surprised that didn't crash even more badly. [21:51:34] ...since SB doesn't yet contain most of the extensions that SMW 1.9 requires. [21:51:42] I mentioned that in the morning, but obviously not clear enough. [21:52:29] OK. So SemanticBundle isn't the right thing to use for SMW 1.9. [21:52:58] No, definitely not. [21:53:25] You mean you mentioned it when you used the word "repo"? I just looked back through our conversation. [21:55:01] I wrote 'I have a stock install of MW _master_ with SemanticBundle _dev_ versions.' [21:55:26] But I should have stressed that part. [21:56:08] Oh. I'm not sure if I even read that line. :) [21:56:45] I often forget that people use SB in any form other than the downloadables. [21:57:40] NP :) [21:58:00] I just did a quick php composer.phar require mediawiki/semantic-media-wiki "1.9.*,>=1.9.0.1" [21:58:08] but that one installs only Validator and SMW proper [21:58:55] If I understand correctly, the other extensions which come with SB are quite powerful. [21:59:11] SF is always mentioned as a must have. [21:59:48] Sure, I'd agree with that. [22:00:03] I still don't know anything about Composer, though. [22:01:04] So, my best bet is to use SB which contains SMW 1.8 until SB is updated? [22:02:14] Yaron: composer is not a big deal, you can read the Getting Started in a couple of minutes http://getcomposer.org/doc/00-intro.md#declaring-dependencies [22:02:33] Well, if you have Composer and Git and all of that, you can manually get all the extensions you need... [22:02:54] Yes, I just need to sit down at some point and do all of that stuff. [22:03:49] Yaron: I will run composer for those extensions which have a composer.json at the top level dir. [22:04:51] But is there some kind of test plan for the individual extensions (or for SB as a whole)? [22:05:02] What do you mean by test plan? [22:05:21] How do I know that everything works as expected? [22:05:58] No error messages? :) [22:06:03] :) [22:06:12] That's easy to verify. [22:06:22] Will try. [22:07:38] But SB's Makefile should probably contain the call to composer for those extensions which use it. [22:08:38] Well, it will in the next version. [22:09:08] And add the require __DIR__ . '/vendor/autoload.php' line to the extension's main file [22:12:03] Yaron: shall I push a patch to Gerrit? [22:12:57] Or write a message to the wikitech-l ML? [22:17:38] These are the SB extensions which have a composer.json: Maps SemanticMaps SemanticResultFormats Validator [22:18:22] All of them except SemanticResultFormats contain a if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) { include_once( __DIR__ . '/vendor/autoload.php' ); [22:19:15] Patch or message relating to what? [22:20:10] About adding the necessary calls to composer to SemanticBundle/Makefile [22:20:21] Oh, I see. [22:20:34] Well, a message to wikitech-l wouldn't accomplish anything... [22:20:42] A patch would be cool, yeah. [22:21:24] OK. Will push 2 patches: one of them will download composer and run it on the extensions which have a composer.json [22:21:59] the other one will add include_once( __DIR__ . '/vendor/autoload.php' ) to SemanticResultForms [22:23:37] Cool! That'll be great; thank you. [22:23:47] running composer requires php locally, is that an acceptable requirement for building SB from git? [22:25:48] I don't understand. [22:28:29] Currently, you don't need php cli to build SB from the git repo. My change makes it necessary to have php on the local machine. [22:29:12] Is that acceptable (should probably be documented on https://www.mediawiki.org/wiki/Semantic_Bundle if the change gets merged) [22:29:18] ? [22:30:07] I don't understand... isn't PHP required already? [22:31:00] For building SB, it is not required, if I read the Makefile correctly. [22:31:33] Right, but... well, anyway, I'm sure it's fine. [22:31:51] OK. Thanks. [22:50:18] Yaron: thank you for your help and patience! [22:50:40] It's getting late here (midnight). Will continue and push tomorrow. Bye. [23:23:47] (PS1) Kambiz Darabi: Add download and invocation of composer to Makefile dev target [extensions/SemanticBundle] - https://gerrit.wikimedia.org/r/105859