[01:00:19] <grrrit-wm>	 (PS1) Yaron Koren: Fix to prevent cross-site request forgeries [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103883
[01:03:16] <grrrit-wm>	 (Abandoned) Yaron Koren: Fix to prevent cross-site request forgeries [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103883 (owner: Yaron Koren)
[01:17:08] <grrrit-wm>	 (PS1) Yaron Koren: Fix to prevent cross-site request forgeries [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103885
[01:17:28] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] Fix to prevent cross-site request forgeries [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103885 (owner: Yaron Koren)
[01:17:31] <grrrit-wm>	 (Merged) jenkins-bot: Fix to prevent cross-site request forgeries [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103885 (owner: Yaron Koren)
[01:47:42] <grrrit-wm>	 (PS1) Yaron Koren: Changed redirect from Javascript to HTML [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103889
[01:50:39] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] Changed redirect from Javascript to HTML [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103889 (owner: Yaron Koren)
[01:50:41] <grrrit-wm>	 (Merged) jenkins-bot: Changed redirect from Javascript to HTML [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/103889 (owner: Yaron Koren)
[07:46:36] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticComments] - https://gerrit.wikimedia.org/r/103983
[07:47:05] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/103984
[07:48:04] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/103985
[07:48:44] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/103986
[07:49:01] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticPageMaker] - https://gerrit.wikimedia.org/r/103987
[07:49:17] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticPageSeries] - https://gerrit.wikimedia.org/r/103988
[07:51:52] <grrrit-wm>	 (PS1) Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticWatchlist] - https://gerrit.wikimedia.org/r/103989
[09:48:35] <mayankmadan>	 hi himeshi
[09:48:54] <himeshi>	 Hi!
[09:49:40] <himeshi>	 How are you doing with the GCI task? :)
[09:49:57] <mayankmadan>	 himeshi, i might need some help with that :)
[09:53:34] <himeshi>	 Sure, Were you able to successfully install the extensions? The tests that is being referred here is testing the {{{section}}} tag in the SFFormPrinter class.
[09:58:11] <mayankmadan>	 himeshi, i installed the extension and phpunit
[09:58:58] <mayankmadan>	 himeshi, if you are not busy and if you are willing to, can you explain to me how these phpunit tests work?
[10:10:55] <mayankmadan>	 himeshi, and why isnt there any setup() or tearDown() function in SFFormPrinter class
[10:11:41] <himeshi>	 mayankmadan: In the formHTML() method there are 3 things to consider; the form definition, the text that defines the form and data text - which is the text appearing in the page created by that form. Here we're testing if these 3 appear correctly when a section is being processed.
[10:11:41] <himeshi>	 If you look at the tests now, in the pageSectionDataProvider() it only has the section header (the ones that say "==section 1==") for data text. But it can contain whatever content that goes into a section as well. The task is to write a unit test for that.
[10:12:29] <himeshi>	 mayankmadan: In this case there is nothing to really setup or teardown so those two aren't needed here.
[10:42:14] <mayankmadan>	 himeshi, sorry i was away, can you explain which test is needed to be implemented. because there already is a test for section in SFFormPrinterTest class
[11:00:00] <himeshi>	 mayankmadan: Yes, the one that needs to be implemented is for when an existing page with sections is being edited. That is expected data text contains not just the header but content for that section as well.
[12:03:45] <mayankmadan>	 himeshi, i finally am getting these tests
[12:04:31] <himeshi>	 mayankmadan: Great! :)
[12:14:07] <grrrit-wm>	 (CR) Tpt: [C: 2] "Thanks" [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/103985 (owner: Legoktm)
[12:14:09] <grrrit-wm>	 (Merged) jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SemanticGenealogy] - https://gerrit.wikimedia.org/r/103985 (owner: Legoktm)
[20:53:54] <grrrit-wm>	 (PS1) Siebrand: Replaces uses of methods and code for MediaWiki < 1.19 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/104135
[20:54:22] <grrrit-wm>	 (PS2) Siebrand: Replaces uses of methods and code for MediaWiki < 1.19 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/104135
[21:02:04] <grrrit-wm>	 (CR) Yaron Koren: "Hi Siebrand - we just removed support for MW 1.17 a few weeks ago, so I'm not planning to remove support for MW 1.18 any time soon; probab" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/104135 (owner: Siebrand)
[21:08:33] <grrrit-wm>	 (Abandoned) Siebrand: Replace uses of methods and code for MediaWiki < 1.19 [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/104135 (owner: Siebrand)
[21:19:02] <grrrit-wm>	 (CR) Siebrand: [C: 2] "For some reason there hasn't been an export for SemanticForms for a while. Not sure why that happened." [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/104138 (owner: L10n-bot)
[21:19:05] <grrrit-wm>	 (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/104138 (owner: L10n-bot)
[22:41:01] <grrrit-wm>	 (PS1) Siebrand: Replace some deprecated functions [extensions/SemanticPageMaker] - https://gerrit.wikimedia.org/r/104152