[04:23:24] [travis-ci] JeroenDeDauw/Maps#57 (master - 90ab001 : jeroendedauw): The build was broken. [04:23:24] [travis-ci] Change view : https://github.com/JeroenDeDauw/Maps/compare/532e1dd86a5c...90ab0012c85b [04:23:24] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/Maps/builds/14789657 [04:25:03] [travis-ci] JeroenDeDauw/Maps#58 (master - 0319ffb : Jeroen De Dauw): The build was broken. [04:25:03] [travis-ci] Change view : https://github.com/JeroenDeDauw/Maps/compare/90ab0012c85b...0319ffbdd667 [04:25:03] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/Maps/builds/14789721 [04:31:09] [travis-ci] JeroenDeDauw/Maps#59 (master - 0e25042 : jeroendedauw): The build is still failing. [04:31:09] [travis-ci] Change view : https://github.com/JeroenDeDauw/Maps/compare/0319ffbdd667...0e25042d9bb2 [04:31:09] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/Maps/builds/14789857 [04:34:38] [travis-ci] JeroenDeDauw/Maps#60 (master - cb02247 : jeroendedauw): The build is still failing. [04:34:38] [travis-ci] Change view : https://github.com/JeroenDeDauw/Maps/compare/0e25042d9bb2...cb02247ce5c6 [04:34:38] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/Maps/builds/14789939 [05:57:25] hola [15:22:52] [travis-ci] JeroenDeDauw/SemanticMaps#5 (master - 2e0fded : jeroendedauw): The build has errored. [15:22:52] [travis-ci] Change view : https://github.com/JeroenDeDauw/SemanticMaps/compare/2473793bfb17...2e0fded8d352 [15:22:52] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/SemanticMaps/builds/14810404 [16:18:16] (CR) Yaron Koren: "I tested it, and this doesn't work for me! Adding the 'jquery.byteLimit' module is fine, but adding the 'ext.semanticforms.wikieditor' mod" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98111 (owner: Dev-zero) [16:21:40] Yaron: ping? [16:22:00] Yaron: did you test with editor=wikieditor without my patch? [16:23:28] Yaron: that error basically says that 'mediawiki.action.edit' is loaded (since it needs byteLimit) but 'jquery.byteLimit' is not [16:23:36] (PS1) Yaron Koren: Added new 'sfFormPrinterSetup' hook [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98536 [16:23:38] even though both are specified in the very same line [16:24:11] dev-zero: hello! [16:24:32] Yes, I did test it without the patch - it works for me. [16:25:08] then I have no idea what's going there [16:25:18] I mean: the patch explicitly adds byteLimit [16:26:48] dev-zero: you can see the problem here, using a test form: http://discoursedb.org/wiki/Special:FormEdit/New_Employee/Test_employee_page [16:27:47] And 'jquery.byteLimit' is definitely getting called in the code. (Whether's it's actually getting loaded is a different story - I haven't checked.) [16:28:58] (CR) Yaron Koren: [C: 2 V: 1] Added new 'sfFormPrinterSetup' hook [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98536 (owner: Yaron Koren) [16:29:05] (Merged) jenkins-bot: Added new 'sfFormPrinterSetup' hook [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98536 (owner: Yaron Koren) [16:31:21] Yaron: ok, verified it [16:31:27] Yaron: must be some kind of race condition [16:31:43] because #wpSummary is defined, $( '#wpSummary' ) is defined as well [16:32:07] and when I call this manually: $( '#wpSummary' ).byteLimit(255) after loading, it works [16:33:19] So does that require a change to the MW module? [16:40:23] Yaron: no idea, actually [16:40:43] Yaron: but my guess is that there is something fundamentally wrong when using loadModuleScripts on MW modules [16:40:57] since they use dependencies a lot [16:41:12] instead, loadModules should probably be used [16:41:49] the problem is: I tried that and got some other errors afterwards [16:43:25] maybe it works if I patch MsUpload to explicitly depend on mediawiki.action.edit, since it uses some of its function [16:44:05] Man. [16:44:24] ... on the other hand can extensions of the wikiEditor probably expect the module mediawiki.action.edit to be loaded by default [16:44:37] ... since they expect to be running in the "edit" action anyway [16:45:38] Yaron: another question: when creating a page via the SpecialFormEdit page, the action mediawiki sees is 'view' [16:45:56] which disables all extensions to the wikiEditor following mediawikis best practices [16:46:25] http://www.mediawiki.org/wiki/Manual:Custom_edit_buttons [16:46:52] according to ^^ they should only enable themselves if wgAction is 'edit' or 'submit' [16:48:31] would it be possible to set a different action for Special:FormEdit/... ? [16:48:34] Oh, hm... is that connected? [16:50:06] Is the behavior different if the URL is of the form "...action=formedit"? [16:55:27] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#200 (tests - b04366c : mwjames): The build has errored. [16:55:27] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/6f69f802d0bd...b04366c419a3 [16:55:27] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14815396 [16:56:35] yes, they're connected in the sense that the wikiEditor displayed for the Free Text field looks/behaves different thant when using the Edit action [17:00:52] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#201 (tests - bba5c6d : mwjames): The build failed. [17:00:52] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/b04366c419a3...bba5c6d4b306 [17:00:52] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14815680 [17:02:31] dev-zero: I don't know if the action can be made "edit", though, since really the action is "formedit"... if it were done, it would have to be via some sort of hack. [17:03:54] Yaron: well, the formedit is ok, I can simply patch my wikiEditor extensions to enable themselves on wgAction='formedit' [17:04:35] the problem is that the wgAction=view when creating a page via Special:FormEdit/MyForm [17:08:33] nervertheless, I could solve my problem of the MsUpload not inserting text by adding mediawiki.action.edit to its module dependency [17:08:36] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#202 (tests - 143c517 : mwjames): The build is still failing. [17:08:36] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/bba5c6d4b306...143c517554cd [17:08:36] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14816165 [17:08:42] I will therefore close the pull request [17:09:43] nevertheless, I am really not sure whether it makes sense to use addModuleScripts() in includes/forminputs/SF_FormInput.php since it ignores dependencies of the modules [17:11:26] (Abandoned) Dev-zero: Load mediawiki.action.edit when displaying a text area input [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98111 (owner: Dev-zero) [17:12:04] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#203 (tests - f3e8163 : mwjames): The build is still failing. [17:12:04] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/143c517554cd...f3e81631b3b9 [17:12:04] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14816305 [17:31:00] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#205 (tests - 95c9a6b : mwjames): The build has errored. [17:31:00] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/f3e81631b3b9...95c9a6b7ba9f [17:31:00] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14817480 [17:33:26] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#206 (tests - 3346ed1 : mwjames): The build has errored. [17:33:26] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/95c9a6b7ba9f...3346ed197677 [17:33:26] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14817576 [18:11:13] (PS2) Nischayn22: [WIP]Adding support for DataVisualizer [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/98390 [19:55:44] (PS1) Yaron Koren: Added fixes for template creation, when generated by Page Schemas [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98596 [19:57:56] (CR) Yaron Koren: [C: 2 V: 1] Added fixes for template creation, when generated by Page Schemas [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98596 (owner: Yaron Koren) [19:58:17] (Merged) jenkins-bot: Added fixes for template creation, when generated by Page Schemas [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98596 (owner: Yaron Koren) [20:15:03] (PS1) Yaron Koren: Whitespace fixes [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98604 [20:16:34] (CR) Yaron Koren: [C: 2 V: 1] Whitespace fixes [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98604 (owner: Yaron Koren) [20:18:22] (Merged) jenkins-bot: Whitespace fixes [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/98604 (owner: Yaron Koren) [21:08:23] [travis-ci] JeroenDeDauw/SemanticMaps#6 (master - 99e2fd9 : Jeroen De Dauw): The build has errored. [21:08:23] [travis-ci] Change view : https://github.com/JeroenDeDauw/SemanticMaps/compare/2e0fded8d352...99e2fd9ba7e4 [21:08:23] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/SemanticMaps/builds/14827909 [23:08:56] [travis-ci] SemanticMediaWiki/SemanticMediaWiki#215 (tests - 17586c4 : mwjames): The build was canceled. [23:08:56] [travis-ci] Change view : https://github.com/SemanticMediaWiki/SemanticMediaWiki/compare/9015c5f300bd...17586c453f98 [23:08:56] [travis-ci] Build details : http://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/builds/14835046