[01:07:19] <grrrit-wm>	 (PS1) Jeroen De Dauw: Clean work, mostly focused on namespace usage [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86398
[01:14:20] <grrrit-wm>	 (PS1) Jeroen De Dauw: DISerializer ns usage cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86399
[01:14:26] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] DISerializer ns usage cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86399 (owner: Jeroen De Dauw)
[01:17:01] <grrrit-wm>	 (PS1) Jeroen De Dauw: Remove now obsolete compat code [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400
[01:18:47] <grrrit-wm>	 (PS2) Jeroen De Dauw: DISerializer ns usage cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86399
[01:23:15] <grrrit-wm>	 (PS1) Jeroen De Dauw: Update release number [extensions/SemanticBundle] - https://gerrit.wikimedia.org/r/86401
[01:23:42] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2 V: 2] Update release number [extensions/SemanticBundle] - https://gerrit.wikimedia.org/r/86401 (owner: Jeroen De Dauw)
[01:50:42] <grrrit-wm>	 (PS1) Jeroen De Dauw: Fix fatal error in StoreUpdater [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86402
[02:01:37] <grrrit-wm>	 (CR) Mwjames: "Some SMWSemanticData references might be still exists in classes without test coverage such as SMW_Exp_Data or SMW_SQLStore3_Writers. I ha" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86398 (owner: Jeroen De Dauw)
[02:05:17] <grrrit-wm>	 (CR) Mwjames: [C: 2] "but no need to drag this." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86398 (owner: Jeroen De Dauw)
[02:06:33] <grrrit-wm>	 (PS1) Jeroen De Dauw: UpdateJob related cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403
[02:06:47] <grrrit-wm>	 (Merged) jenkins-bot: Clean work, mostly focused on namespace usage [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86398 (owner: Jeroen De Dauw)
[02:08:00] <grrrit-wm>	 (CR) Jeroen De Dauw: "The aliases have not been removed. You can still use SMWSemanticData as name. With this change IDEs actually understand SMWSemanticData ag" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86398 (owner: Jeroen De Dauw)
[02:08:04] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] UpdateJob related cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403 (owner: Jeroen De Dauw)
[02:10:26] <grrrit-wm>	 (CR) Mwjames: "Do we need a test case for this change?" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400 (owner: Jeroen De Dauw)
[02:10:46] <grrrit-wm>	 (PS2) Jeroen De Dauw: UpdateJob related cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403
[02:21:06] <grrrit-wm>	 (CR) Mwjames: [C: 2] DISerializer ns usage cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86399 (owner: Jeroen De Dauw)
[02:22:33] <grrrit-wm>	 (Merged) jenkins-bot: DISerializer ns usage cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86399 (owner: Jeroen De Dauw)
[02:22:36] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Register #ask as callback [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85389 (owner: Mwjames)
[02:22:38] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Register #ask as callback [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85389 (owner: Mwjames)
[02:24:47] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] "(1 comment)" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85417 (owner: Mwjames)
[02:24:48] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Replace SkinTemplateToolboxEnd hook with \SMW\BaseTemplateToolbox [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85417 (owner: Mwjames)
[02:31:06] <grrrit-wm>	 (PS1) Jeroen De Dauw: Minor cleanup in SMWDataValue [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86405
[02:31:17] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Minor cleanup in SMWDataValue [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86405 (owner: Jeroen De Dauw)
[02:33:51] <grrrit-wm>	 (PS2) Mwjames: Fix fatal error in StoreUpdater [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86402 (owner: Jeroen De Dauw)
[02:36:32] <grrrit-wm>	 (PS1) Jeroen De Dauw: Flip conditions for readability [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86406
[02:38:43] <grrrit-wm>	 (CR) Mwjames: [C: 2] Fix fatal error in StoreUpdater [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86402 (owner: Jeroen De Dauw)
[02:39:01] <grrrit-wm>	 (PS1) Jeroen De Dauw: Add extra check [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86407
[02:39:14] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Add extra check [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86407 (owner: Jeroen De Dauw)
[02:39:47] <grrrit-wm>	 (Merged) jenkins-bot: Add extra check [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86407 (owner: Jeroen De Dauw)
[02:40:06] <grrrit-wm>	 (Merged) jenkins-bot: Fix fatal error in StoreUpdater [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86402 (owner: Jeroen De Dauw)
[02:43:06] <grrrit-wm>	 (PS1) Jeroen De Dauw: Add extra check [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86408
[02:43:24] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Add extra check [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86408 (owner: Jeroen De Dauw)
[02:43:45] <grrrit-wm>	 (Merged) jenkins-bot: Add extra check [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86408 (owner: Jeroen De Dauw)
[02:51:40] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-SemanticMediaWiki#232 (master - 227d74a : jeroendedauw): The build was broken.
[02:51:40] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-SemanticMediaWiki/compare/7133f63c18de...227d74a7b8b3
[02:51:40] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-SemanticMediaWiki/builds/11918446
[02:59:10] <grrrit-wm>	 (CR) Mwjames: "Tests on Travis against MW 1.19 are failing with:" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86402 (owner: Jeroen De Dauw)
[03:23:23] <grrrit-wm>	 (PS1) Jeroen De Dauw: Improvements to SMGeoCoordsValue [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86409
[03:23:34] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2 V: 2] Improvements to SMGeoCoordsValue [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86409 (owner: Jeroen De Dauw)
[03:30:14] <grrrit-wm>	 (PS1) Jeroen De Dauw: Remove dead code [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86410
[03:38:53] <grrrit-wm>	 (PS3) Mwjames: \SMW\ContextAware + SMW\BaseContext [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85428
[03:52:13] <grrrit-wm>	 (CR) Mwjames: "Here is the problem ... 1.19 doesn't check for !MWNamespace::exists( $ns ) and therefore doesn't return null which causes the test to fail" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86402 (owner: Jeroen De Dauw)
[03:57:47] <grrrit-wm>	 (PS1) Jeroen De Dauw: Simpliy namespace refs [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86411
[03:57:57] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Remove dead code [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/86410 (owner: Jeroen De Dauw)
[03:58:09] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Simpliy namespace refs [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86411 (owner: Jeroen De Dauw)
[04:00:37] <grrrit-wm>	 (Merged) jenkins-bot: Simpliy namespace refs [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86411 (owner: Jeroen De Dauw)
[04:03:36] <grrrit-wm>	 (CR) Jeroen De Dauw: "I don't quite understand what this change is about." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85428 (owner: Mwjames)
[04:08:52] <grrrit-wm>	 (PS1) Jeroen De Dauw: Add testDoUpdateForSpecialPage and fix test compat with MW 1.19 [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86412
[04:08:59] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Add testDoUpdateForSpecialPage and fix test compat with MW 1.19 [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86412 (owner: Jeroen De Dauw)
[04:11:46] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-SemanticMediaWiki#233 (master - fe1b649 : jeroendedauw): The build is still failing.
[04:11:46] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-SemanticMediaWiki/compare/227d74a7b8b3...fe1b649f9180
[04:11:46] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-SemanticMediaWiki/builds/11919306
[04:20:38] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-SemanticMediaWiki#234 (master - 0ea681e : jeroendedauw): The build was fixed.
[04:20:38] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-SemanticMediaWiki/compare/fe1b649f9180...0ea681edaa83
[04:20:38] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-SemanticMediaWiki/builds/11919440
[04:22:12] <grrrit-wm>	 (PS3) Mwjames: Register #ask as callback [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85389
[04:23:08] <grrrit-wm>	 (CR) Mwjames: "rebase" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85389 (owner: Mwjames)
[04:24:34] <grrrit-wm>	 (CR) Mwjames: [C: 2] Register #ask as callback [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85389 (owner: Mwjames)
[04:26:03] <grrrit-wm>	 (Merged) jenkins-bot: Register #ask as callback [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85389 (owner: Mwjames)
[04:27:08] <grrrit-wm>	 (PS2) Mwjames: Remove now obsolete compat code [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400 (owner: Jeroen De Dauw)
[05:09:30] <grrrit-wm>	 (Abandoned) Mwjames: \SMW\ExtensionSetup (use wgExtensionFunctions for initialization) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/78964 (owner: Mwjames)
[05:10:29] <grrrit-wm>	 (Abandoned) Mwjames: SMW\HooksHandler create testable and separable hooks instantiation [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/64610 (owner: Mwjames)
[06:25:52] <grrrit-wm>	 (PS3) Mwjames: UpdateJob related cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403 (owner: Jeroen De Dauw)
[06:27:57] <grrrit-wm>	 (CR) Mwjames: [C: 2] UpdateJob related cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403 (owner: Jeroen De Dauw)
[06:29:25] <grrrit-wm>	 (Merged) jenkins-bot: UpdateJob related cleanup [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403 (owner: Jeroen De Dauw)
[11:02:12] <grrrit-wm>	 (CR) Jeroen De Dauw: "James, what exactly did you do with PS3? Big diff, so I guess it included rebase. Can you please use real commits rather then amends to do" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403 (owner: Jeroen De Dauw)
[11:18:04] <grrrit-wm>	 (CR) Mwjames: "It was the Alias.php, since one of the previous commits added something to the Alias this one got stuck do to a different order." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86403 (owner: Jeroen De Dauw)
[11:47:41] <grrrit-wm>	 (PS8) Jeroen De Dauw: Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - https://gerrit.wikimedia.org/r/73738 (owner: Netbrain)
[11:48:36] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Added a toggle fullscreen button to Maps that is enabled trough the parameter enablefullscreen=true [extensions/Maps] - https://gerrit.wikimedia.org/r/73738 (owner: Netbrain)
[11:50:09] <grrrit-wm>	 (CR) Mwjames: "Well the idea was to use some kind of "service locator" (it is more context than a pure locator) which allows to inject a builder without " [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85428 (owner: Mwjames)
[11:51:13] <grrrit-wm>	 (PS3) Jeroen De Dauw: Remove now obsolete compat code [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400
[12:19:05] <grrrit-wm>	 (PS1) Jeroen De Dauw: Add DIWikiPageTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86425
[12:19:06] <grrrit-wm>	 (PS1) Jeroen De Dauw: Added tests for equals method to DataItemTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86426
[12:19:07] <grrrit-wm>	 (PS1) Jeroen De Dauw: Improvements to DataItemTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86427
[12:19:32] <grrrit-wm>	 (CR) Jeroen De Dauw: "You can has tests - see follow ups :)" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400 (owner: Jeroen De Dauw)
[12:19:39] <grrrit-wm>	 (PS2) Jeroen De Dauw: Flip conditions for readability [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86406
[12:25:43] <grrrit-wm>	 (CR) Mwjames: [C: 2] "それなら、文句無し (therefore no complains ;-) )" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400 (owner: Jeroen De Dauw)
[12:27:12] <grrrit-wm>	 (Merged) jenkins-bot: Remove now obsolete compat code [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86400 (owner: Jeroen De Dauw)
[12:28:03] <grrrit-wm>	 (CR) Mwjames: [C: 2] Add DIWikiPageTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86425 (owner: Jeroen De Dauw)
[12:29:31] <grrrit-wm>	 (Merged) jenkins-bot: Add DIWikiPageTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86425 (owner: Jeroen De Dauw)
[12:38:34] <grrrit-wm>	 (Abandoned) Mwjames: \SMW\FunctionHookRegistry register WebRequest object [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/83985 (owner: Mwjames)
[12:46:28] <grrrit-wm>	 (CR) Mwjames: [C: 2] Added tests for equals method to DataItemTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86426 (owner: Jeroen De Dauw)
[12:47:56] <grrrit-wm>	 (Merged) jenkins-bot: Added tests for equals method to DataItemTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86426 (owner: Jeroen De Dauw)
[12:58:08] <grrrit-wm>	 (PS1) Jeroen De Dauw: Update readme [extensions/Ask] - https://gerrit.wikimedia.org/r/86428
[12:58:10] <grrrit-wm>	 (PS1) Jeroen De Dauw: Remove clutter comments [extensions/Ask] - https://gerrit.wikimedia.org/r/86429
[12:58:17] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2 V: 2] Update readme [extensions/Ask] - https://gerrit.wikimedia.org/r/86428 (owner: Jeroen De Dauw)
[13:01:45] <grrrit-wm>	 (CR) Mwjames: [C: 2] Improvements to DataItemTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86427 (owner: Jeroen De Dauw)
[13:03:12] <grrrit-wm>	 (Merged) jenkins-bot: Improvements to DataItemTest [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86427 (owner: Jeroen De Dauw)
[13:05:34] <grrrit-wm>	 (PS3) Mwjames: Flip conditions for readability [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86406 (owner: Jeroen De Dauw)
[13:07:39] <grrrit-wm>	 (CR) Mwjames: [C: 2] Flip conditions for readability [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86406 (owner: Jeroen De Dauw)
[13:08:34] <grrrit-wm>	 (PS1) Jeroen De Dauw: Add to readme [extensions/Ask] - https://gerrit.wikimedia.org/r/86431
[13:08:44] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Remove clutter comments [extensions/Ask] - https://gerrit.wikimedia.org/r/86429 (owner: Jeroen De Dauw)
[13:08:51] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2] Add to readme [extensions/Ask] - https://gerrit.wikimedia.org/r/86431 (owner: Jeroen De Dauw)
[13:09:05] <grrrit-wm>	 (Merged) jenkins-bot: Flip conditions for readability [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/86406 (owner: Jeroen De Dauw)
[13:10:23] <grrrit-wm>	 (CR) Siebrand: "(1 comment)" [extensions/Maps] - https://gerrit.wikimedia.org/r/73738 (owner: Netbrain)
[13:13:01] <grrrit-wm>	 (PS1) Jeroen De Dauw: Update requirement version [extensions/Ask] - https://gerrit.wikimedia.org/r/86432
[13:13:10] <grrrit-wm>	 (CR) Jeroen De Dauw: [C: 2 V: 2] Update requirement version [extensions/Ask] - https://gerrit.wikimedia.org/r/86432 (owner: Jeroen De Dauw)
[13:21:34] <grrrit-wm>	 (PS2) Mwjames: Replace SkinTemplateToolboxEnd hook with \SMW\BaseTemplateToolbox [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85417
[13:22:00] <grrrit-wm>	 (CR) Mwjames: "Rebase" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85417 (owner: Mwjames)
[13:36:32] <grrrit-wm>	 (CR) Mwjames: [C: 2] Replace SkinTemplateToolboxEnd hook with \SMW\BaseTemplateToolbox [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85417 (owner: Mwjames)
[13:37:58] <grrrit-wm>	 (Merged) jenkins-bot: Replace SkinTemplateToolboxEnd hook with \SMW\BaseTemplateToolbox [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85417 (owner: Mwjames)
[19:05:56] <grrrit-wm>	 (CR) Nischayn22: [V: -1] "Needs rebase" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[19:08:38] <grrrit-wm>	 (CR) Nischayn22: [V: -1] "Needs rebase, will try fixing this sooner." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69306 (owner: Nischayn22)
[19:18:36] <grrrit-wm>	 (PS12) Nischayn22: Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668
[19:33:07] <grrrit-wm>	 (PS13) Mwjames: Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[19:34:37] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[19:36:54] <grrrit-wm>	 (CR) Mwjames: "PHP Fatal error: Call to undefined method SMW\Test\SQLStore\StatisticsCollectorTest::newInstance() in /srv/ssd/jenkins-slave/workspace/mw" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[19:41:17] <grrrit-wm>	 (CR) Nischayn22: "Should it be calling getInstance() everywhere?" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[19:46:49] <grrrit-wm>	 (CR) Mwjames: "For consistency, you changed it back to getInstance (this is only a matter of semantics) but then it should be changed at all places other" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[20:18:32] <grrrit-wm>	 (CR) Nischayn22: "Some of my SettingsTests are failing. Will revert to this later on." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[20:35:17] <grrrit-wm>	 (PS14) Mwjames: Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[20:44:54] <grrrit-wm>	 (CR) Mwjames: "I fixed the test now." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[20:45:40] <grrrit-wm>	 (CR) Mwjames: "The test itself has some design issues but I'm not going to fix here." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)
[20:49:20] <grrrit-wm>	 (CR) Mwjames: "Nischayn, is this ok now and can it be merged?" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22)