[08:26:12] <grrrit-wm>	 (PS2) Netbrain: Added a new parameter (activeicon)) to semantic maps. [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/82219
[08:26:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Added a new parameter (activeicon)) to semantic maps. [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/82219 (owner: Netbrain)
[08:28:46] <grrrit-wm>	 (CR) Netbrain: [C: 1] Set correct default-value for offset [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/71324 (owner: MathiasLidal)
[08:32:07] <grrrit-wm>	 (PS3) Netbrain: Added a new parameter (activeicon)) to semantic maps. [extensions/SemanticMaps] - https://gerrit.wikimedia.org/r/82219
[08:32:35] <grrrit-wm>	 (CR) Mwjames: "I tried to figure out what formHTML is doing and why it is failing. After spending 10 min I figured why [0] but just locking at the code m" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/83213 (owner: Himeshi)
[10:11:07] <grrrit-wm>	 (CR) Tobias Gritschacher: [C: 2] Test logic that was not tested yet [extensions/Ask] - https://gerrit.wikimedia.org/r/85537 (owner: Jeroen De Dauw)
[10:11:18] <grrrit-wm>	 (Merged) jenkins-bot: Test logic that was not tested yet [extensions/Ask] - https://gerrit.wikimedia.org/r/85537 (owner: Jeroen De Dauw)
[12:07:56] <grrrit-wm>	 (PS1) Mwjames: Test was missing, didn't to catch a renaming issue (newCacheId) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85661
[12:08:28] <grrrit-wm>	 (PS2) Mwjames: Test was missing, didn't to catch a renaming issue (newCacheId) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85661
[12:12:11] <grrrit-wm>	 (CR) Mwjames: [C: 2] Test was missing, didn't caught a renaming issue (newCacheId) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85661 (owner: Mwjames)
[12:13:50] <grrrit-wm>	 (Merged) jenkins-bot: Test was missing, didn't caught a renaming issue (newCacheId) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85661 (owner: Mwjames)
[13:10:18] <grrrit-wm>	 (PS2) Mwjames: \SMW\ContextAware + SMW\BaseContext [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/85428
[15:32:42] <grrrit-wm>	 (PS3) Himeshi: Added unit tests for the SFFormPrinter class [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/83213
[18:22:19] <grrrit-wm>	 (Abandoned) Nischayn22: Autocenter on Polygons and other shapes. [extensions/Maps] - https://gerrit.wikimedia.org/r/36700 (owner: Nischayn22)
[18:38:45] <drobbins>	 yaron, are you around?
[18:39:48] <yaron>	 Hi! Yes.
[18:40:16] <Nischayn22>	 Here comes the most active member of the channel :)
[18:40:22] <drobbins>	 hey
[18:40:52] <drobbins>	 yaron: okay, I'm looking at writing a jquery-based widget. Mediawiki provides jquery, yes?
[18:40:58] <yaron>	 Yeah.
[18:41:03] <drobbins>	 okay
[18:41:30] <drobbins>	 so I can just embed what i need in JS in a <script> block in the widget eh?
[18:42:03] <yaron>	 By "widget", you mean something that uses the Widgets extension?
[18:42:20] <drobbins>	 yes
[18:42:29] <yaron>	 Yes, that should work.
[18:42:34] <drobbins>	 okay
[18:42:37] <drobbins>	 I had another question for you.
[18:42:41] <drobbins>	 I am using SemanticSignup.
[18:42:45] <drobbins>	 for one of my wikis
[18:43:04] <drobbins>	 are the "mandatory" forms checks implemented just in javascript? Or are they enforced server-side too?
[18:43:12] <drobbins>	 because bots seem to be getting by the mandatory forms stuff.
[18:43:28] <yaron>	 Yeah, it's just Javascript.
[18:43:34] <yaron>	 You have some rogue bots? :)
[18:44:40] <drobbins>	 yes
[18:44:50] <drobbins>	 they just disable JS and submit the form
[18:45:18] <drobbins>	 if the mandatory fields were enforced server-side, then SemanticSignup would provide really excellent spam prevention capabilities.
[18:45:27] <drobbins>	 since you could mix-up the sign-up process whenever you wanted.
[18:52:25] <Nischayn22>	 Isn't the Captcha for that?
[18:52:44] <drobbins>	 spambots eat captchas for breakfast
[18:53:40] <Nischayn22>	 fill them up so they don't reach your lunch buffet
[18:55:00] <drobbins>	 if I could find a way to feed them woodchips for breakfast, I would
[18:57:33] <yaron>	 drobbins: these spambots don't use SF anyway, do they?
[19:05:23] <drobbins>	 yaron: well they are designed to hit the standard mediawiki signup page.
[19:05:39] <drobbins>	 yaron: but if SF did server-side checks, they would die on any mandatory field
[19:06:10] <yaron>	 Oh, right, signup.
[19:06:36] <yaron>	 Not if they filled out those fields, of course.
[19:08:00] <drobbins>	 right.
[19:08:13] <drobbins>	 but mediawiki bots won't.
[19:09:39] <yaron>	 That's true.
[19:09:46] <yaron>	 Well, possibly true.
[19:10:29] <yaron>	 Anyway, you could always create a mini-extension that uses some hook to check if a certain field exists, and dies in some way if not.
[19:24:24] <drobbins>	 yep, I don't know how to do that.
[19:24:27] <drobbins>	 :P
[19:43:26] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Localisation updates from http://translatewiki.net. [extensions/SemanticDrilldown] - https://gerrit.wikimedia.org/r/85750 (owner: L10n-bot)
[20:44:59] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] Creating forms with page section via PageSchemas [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/80864 (owner: Himeshi)
[20:45:18] <grrrit-wm>	 (Merged) jenkins-bot: Creating forms with page section via PageSchemas [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/80864 (owner: Himeshi)
[20:50:01] <grrrit-wm>	 (CR) Yaron Koren: [C: 2 V: 1] Added unit tests for the SFFormPrinter class [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/83213 (owner: Himeshi)
[20:50:04] <grrrit-wm>	 (Merged) jenkins-bot: Added unit tests for the SFFormPrinter class [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/83213 (owner: Himeshi)
[20:50:53] <grrrit-wm>	 (CR) Yaron Koren: "I'm approving this change - it looks good to me. The usage of global variables, and the complexity of the code, are issues that need to be" [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/83213 (owner: Himeshi)