[00:27:01] (PS14) Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 [00:48:54] (CR) Mwjames: [C: -1] "Adoption needed in order to use the HooksLoader." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/73551 (owner: Mwjames) [00:49:55] (CR) Mwjames: [C: -1] "If I have time I have to re-visit this change." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/72891 (owner: Mwjames) [01:37:19] (PS1) Mwjames: \SMW\Test\MockObjectBuilder add some mocks [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76872 [01:39:21] (CR) Mwjames: [C: 2] \SMW\Test\MockObjectBuilder add some mocks [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76872 (owner: Mwjames) [01:40:42] (Merged) jenkins-bot: \SMW\Test\MockObjectBuilder add some mocks [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76872 (owner: Mwjames) [01:46:43] (PS15) Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 [02:05:10] (PS1) Mwjames: Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76875 [02:05:46] (PS2) Mwjames: Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76875 [02:08:56] (CR) Mwjames: [C: 2] Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76875 (owner: Mwjames) [02:10:15] (Merged) jenkins-bot: Add (Cacheable, Configurable, StoreAccess) base interface [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76875 (owner: Mwjames) [02:20:08] (PS16) Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 [02:26:21] (CR) Mwjames: "Now tests are also passed on MW 1.19." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 (owner: Mwjames) [08:15:03] (CR) Nikerabbit: "I'm running "make safe" for unit tests in core with plenty of extensions enabled." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76703 (owner: Nikerabbit) [12:18:06] (PS2) Jeroen De Dauw: Get rid of pointless verbose GPL headers [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76747 [12:35:21] (PS1) Jeroen De Dauw: Fix method call [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76910 [13:18:47] (CR) Mwjames: [C: 2] "Good call, I did wrote a test yet since it is not used yet, so it would have eventually turned up in the test." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76910 (owner: Jeroen De Dauw) [13:19:04] (CR) Mwjames: "I mean I didn't wrote a test ..." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76910 (owner: Jeroen De Dauw) [13:20:07] (Merged) jenkins-bot: Fix method call [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76910 (owner: Jeroen De Dauw) [13:25:57] (CR) Mwjames: [C: 2] Get rid of pointless verbose GPL headers [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76747 (owner: Jeroen De Dauw) [13:27:24] (Merged) jenkins-bot: Get rid of pointless verbose GPL headers [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76747 (owner: Jeroen De Dauw) [13:52:16] (CR) Yaron Koren: [C: 2 V: 1] Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343 (owner: Himeshi) [13:52:19] (Merged) jenkins-bot: Modified Special:CreateForm for page sections [extensions/SemanticForms] - https://gerrit.wikimedia.org/r/75343 (owner: Himeshi) [13:59:07] (PS1) Mwjames: Split interfaces [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76917 [14:02:25] (CR) Mwjames: "If not utilities, where should it go?" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76917 (owner: Mwjames) [14:23:14] (PS2) Mwjames: Split interfaces [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76917 [14:25:06] (PS17) Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 [14:25:40] (CR) Mwjames: "Eliminate GPL header" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 (owner: Mwjames) [15:00:26] (PS3) Mwjames: Split interfaces [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76917 [15:04:19] (PS4) Mwjames: Split interfaces + move out of utilities dir [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76917 [15:13:37] (PS1) Mwjames: Update Aliases.php [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76925 [15:14:15] (CR) Jeroen De Dauw: [C: 2] Update Aliases.php [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76925 (owner: Mwjames) [15:16:09] (Merged) jenkins-bot: Update Aliases.php [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76925 (owner: Mwjames) [16:09:20] (PS18) Mwjames: \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 [16:10:06] (CR) Mwjames: "What can I say, missed a header ..." [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 (owner: Mwjames) [16:19:43] (CR) Mwjames: [C: 1] \SMW\Factbox + \SMW\FactboxPresenter [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/61171 (owner: Mwjames) [19:15:33] (CR) Jeroen De Dauw: [C: 2] Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22) [19:15:35] (CR) jenkins-bot: [V: -1] Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22) [19:16:37] (CR) Jeroen De Dauw: "Nischayn, did you test this?" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69306 (owner: Nischayn22) [19:26:57] (PS11) Mwjames: Use statistics from the stats table not Count(*) [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/69668 (owner: Nischayn22) [19:27:50] (PS1) Mwjames: Move SMWHooks::onArticlePurge to \SMW\ArticlePurge + tests [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76956 [19:36:16] (CR) Jeroen De Dauw: "(1 comment)" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76956 (owner: Mwjames) [20:08:58] (CR) Mwjames: "(1 comment)" [extensions/SemanticMediaWiki] - https://gerrit.wikimedia.org/r/76956 (owner: Mwjames)