[03:07:30] <_ken_> Is there a way to show the properties used on page? [03:07:58] <_ken_> I'm trying to get an inline query that shows all of the property values for a page. [12:43:30] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/65681 [13:34:45] yaron: Hey [13:34:53] Hello! [13:35:06] I have a problem regarding SemanticForms and SemanticSignup [13:35:11] Okay. [13:35:41] the tabindex generated by SemanticForms is wrong because SS inserts some HTML using a hook [13:36:35] Could SS increment the tabindex itself? [13:37:11] SS outputs the HTML using the onParserFirstCallInit hook [13:37:26] but SF uses a local variable for the tabindex [13:37:35] so I don't think it can [13:38:15] There's a global variable for the tab index, though... [13:38:16] $sfgTabIndex = 1; in formHTML() [13:38:21] is this the one? [13:38:24] Yes. [13:38:33] Anything that starts with "sfg" is a global. [13:38:53] hmm, that should be incremented then [13:39:16] That's my weird notation for globals, from before I realized that all globals are supposed to start with "$wg". :) [13:40:16] yeah, even SMW has a similar notation :) [13:40:49] Oh yeah... I think that's where I stole it from. [13:42:43] that solved the bug \o/ [13:44:44] Awesome! [13:46:56] New patchset: Nischayn22; "Correct tabIndexes" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68176 [13:47:13] yaron: ^ [13:48:49] Cool... although why do you have the 2nd variable, "$tabIndex", there - why not just use $sfgTabIndex directly? [13:51:02] actually you are right.. I was correcting tabIndex of SS and then adjusting it with SF [13:51:12] wait for PS2 [13:51:33] Should I check this one in anyway? [13:51:36] I mean, merge it. [13:52:23] no wait [13:53:02] Alright. [13:53:58] It's also weird that that file is mostly direct HTML, with PHP "bits" thrown in there - but that one looks like it's not your fault. [13:55:00] New patchset: Nischayn22; "Correct tabIndexes" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68176 [13:55:22] this one still has a problem [13:55:51] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68176 [13:56:03] Oh, oops. :) [13:56:05] SS starts incrementing it and there's an extra increment in the end of SS fields [13:56:24] Maybe we should just try to get you merge permission for that extension [13:56:25] . [13:56:29] Heh.. still it doesn't cause any difference in the UX [13:56:44] Yes, that's true... it's just really weird. [13:57:03] I haven't seen another MediaWiki, or MediaWiki extension, file that does that. [13:57:04] yaron: Yeah, and then I get to be the person who merges his own patches :p [13:57:17] Hey, welcome to my world. :) [13:58:02] Haha..what was weird btw? [13:58:13] Maybe we are talking different things there [13:59:00] The fact that there's a "?>" in the middle of the file, and then everything below it is HTML, basically, with "" bits thrown in. [13:59:48] That's how a lot of people do PHP programming, but I've never seen it in MediaWiki code before. [14:00:57] Oh, yes.. haven't you looked at the skins code? [14:01:11] Oh, yeah... except for the skins code. [14:02:08] and most would be using HTML:element() even to put a link :) [14:04:00] That's true, it's a little inefficient... but it's just weird to see it done the other way. [14:04:32] Plus, using the HTML class guarantees that you don't have Javascript-injection security leaks. [14:04:39] * Nischayn22 has some dhoklas [14:05:43] Yum. [14:09:10] I should serve dhoklas here like Carols serves tea at #gsoc :D [14:13:05] Sorry, I don't eat virtual dhoklas. :) [14:16:32] yaron: Let me know when you visit India :) [14:16:55] Alright, I will! [14:17:35] I haven't been yet, but it's pretty much at the top of my places to go see. [14:23:15] Great, In fact we should have a SMWCon here sometimes, but I don't know how much crowd will that attract [14:28:16] SMWCon India sounds awesome. [14:28:26] Will you be at Wikimania, by the way? [14:30:21] yaron: No [14:30:28] Alright. [14:30:46] yaron: Do you know some SMW users in India? [14:31:42] Well, there are a few I've heard from over the years - plus some people in Shanghai, Hong Kong and Japan. [14:32:28] And my upcoming GSoC student is in Sri Lanka. [14:32:34] There was only one I knew, it was a wiki of the month [14:32:41] Oh yes, that's right. [14:33:03] Not that many, all in all. [14:33:09] Oh that reminds me of Sri Lanka, need to visit that place some time [14:34:06] There's a lot of stuff to see in Asia! It's kind of overwhelming. [14:35:18] yeah, for me there's a lot to see in India itself [14:35:35] I have done three short trips over 4 months now [14:36:20] That sounds awesome. [14:37:04] New patchset: Nischayn22; "Login user after Signup" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68179 [14:37:44] yaron: ^ some code I copied from Special:UserLogin which magically does the login [14:39:12] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68179 [14:39:20] Woah! [14:39:34] Looks good! It's amazing that the old SS didn't actually log the user in... [14:39:48] yeah, that's strange [14:42:33] Actually its not so strange since its used only on 6 tracked wikis [14:45:44] yaron: I think we should release a newer version of SS later sometime [14:49:55] That sounds good! [14:52:37] Hmm the box around Login form looks weird [14:59:38] Nischayn22: in core MediaWiki? [15:00:05] No, when its in SS [15:00:22] Its easy to get rid of it though if needed [19:27:02] New patchset: Foxtrott; "Popup forms: Save Page button does not work anymore" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68218 [19:28:56] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68218 [21:12:08] New patchset: Foxtrott; "fix bug 48838 (Semantic Forms sfautoedit (and #autoedit) broken in 1.21)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68287 [21:14:14] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68287 [21:15:19] New patchset: Foxtrott; "fix bug (autoedit does never finish on error)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68289 [21:16:36] New patchset: Foxtrott; "fix bug (autoedit does never finish on error)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68289